RFR: JDK-8160926: FLAGS_COMPILER_CHECK_ARGUMENTS doesn't handle cross-compilation

2019-02-04 Thread Erik Joelsson
Please review this fix for configure flags checking. The macros for checking compiler capabilities were not able to handle cross compilation very well. With this fix, they accept an optional PREFIX argument, instructing them to check the compiler with the given prefix (which is either empty or

Re: RFR: JDK-8218177: Bump jib format_version to support new devkit archive layout

2019-02-04 Thread Erik Joelsson
This patch was a bit premature, but now with a proper fix in Jib, here is an updated version. It restores the use of the new devkit as well as changes some more instances of install_path to home_path. Webrev: http://cr.openjdk.java.net/~erikj/8218177/webrev.02/ /Erik On 2019-01-31 16:23, Eri

Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-04 Thread David Holmes
Hi Matthias, On 4/02/2019 9:36 pm, Baesken, Matthias wrote: Hi David, I want to follow your suggestion 😊 . I adjusted the comment , see globalDefinitions_xlc.hpp . Looks good. Thanks. Additionally I removed a strange ifdef handling pre-xlc10 versions that are not useful today any m

RE: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-04 Thread Baesken, Matthias
Hi David, I want to follow your suggestion 😊 . I adjusted the comment , see globalDefinitions_xlc.hpp . Additionally I removed a strange ifdef handling pre-xlc10 versions that are not useful today any more for OpenJDK ( we most likely cannot build jdk/jdk with xlc versions < 10). Ne