Hi David, I want to follow your suggestion 😊 . I adjusted the comment , see globalDefinitions_xlc.hpp .
Additionally I removed a strange ifdef handling pre-xlc10 versions that are not useful today any more for OpenJDK ( we most likely cannot build jdk/jdk with xlc versions < 10). New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.2/ Best regards, Matthias > -----Original Message----- > From: David Holmes <david.hol...@oracle.com> > Sent: Freitag, 1. Februar 2019 13:49 > To: Baesken, Matthias <matthias.baes...@sap.com>; 'hotspot- > d...@openjdk.java.net' <hotspot-...@openjdk.java.net>; > 'magnus.ihse.bur...@oracle.com' <magnus.ihse.bur...@oracle.com> > Cc: 'build-dev@openjdk.java.net' <build-dev@openjdk.java.net> > Subject: Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from > xlc16 on AIX > > Hi Matthias, > > On 1/02/2019 10:36 pm, Baesken, Matthias wrote: > > New webrev : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.1/ > > > > - adjusted globalDefinitions_xlc.hpp > > I don't think it makes sense to keep the comment which was obviously > copied from the gcc file: > > // On Linux NULL is defined as a special type '__null'. Assigning > __null to > // integer variable will cause gcc warning. Use NULL_WORD in places > where a > // pointer is stored as integer value. On some platforms, > sizeof(intptr_t) > > // sizeof(void*), so here we want something which is integer type, > but has the > // same size as a pointer. > > Rather something like: > > // Some platform/tool-chain combinations can't assign NULL to an integer > // type so we define NULL_WORD to use in those contexts. For xlc they > // are the same. > > Thanks, > David > >
