RE: bash configure: result from running a microsoft compiler was empty string

Hi Vitaly, Those instructions are out of date, just my original proposed patch. What we eventually ended up committing is much simpler. See http://hg.openjdk.java.net/jdk/jdk/file/72f05350b4b3/doc/building.md for the latest instructions. Thanks, -Andrew -Original Message- From: buil

Re: RFR: JDK-8221851: Use of THIS_FILE in hotspot invalidates precompiled header on Linux/GCC

2019年4月10日(水) 13:55 David Holmes : > > Hi Erik, > > On 9/04/2019 11:55 pm, Erik Joelsson wrote: > > Hello, > > > > Here is a new webrev with an even simpler change: > > > > http://cr.openjdk.java.net/~erikj/8221851/webrev.06/ > > > > I decided to just remove the usage of THIS_FILE from exceptions.h

Re: bash configure: result from running a microsoft compiler was empty string

Hi Vitaly, What do you see if you run: /mnt/c/Tools/VS/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe directly? Cheers, David On 10/04/2019 1:35 pm, Vitaly Provodin wrote: Hello, I'm trying to compile OpenJDK 13 (using WSL and following this instructions http://mail.openjd

Re: RFR: JDK-8221851: Use of THIS_FILE in hotspot invalidates precompiled header on Linux/GCC

Hi Erik, On 9/04/2019 11:55 pm, Erik Joelsson wrote: Hello, Here is a new webrev with an even simpler change: http://cr.openjdk.java.net/~erikj/8221851/webrev.06/ I decided to just remove the usage of THIS_FILE from exceptions.hpp since it did not work well. It currently does not work at all

bash configure: result from running a microsoft compiler was empty string

Hello, I'm trying to compile OpenJDK 13 (using WSL and following this instructions http://mail.openjdk.java.net/pipermail/build-dev/2018-December/024316.html ), but when I use: $ bash ./configure --with-boot-jdk=/mnt/

Re: RFR: 8221894: Add comments for docker tests in the test doc

Thank you so much Erik. On 2019/4/9 下午9:06, Erik Joelsson wrote: Sure, will do. /Erik On 2019-04-08 06:57, Erik Joelsson wrote: Looks good to me. /Erik On 2019-04-08 00:48, Jie Fu wrote: Hi David and Erik, Thank you for your review and very nice suggestions. Here is the latest version: h

Re: RFR 8221857: Collect code coverage for a subset of code

> On Apr 9, 2019, at 6:31 AM, Erik Joelsson wrote: > > Hello Shura, > > If JCOV_FILTERS is ever expected to be set on the make command line > (typically when running make run-test-prebuilt), then it would be good if we > could add a way to set it through TEST_OPTS=JCOV_FILTERS=... . Using t

Re: RFR: JDK-8221851: Use of THIS_FILE in hotspot invalidates precompiled header on Linux/GCC

Hello, Here is a new webrev with an even simpler change: http://cr.openjdk.java.net/~erikj/8221851/webrev.06/ I decided to just remove the usage of THIS_FILE from exceptions.hpp since it did not work well. It currently does not work at all on Windows or Macosx builds. On Linux it invalidates

Re: RFR 8221857: Collect code coverage for a subset of code

Hello Shura, If JCOV_FILTERS is ever expected to be set on the make command line (typically when running make run-test-prebuilt), then it would be good if we could add a way to set it through TEST_OPTS=JCOV_FILTERS=... . Using the officially supported input variables like this avoids the warn

Re: RFR (S): 8221979: Cleanups for building Windows resources

Hello, Looks ok to me. I assume you have inspected all affected files and made sure all attributes are the same pre and post this change? /Erik On 2019-04-09 02:55, Langer, Christoph wrote: Hi, during work on JDK-8221880 I spotted some opportunity for cleanup in Windows resource files and

Re: RFR: 8221894: Add comments for docker tests in the test doc

Sure, will do. /Erik On 2019-04-08 06:57, Erik Joelsson wrote: Looks good to me. /Erik On 2019-04-08 00:48, Jie Fu wrote: Hi David and Erik, Thank you for your review and very nice suggestions. Here is the latest version: http://cr.openjdk.java.net/~jiefu/8221894/webrev.03/ Please see com

RFR (S): 8221979: Cleanups for building Windows resources

Hi, during work on JDK-8221880 I spotted some opportunity for cleanup in Windows resource files and their handling in the build. The naming of variables used for customizing resource properties in the build system should be aligned between hotspot and JDK. This should be carefully reviewed by