Re: RFR: 8222362: Upgrade to Freetype 2.10.0

2019-04-17 Thread Sergey Bylokhov
+1 On 17/04/2019 06:15, Erik Joelsson wrote: Looks good! /Erik On 2019-04-16 16:40, Philip Race wrote: freetype 2.10 has been released and this fix upgrades the JDK's internal copy from the previous latest of 2.9.1 Bug : https://bugs.openjdk.java.net/browse/JDK-8222362 Webrev : http://cr.ope

Re: Build with VS 2019

2019-04-17 Thread Yasumasa Suenaga
Hi Erik, Anthony, I could not find JDK-8221988. Thank you Anthony! I want to know details of it - Aleksei start to create a patch or not. (I could not login JBS due to unexpected error. So I could not know email address of him.) My patch works fine to create fastdebug and production VM. If I s

RE: Build with VS 2019

2019-04-17 Thread Anthony Vanelverdinghe
Hi Yasumasa There is already an issue [1] for this, which is in progress. [1] https://bugs.openjdk.java.net/browse/JDK-8221988 Kind regards, Anthony From: Yasumasa Suenaga Sent: Wednesday, 17 April 2019 16:19 To: [email protected]

Re: Build with VS 2019

2019-04-17 Thread Erik Joelsson
Hello Yasumasa, If that was all it took, we are certainly lucky. I would be happy to accept the patch. I think it would be better to put 2019 as the second item in the list of valid versions as it's most likely preferable to all the older versions currently listed after 2017. /Erik On 201

Re: Add a suggestion for non-English locale of Linux in the test doc

2019-04-17 Thread Jing Tian
Yes! Thank you for your sponsor Erik! Jing Tian 在 2019/4/17 21:16, Erik Joelsson 写道: Looks good! Do you need a sponsor? /Erik On 2019-04-16 18:29, Jing Tian wrote: Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/ 在 2019/4/17 9:26, Jing Tian 写道: Sorry, because of my carelessnes

Build with VS 2019

2019-04-17 Thread Yasumasa Suenaga
Hi all, I tried to build jdk/jdk on WSL with VS 2019. Someone work for VS 2019? If not, I want to file it to JBS and contribute patch as below. It works fine on my environment. -- diff -r 4224f26b2e7f make/autoconf/toolchain_windows.m4 --- a/make/autoconf/toolchain_windows.m4

Re: Add a suggestion for non-English locale of Linux in the test doc

2019-04-17 Thread Erik Joelsson
Looks good! Do you need a sponsor? /Erik On 2019-04-16 18:29, Jing Tian wrote: Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/ 在 2019/4/17 9:26, Jing Tian 写道: Sorry, because of my carelessness, I have caused so much trouble. This is the updated version. Please review! Thank you.

Re: RFR: 8222362: Upgrade to Freetype 2.10.0

2019-04-17 Thread Erik Joelsson
Looks good! /Erik On 2019-04-16 16:40, Philip Race wrote: freetype 2.10 has been released and this fix upgrades the JDK's internal copy from the previous latest of 2.9.1 Bug : https://bugs.openjdk.java.net/browse/JDK-8222362 Webrev : http://cr.openjdk.java.net/~prr/8222362/ Built on all platfo

RE: RFR(XS): 8222627: Remove sneaky token 'Name' in jdk-version.m4

2019-04-17 Thread Langer, Christoph
Thanks Volker. I see you are member of the build group… so I had a good feeling when I pushed this 😊 http://hg.openjdk.java.net/jdk/jdk/rev/3b2101f56cdd From: Volker Simonis Sent: Mittwoch, 17. April 2019 07:54 To: Langer, Christoph Cc: [email protected] Subject: Re: RFR(XS): 8222627