Re: RFR(S) [13] : 8226910 : make it possible to use jtreg's -match via run-test framework

2019-07-16 Thread Igor Ignatyev
can I get a review for this patch? http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html Thanks, -- Igor > On Jul 6, 2019, at 11:50 AM, Igor Ignatyev wrote: > > Hi David, > >> On Jul 6, 2019, at 1:58 AM,

Re: [Ping?] RFR: 8227397: Add --with-extra-asflags configure option

2019-07-16 Thread Hohensee, Paul
Looks good. Paul On 7/16/19, 2:17 AM, "Severin Gehwolf" wrote: Hi Paul, Thanks for the review! On Mon, 2019-07-15 at 18:02 +, Hohensee, Paul wrote: > In CompileJvm.gmk, I'd replace > > -ASFLAGS := $(JVM_ASFLAGS), \ > +ASFLAGS :=

build.log: Output from failing command(s) repeated here - do not miss the hs_error file in case of crashes

2019-07-16 Thread Baesken, Matthias
Hello, In case of JVM crashes in the build (yes they happen in development  ) , we print some info about the crash at the end of the build log file In the Output from failing command(s) repeated here … section . This looks like the following (from a recent crash on AIX ) : ===

Re: [Ping?] RFR: 8227397: Add --with-extra-asflags configure option

2019-07-16 Thread Severin Gehwolf
Hi Paul, Thanks for the review! On Mon, 2019-07-15 at 18:02 +, Hohensee, Paul wrote: > In CompileJvm.gmk, I'd replace > > -ASFLAGS := $(JVM_ASFLAGS), \ > +ASFLAGS := $(JVM_ASFLAGS) $(EXTRA_ASFLAGS), \ > > with adding EXTRA_ASFLAGS to JVM_ASFLAGS right after where JVM_LDFLAGS is >