Re: RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle

2019-10-10 Thread David Holmes
Hi Erik, On 11/10/2019 4:27 am, Erik Joelsson wrote: Updating defaults in devkit creator makefiles. Also remembering to update building.md this time. Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 Seems okay. I'm somewhat

Re: RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle

2019-10-10 Thread Kim Barrett
> On Oct 10, 2019, at 2:27 PM, Erik Joelsson wrote: > > Updating defaults in devkit creator makefiles. Also remembering to update > building.md this time. > > Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 > > /Erik doc/

RFR: JDK-8232134: Change to Visual Studio 2017 15.9.16 for building on Windows at Oracle

2019-10-10 Thread Erik Joelsson
Removed some hard coded version values from the creator script which are now generated dynamically instead anyway. Also updating the building doc. Webrev: http://cr.openjdk.java.net/~erikj/8232134/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8232134 /Erik

RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle

2019-10-10 Thread Erik Joelsson
Updating defaults in devkit creator makefiles. Also remembering to update building.md this time. Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 /Erik

Re: VS install found through --with-tools-dir value is discarded

2019-10-10 Thread Erik Joelsson
Hello Jorn, On 2019-10-09 07:00, Jorn Vernee wrote: Hi, I was testing with different versions of Visual Studio to try and nail down the source of a deprecation warning. I was using the --with-tools-dir config option to quickly switch between installations but noticed the VS install that was

VS install found through --with-tools-dir value is discarded

2019-10-10 Thread Jorn Vernee
Hi, I was testing with different versions of Visual Studio to try and nail down the source of a deprecation warning. I was using the --with-tools-dir config option to quickly switch between installations but noticed the VS install that was being found through that method was being discarded,

Re: RFR: JDK-8226585: Improve javac messages for using a preview API

2019-10-10 Thread Maurizio Cimadamore
The javac changes looks good. I guess I would have preferred to move the check for preview from Check to Preview, and also create a tighter integration between PreviewFeature.Feature and javac's Feature enum, so that we could generate tight error messages, but I guess we can also do that as a

RE: [11u] RFR: 8212028: Use run-test makefile framework for testing in Oracle's Mach5

2019-10-10 Thread Langer, Christoph
Hi Severin, good catch, thank you. Adjusted webrev: http://cr.openjdk.java.net/~clanger/webrevs/8212028.11u-dev.1/ Best regards Christoph > -Original Message- > From: Severin Gehwolf > Sent: Donnerstag, 10. Oktober 2019 15:15 > To: Langer, Christoph ; jdk-updates- > [email protected]

Re: [11u] RFR: 8212028: Use run-test makefile framework for testing in Oracle's Mach5

2019-10-10 Thread Severin Gehwolf
Hi Christoph, On Thu, 2019-10-10 at 12:16 +, Langer, Christoph wrote: > Hi, > > please help reviewing this backport of a build infrastructure change to > jdk11u. > > One reason for doing this is parity with Oracle's 11.0.6 but the patch also > contains some test improvements which will hel

[11u] RFR: 8212028: Use run-test makefile framework for testing in Oracle's Mach5

2019-10-10 Thread Langer, Christoph
Hi, please help reviewing this backport of a build infrastructure change to jdk11u. One reason for doing this is parity with Oracle's 11.0.6 but the patch also contains some test improvements which will help stabilizing 11u testing. This mainly means increasing some test timeouts for a few test