Re: RFR: JDK-8239019: testmake fails with FATAL: VCS_TYPE is empty

2020-02-14 Thread Roger Riggs
Hi Erik, Agree it should run outside of any source code system. Idea supports that with the empty string. So even the warning can be removed. Thanks, Roger On 2/13/20 7:41 PM, Erik Joelsson wrote: Hello, The fix to make idea.sh support both git and mercurial had the unfortunate side effect

Re: RFR: 8237566: FindTests.gmk should only include existing TEST.ROOT files

2020-02-14 Thread Erik Helin
On 2/13/20 6:21 PM, Erik Joelsson wrote: Hello Erik, Looks good. Thanks for reviewing! On 2/13/20 6:21 PM, Erik Joelsson wrote: Style wise I try to put closing braces for logical blocks on a new line, aligned with the opening brace. I think that helps making the already quite convoluted mak

RE: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk images

2020-02-14 Thread Langer, Christoph
Hi Alan, > On 12/02/2020 22:16, Erik Joelsson wrote: > > Hello Christoph, > > > > This patch certainly looks better to me, though I agree it's a bit > > hackish to have to filter and rename the stripped.pdb files twice, > > once for jmods and again for bundles. I think I'm ok with it for now > > t

RE: RFR [jdk11]: 8234525: enable link-time section-gc for linux s390x to remove unused code

2020-02-14 Thread Baesken, Matthias
> > Hello , please review the downport of "8234525: enable link-time section- > gc for linux s390x to remove unused code" to jdk11 . > > > > My change from jdk/jdk did not apply directly and I had to adjust it > > slightly . > > > > > > > > > > Bug and jdk/jdk change : > > > > https://bu