Hello, Christoph.
Could you shed some light on the changes below:
-statusWindow->fgGC = XCreateGC(dpy, status, valuemask, );
+statusWindow->fgGC = create_gc(status, FALSE);
XSetForeground(dpy, statusWindow->fgGC, fg);
-statusWindow->bgGC = XCreateGC(dpy, status, valuemask, );
+
Hi Magnus, yes we do. We build (on Linux only currently)
"--with-jvm-variants=minimal,server" in our central builds to test that
minimal is still working and that is was not destroyed by recent changes .
Best Regards, Matthias
>
> Message: 2
> Date: Wed, 19 Feb 2020 13:26:35 +0100
>
Hi Erik,
thanks for the review. Seems like it’s looking good now in our CI. I’ll run it
through jdk-submit before pushing.
Best regards
Christoph
From: Erik Joelsson
Sent: Dienstag, 18. Februar 2020 18:09
To: Langer, Christoph ; Magnus Ihse Bursie
; 'build-dev@openjdk.java.net'
Cc:
Hello Magnus,
This is certainly a nice improvement. It looks good to me. I have some
comments on implementation details, but nothing serious enough to
require a new webrev.
Instead of using "echo $foo | sed 's/,/ /g'", since we know we run in
bash, could just use ${foo//,/ }.
On 2/19/20 1:26 PM, Magnus Ihse Bursie wrote:
> Are there still any realistic scenarios where anyone builds multiple variants
> of Hotspot in the
> same configuration?
>
> This was basically introduced for 32-bit builds, where both the server and
> the client variant of
> Hotspot were built. In
Are there still any realistic scenarios where anyone builds multiple variants
of Hotspot in the same configuration?
This was basically introduced for 32-bit builds, where both the server and the
client variant of Hotspot were built. In Oracle at least, we stopped building
multiple JVM variants
The JVM feature handling in configure needs a complete overhaul. The
current logic is hard to understand and to make changes to. The method
of enabling features with --with-jvm-features="feature list" means that
it is not possible to incrementally add features without throwing away
settings
