Hi,
Thanks, Volker for backporting this to JDK11 and thanks Andrew for reviewing it.
> On 30/12/2019 20:18, Volker Simonis wrote:
> > Hi,
> > I'd like to downport the support for Visual Studio Code project
> > creation to 11u. I think we will have to support 11u for quite some
> > years and it ma
On 2020-02-21 17:26, Erik Joelsson wrote:
Baring any component specific opinions on the suggested descriptions
of each feature, the patch looks good to me.
Ok, I'm sending a copy of this to hotspot-dev as well for the HS guys to
bikeshed about the descriptions. I'll get back in a few days when t
On 2020-02-21 17:03, John Paul Adrian Glaubitz wrote:
On 2/21/20 4:36 PM, Magnus Ihse Bursie wrote:
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed. :)
I updated the code but will not send out a new webrev.
Shouldn't "d
Looks good to me.
/Erik
On 2020-02-21 08:13, Magnus Ihse Bursie wrote:
Prior to JDK-8239450, it was possible to explicitly set the JVM
feature 'minimal', even when building variant server. The reason for
doing this was to get the code in JvmFeatures.gmk that sets
JVM_OPTIMIZATION := SIZE (exc
Hi,
I would suggest "Java Flight Recorder" instead of "JDK Flight Recorder"
Regards, Roger
On 2/21/20 10:36 AM, Magnus Ihse Bursie wrote:
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed. :)
I updated the code but will
Baring any component specific opinions on the suggested descriptions of
each feature, the patch looks good to me.
/Erik
On 2020-02-21 07:05, Magnus Ihse Bursie wrote:
The JVM feature rewrite was actually somewhat of a step backwards in
terms of presenting information for the user what differen
Looks good, nice restructure!
/Erik
On 2020-02-21 02:39, Magnus Ihse Bursie wrote:
The file basics.m4 in make/autoconf is mixing two different concerns:
1) Providing utility/helper functions to the rest of the autoconf files
2) Doing basic or initial setup that does not belong elsewhere.
It
Prior to JDK-8239450, it was possible to explicitly set the JVM feature
'minimal', even when building variant server. The reason for doing this
was to get the code in JvmFeatures.gmk that sets JVM_OPTIMIZATION :=
SIZE (except for a handful of files).
Since this functionality is important in it
On 2/21/20 4:36 PM, Magnus Ihse Bursie wrote:
> On 2020-02-21 16:15, Erik Gahlin wrote:
>> jfr should be JDK Flight Recorder.
> Thanks, I should have checked and not guessed. :)
>
> I updated the code but will not send out a new webrev.
Shouldn't "deprecated-ports" be parts of that list as well?
Looks good!
Thanks,
Volker
On Fri, Feb 21, 2020 at 2:50 PM Baesken, Matthias
wrote:
>
> Hello, please review this small downport of 8201349 .
> Reason is that we run into warnings as errors, when building jdk11 on Linux
> with gcc-7.X and with-zlib=bundled .
> This adds the compiler opti
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed. :)
I updated the code but will not send out a new webrev.
/Magnus
Erik
On 2020-02-21 16:05, Magnus Ihse Bursie wrote:
The JVM feature rewrite was actually somewhat of a
jfr should be JDK Flight Recorder.
Erik
On 2020-02-21 16:05, Magnus Ihse Bursie wrote:
The JVM feature rewrite was actually somewhat of a step backwards in
terms of presenting information for the user what different configure
arguments do.
I've compensated for this by making it far better! :
The JVM feature rewrite was actually somewhat of a step backwards in
terms of presenting information for the user what different configure
arguments do.
I've compensated for this by making it far better! :) Now we get a list
like this:
aot enable ahead of time compilati
Hello, please review this small downport of 8201349 .
Reason is that we run into warnings as errors, when building jdk11 on Linux
with gcc-7.X and with-zlib=bundled .
This adds the compiler options
-Wno-unused-function -Wno-implicit-fallthrough
To some compilations e.g. zlib-files ; the
Hi Matthias,
yes, I suggest to backport only JDK-8201349 with setting both statements to
DISABLED_WARNINGS_gcc := unused-function implicit-fallthrough as was the result
of the original fix for JDK-8201349.
Cheers
Christoph
From: Baesken, Matthias
Sent: Freitag, 21. Februar 2020 13:45
To: jdk-
Hello, we were running into build errors recently when using gcc-7 and
with-zlib=bundledin jdk11u-dev .
This combination worked nicely in jdk/jdk .
Reason is that in jdk11 we do not have :
8201349: build broken when configured with --with-zlib=bundled on gcc 7.3
https://hg.openjdk.ja
Hello, in the combination minimal+server , you can jlink smaller target
images using "minimal" because of the much smaller libjvm.so .
Just an example , target image size is sometimes important too .
Best regards, Matthias
> I am just wondering, what are the practical reasons for inclu
The file basics.m4 in make/autoconf is mixing two different concerns:
1) Providing utility/helper functions to the rest of the autoconf files
2) Doing basic or initial setup that does not belong elsewhere.
It should be split into two parts, so these different concerns are
clearly separated.
On 2020-02-21 09:50, Claes Redestad wrote:
Looks good to me, Magnus!
Thanks Claes. Fix pushed.
/Magnus
/Claes
On 2020-02-21 09:44, Magnus Ihse Bursie wrote:
Running gtest on Solaris broke with JDK-8239450, with a message like:
ld.so.1: gtestLauncher: fatal: libstlport.so.1: open failed: No
Looks good to me, Magnus!
/Claes
On 2020-02-21 09:44, Magnus Ihse Bursie wrote:
Running gtest on Solaris broke with JDK-8239450, with a message like:
ld.so.1: gtestLauncher: fatal: libstlport.so.1: open failed: No such
file or directory
This breaks our CI builds.
The problem is that the co
Running gtest on Solaris broke with JDK-8239450, with a message like:
ld.so.1: gtestLauncher: fatal: libstlport.so.1: open failed: No such
file or directory
This breaks our CI builds.
The problem is that the code checking for the presence of
libstlport.so.1 only tried to do so if gtest was e
21 matches
Mail list logo
