Re: 8241034: Fix a configuring error with "-Xmx2048M: command not found"(Internet mail)

2020-03-13 Thread 傅杰
Thanks Mikael for your review. Is it OK to be pushed? Best regards, Jie On 2020/3/14, 12:45 PM, "Mikael Vidstedt" wrote: Looks good. I also noticed this and filed JDK-8241035[1], but closed my issue as a duplicate of yours. Cheers, Mikael [1] https://bugs.openj

Re: RFR: 8241034: Fix a configuring error with "-Xmx2048M: command not found"

2020-03-13 Thread Mikael Vidstedt
Looks good. I also noticed this and filed JDK-8241035[1], but closed my issue as a duplicate of yours. Cheers, Mikael [1] https://bugs.openjdk.java.net/browse/JDK-8241035 > On Mar 13, 2020, at 5:13 PM, jiefu(傅杰) wrote: > > Hi all, > > JBS:https://bugs.openjdk.java.net/browse/JDK-824103

RFR: 8241034: Fix a configuring error with "-Xmx2048M: command not found"

2020-03-13 Thread 傅杰
Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8241034 Webrev: http://cr.openjdk.java.net/~jiefu/8241034/webrev.00/ A shell command error was observed during the jdk configuration. ``` jdk/build/.configure-support/generated-configure.sh: line 91505: -Xmx2048M: command not found `

Re: [RFR] [11u] JDK-8232748: "Build static versions of certain JDK libraries"

2020-03-13 Thread Andrew Hughes
On 13/03/2020 09:32, Langer, Christoph wrote: > Hi, > > I've regenerated this webrev as well: > http://cr.openjdk.java.net/~clanger/webrevs/8232748.11u/ (with JDK-8223678 > and JDK-8232572 applied) > > Patch content looks identical to the one already reviewed. > > I'd volunteer to push this

RE: [11u]: RFR 8235686: Add more custom hooks in Bundles.gmk

2020-03-13 Thread Langer, Christoph
Hi Goetz, thanks for the review. This is the rebased webrev on 11u-dev after JDK-8223678, JDK-8232572 and JDK-8232748: http://cr.openjdk.java.net/~clanger/webrevs/8235686.11u.1/. The changes are obviously still the same but the context differs. Will push it in order to 11u-dev (11.0.8). Cheer

RE: [RFR] [11u] JDK-8232748: "Build static versions of certain JDK libraries"

2020-03-13 Thread Langer, Christoph
Hi, I've regenerated this webrev as well: http://cr.openjdk.java.net/~clanger/webrevs/8232748.11u/ (with JDK-8223678 and JDK-8232572 applied) Patch content looks identical to the one already reviewed. I'd volunteer to push this in order with the other patches. Cheers Christoph > -Origin

RE: RFR [11u] 8232572: Add hooks for custom output dir in Bundles.gmk

2020-03-13 Thread Langer, Christoph
Hi, I regenerated the webrev: http://cr.openjdk.java.net/~clanger/webrevs/8232572.11u.1/ Still looks pretty much the same as before. Will push to jdk11u-dev after JDK-8223678. Cheers Christoph From: Langer, Christoph Sent: Montag, 9. März 2020 14:57 To: [email protected] Cc: bu