Beautiful!
Cheers,
Mikael
> On Mar 19, 2020, at 9:16 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-03-19 14:32, Erik Joelsson wrote:
>> Looks good.
>>
>> (and doh on how easy it was to simplify!)
>
> Yeah. I was so sure some m4 trickery was going to be needed. And all it took
> was a second
Hi Magnus,
please try not to use @SuppressWarnings("unchecked") on methods, but on local
variable instead to reduce the scope,
you can introduce a local variable for that.
In Bundle, your patch declare @SuppressWarnings("unchecked") on the method
while you already have a local variable with a @
On 2020-03-19 10:20, Magnus Ihse Bursie wrote:
Currently, it is not possible two make hotspot builds reproducible,
since the current date and time is always inserted using the special
macros __DATE__ and __TIME__. This patch makes it possible to override
these values from the build system, pavi
Looks good to me.
I love the WrapperGenerator using Vector and Hashtable!
/Erik
On 2020-03-19 09:53, Magnus Ihse Bursie wrote:
The buildtools (java tools needed to be run during the build) have
long been plagued by warnings, includuing deprecations and unchecked
warnings, which cannot be sile
Currently, it is not possible two make hotspot builds reproducible,
since the current date and time is always inserted using the special
macros __DATE__ and __TIME__. This patch makes it possible to override
these values from the build system, paving the way for making re-builds
of hotspot bit-
The buildtools (java tools needed to be run during the build) have long
been plagued by warnings, includuing deprecations and unchecked
warnings, which cannot be silenced during the build.
This patch fixes all buildtool warnings. Most of the warnings are fixed
properly, but a few have had thei
On 2020-03-19 14:32, Erik Joelsson wrote:
Looks good.
(and doh on how easy it was to simplify!)
Yeah. I was so sure some m4 trickery was going to be needed. And all it
took was a second look and some clever thinking. :-)
/Magnus
/Erik
On 2020-03-19 01:38, Magnus Ihse Bursie wrote:
The fu
Hi Alan,
The mismatches are due to the combination of generated Stub and old stub
source.
I'll clean it up a bit before pushing. As pretty static code it didn't
seem worth much investment.
Thanks, Roger
On 3/19/20 3:39 AM, Alan Bateman wrote:
On 18/03/2020 21:24, Roger Riggs wrote:
Hi,
Looks good.
(and doh on how easy it was to simplify!)
/Erik
On 2020-03-19 01:38, Magnus Ihse Bursie wrote:
The function UTIL_DEPRECATED_ARG_ENABLE has a wonky API, where the
user is supposed to repeat the argument twice in different ways. It is
possible to do without this strange mechanics.
The function UTIL_DEPRECATED_ARG_ENABLE has a wonky API, where the user
is supposed to repeat the argument twice in different ways. It is
possible to do without this strange mechanics.
Currently there are no uses of UTIL_DEPRECATED_ARG_ENABLE in open code.
However, functions like this is not r
On 18/03/2020 21:24, Roger Riggs wrote:
Hi,
Some small updates to the source files to minimize the changes to javadoc
of the _Stub classes.
All looks good but the updated ActivationGroup_Stub should probably get
a one-pass to eliminate the inconsistencies, e.g. the new version
imports some
On 2020-03-18 22:24, Roger Riggs wrote:
Hi,
Some small updates to the source files to minimize the changes to javadoc
of the _Stub classes.
And fixes to the points Magnus raises below.
http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/
Looks good! Thank you for getting this t
12 matches
Mail list logo
