Vladimir/Magnus/Erik,
Thanks for the reviews, change pushed.
Cheers,
Mikael
> On Apr 29, 2020, at 5:45 AM, Erik Joelsson wrote:
>
> Looks good.
>
> /Erik
>
> On 2020-04-28 21:12, Mikael Vidstedt wrote:
>> Please review this small change which disables JVMCI, Graal, and AOT when
>>
> On Apr 29, 2020, at 3:44 AM, Andrew Haley wrote:
>
> On 4/29/20 10:02 AM, Mikael Vidstedt wrote:
>>
>>> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote:
>>>
>>> On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
Jan,
What is your current recommended technique to use NetBeans to
build/edit/test OpenJDK for normal OpenJDK library developers?
After many versions of Netbeans, my current setup is to:
1. Do an external "exploded" build
2. Run Netbeans, open the src/java.base module project and any
On 29/04/2020 12:45, Magnus Ihse Bursie wrote:
Let's say we keep it in langtools (unless we can find a better home
for it). My question is: Are we talking only about build.properties
and build.xml? Or are there more files that these depend on, that I
had assumed belong to the IDE generation?
LGTM.
/Magnus
> 29 apr. 2020 kl. 17:23 skrev Erik Joelsson :
>
> Hello,
>
> My fix for JDK-8243510 was not enough to catch all potential exceptions
> needed. Here is a new attempt that casts a wider net.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8244051/webrev.01/
>
> Bug:
Hello,
My fix for JDK-8243510 was not enough to catch all potential exceptions
needed. Here is a new attempt that casts a wider net.
Webrev: http://cr.openjdk.java.net/~erikj/8244051/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8244051
/Erik
Thanks Erik and Magnus for your review.
I'll push it soon.
On 2020/4/29, 9:33 PM, "Magnus Ihse Bursie"
wrote:
If this works both when building normally and when building
bootcycle-images, I’m okay with this.
Are you a committer, or do you need someone to sponsor the patch?
If this works both when building normally and when building bootcycle-images,
I’m okay with this.
Are you a committer, or do you need someone to sponsor the patch?
/Magnus
> 29 apr. 2020 kl. 14:25 skrev jiefu(傅杰) :
>
> Thanks Magnus for your review and nice help.
> It seems that your patch
On 2020-04-29 05:25, jiefu(傅杰) wrote:
Thanks Magnus for your review and nice help.
It seems that your patch didn't fix the build failure when configure
--with-boot-jdk=jdk15.
I've made : http://cr.openjdk.java.net/~jiefu/8244097/webrev.01/ based on your
work.
Ah, you already discovered
On 2020-04-29 04:48, Magnus Ihse Bursie wrote:
On 2020-04-29 13:23, Magnus Ihse Bursie wrote:
On 2020-04-29 13:02, jiefu(傅杰) wrote:
Hi all,
May I get reviews for this fix?
JBS: https://bugs.openjdk.java.net/browse/JDK-8244097
Dang it! I thought I had tested bootcycle-images, but maybe that
> On 29 Apr 2020, at 11:36, Magnus Ihse Bursie
> wrote:
>
> ...
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8244093
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8244093-move-ide-support/webrev.01
The make/idea changes look ok to me.
-Chris.
Looks good to me.
/Erik
On 2020-04-29 03:47, Alan Bateman wrote:
On 29/04/2020 11:40, Magnus Ihse Bursie wrote:
:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
Looks good. It could be optimized to only read the module-info.class
once but will hardly be
Looks good.
/Erik
On 2020-04-28 21:12, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
building linux-aarch64 at Oracle, for now.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
webrev:
Thanks Magnus for your review and nice help.
It seems that your patch didn't fix the build failure when configure
--with-boot-jdk=jdk15.
I've made : http://cr.openjdk.java.net/~jiefu/8244097/webrev.01/ based on your
work.
Please review it and give me some advice.
Thanks.
Best regards,
Jie
On 2020-04-29 13:06, Jan Lahoda wrote:
I am not sure if anyone is still using make/jdk/netbeans. Apache
NetBeans does not (should not) need these config files, it supports
OpenJDK modules out of the box (with some tweaks/dependencies on
make/langtools/** to speed up langtools build).
It's by
On 2020-04-29 13:23, Magnus Ihse Bursie wrote:
On 2020-04-29 13:02, jiefu(傅杰) wrote:
Hi all,
May I get reviews for this fix?
JBS: https://bugs.openjdk.java.net/browse/JDK-8244097
Dang it! I thought I had tested bootcycle-images, but maybe that
wasn't the last iteration of my fix.
Webrev:
On 2020-04-29 13:36, Maurizio Cimadamore wrote:
On 29/04/2020 11:57, Magnus Ihse Bursie wrote:
So who/what is using the ant build? I thought it was just the IDEA
project that generated ant targets. Is it run explicitly using ant by
langtool developers? I know for sure it's not used when we
On 29/04/2020 11:57, Magnus Ihse Bursie wrote:
So who/what is using the ant build? I thought it was just the IDEA
project that generated ant targets. Is it run explicitly using ant by
langtool developers? I know for sure it's not used when we build the
product in our CI.
As Jan mentioned,
On 2020-04-29 13:02, jiefu(傅杰) wrote:
Hi all,
May I get reviews for this fix?
JBS: https://bugs.openjdk.java.net/browse/JDK-8244097
Dang it! I thought I had tested bootcycle-images, but maybe that wasn't
the last iteration of my fix.
Webrev:
I am not sure if anyone is still using make/jdk/netbeans. Apache
NetBeans does not (should not) need these config files, it supports
OpenJDK modules out of the box (with some tweaks/dependencies on
make/langtools/** to speed up langtools build).
As Maurizio, there may be some need to move the
Hi all,
May I get reviews for this fix?
JBS: https://bugs.openjdk.java.net/browse/JDK-8244097
Webrev: http://cr.openjdk.java.net/~jiefu/8244097/webrev.00/
Thanks a lot.
Best regards,
Jie
On 2020-04-29 12:47, Maurizio Cimadamore wrote:
Didn't review in detail, but some pieces seems suspicious - e.g.
moving "/make/langtools/build.properties" to
"///make/ide/idea/langtools/build.properties//
Note that langtools's build.properties is used by the langtools ANT
build which is
On 2020-04-29 12:47, Alan Bateman wrote:
On 29/04/2020 11:40, Magnus Ihse Bursie wrote:
:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
Looks good.
Thanks.
It could be optimized to only read the module-info.class once but will
hardly be noticeable I
Didn't review in detail, but some pieces seems suspicious - e.g.
moving "/make/langtools/build.properties" to
"///make/ide/idea/langtools/build.properties//
Note that langtools's build.properties is used by the langtools ANT
build which is independent from make - and also mostly independent
On 29/04/2020 11:40, Magnus Ihse Bursie wrote:
:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
Looks good. It could be optimized to only read the module-info.class
once but will hardly be noticeable I suspect.
-Alan
On 4/29/20 10:02 AM, Mikael Vidstedt wrote:
>
>> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote:
>>
>> On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
>>> Please review this small change which disables JVMCI, Graal, and AOT when
>>> building linux-aarch64 at Oracle, for now.
>>>
>>> JBS:
On 2020-04-29 12:31, Alan Bateman wrote:
On 29/04/2020 10:27, Magnus Ihse Bursie wrote:
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run.
This happens whenever at least one module-info.class file has been
The IDE support in OpenJDK unfortunately leaves a lot to be desired.
There have been a garden variety of attempt to support a specific IDE
for a specific part of the code base, cluttered all over the code base.
This patch is a first attempt go get one ring, eh..., structure, to rule
them all.
On 29/04/2020 10:27, Magnus Ihse Bursie wrote:
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run. This
happens whenever at least one module-info.class file has been updated.
The end result of this is that
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run. This
happens whenever at least one module-info.class file has been updated.
The end result of this is that if you recompile a single module, *all*
modules
Ok, thanks for the clarification. I wasn’t sure if external parties had managed
to set up a jib server but it sounds like that’s not so easy in practice.
-Doug
> On 29 Apr 2020, at 11:02, Magnus Ihse Bursie
> wrote:
>
> On 2020-04-29 10:45, Doug Simon wrote:
>> If I understand correctly,
> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote:
>
> On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
>> Please review this small change which disables JVMCI, Graal, and AOT when
>> building linux-aarch64 at Oracle, for now.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
>> webrev:
On 2020-04-29 10:45, Doug Simon wrote:
If I understand correctly, this disables building jvmci/graal/aot in *any*
linux-aarch64 jib based build, not just those done at Oracle. Wouldn’t this be
better done on the jib command line?
While this is technically correct, the jib tool is only used at
JIB is an Oracle (internal) tool, meaning the jib-profiles.js configuration
file is only relevant at Oracle, so this really only affects builds done at
Oracle. Does that address your concern?
Cheers,
Mikael
> On Apr 29, 2020, at 1:45 AM, Doug Simon wrote:
>
> If I understand correctly,
If I understand correctly, this disables building jvmci/graal/aot in *any*
linux-aarch64 jib based build, not just those done at Oracle. Wouldn’t this be
better done on the jib command line?
-Doug
> On 29 Apr 2020, at 06:12, Mikael Vidstedt wrote:
>
>
> Please review this small change which
On 2020-04-29 06:12, Mikael Vidstedt wrote:
Please review this small change which disables JVMCI, Graal, and AOT when
building linux-aarch64 at Oracle, for now.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
webrev:
On 4/29/20 5:12 AM, Mikael Vidstedt wrote:
> Please review this small change which disables JVMCI, Graal, and AOT when
> building linux-aarch64 at Oracle, for now.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244061
> webrev:
>
On 2020-04-29 00:35, Erik Joelsson wrote:
Hello Magnus,
Nice job! Looks good.
Is the disabling of the warning "options" actually needed in that many
places or did you just add it everywhere where GENERATE_OLDBYTECODE
was used?
It is really needed -- I started out without it, and added it
38 matches
Mail list logo
