JDK 16 RFR of JDK-8248605: Update --release 15 symbol information for JDK 15 build 31

2020-07-11 Thread Joe Darcy
Hello, Please review the updates of the JDK 16 symbol information for JDK 15 b31:     JDK-8248605: Update --release 15 symbol information for JDK 15 build 31     http://cr.openjdk.java.net/~darcy/8248605.0/ It is not actually clear to me why the script determined an update was needed. Jan,

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-11 Thread Claes Redestad
Hi, I think the idea of generating two distinct jars is workable, but I really don't like the prospect of routinely having to move micros around as the features they test promote from preview. Would a manually managed list of which tests use --enable-preview work for you? Not ideal either, but

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-11 Thread Peter Levart
On 7/11/20 9:31 AM, Peter Levart wrote: - compile the two sets of benchmarks separately with separate output directories and create separate benchmarks.jar files for them Here's my attempt at a patch for separate benchmarks.jar files. The minor complication, as I found out, was what to do

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-11 Thread Peter Levart
On 7/7/20 7:51 PM, Roger Riggs wrote: Hi, I have found it very useful to be able to run benchmarks against multiple versions of the JDK.  Build the benchmark jar once and to compare results. If all of the classes are built with --enable-preview, none of them will run against older JDKs. So