Hi,
Thanks a lot for the reviews! I think I have addressed the review
comments from Andrew, Vladimir and Erik. This is the new webrev:
Full:
http://cr.openjdk.java.net/~njian/8231441/webrev.05/
Incremental:
http://cr.openjdk.java.net/~njian/8231441/webrev.05-vs-04/
Tests:
Tested with jtreg h
Great to see this - thank you for all the great work you’re putting into it!
The changes are in line with what I’m expecting given that I’ve looked at them
before, so looks good to me! That said, I’ve looked at this so many times now -
and after all even authored some of the original changes -
On 2020-09-01 13:41, Aleksei Voitylov wrote:
Hi,
JEP 386 is now Candidate [1] and as we resolved all outstanding issues
within the Portola project I'd like to ask for comments from HotSpot,
Core Libs (changes in libjli/java_md.c), and Build groups before moving
the JEP to Proposed to Target:
ht
Build changes look ok.
/Erik
On 2020-09-01 04:41, Aleksei Voitylov wrote:
Hi,
JEP 386 is now Candidate [1] and as we resolved all outstanding issues
within the Portola project I'd like to ask for comments from HotSpot,
Core Libs (changes in libjli/java_md.c), and Build groups before moving
the
Hi,
JEP 386 is now Candidate [1] and as we resolved all outstanding issues
within the Portola project I'd like to ask for comments from HotSpot,
Core Libs (changes in libjli/java_md.c), and Build groups before moving
the JEP to Proposed to Target:
http://cr.openjdk.java.net/~avoitylov/webrev.8247
On 31/08/2020 12:44, Severin Gehwolf wrote:
> Sorry, wrong webrev. Now corrected.
>
> On Mon, 2020-08-31 at 10:02 +0200, Severin Gehwolf wrote:
>> Hi,
>>
>> Could I get a reivew of this 8u specific bug please? When configured
>> --with-native-debug-symbols=external,zipped the resulting external
>>