On Thu, 5 Nov 2020 06:39:02 GMT, Aleksey Shipilev wrote:
>> Current Zero interpreter has the optimization for JVMTI support. It
>> recognizes that JVMTI is disabled most of the time, and that JVMTI checks in
>> the interpreter code slows it down considerably. (I measured it myself when
>>
On Thu, 5 Nov 2020 06:39:02 GMT, Aleksey Shipilev wrote:
>> Current Zero interpreter has the optimization for JVMTI support. It
>> recognizes that JVMTI is disabled most of the time, and that JVMTI checks in
>> the interpreter code slows it down considerably. (I measured it myself for
>> this
> Current Zero interpreter has the optimization for JVMTI support. It
> recognizes that JVMTI is disabled most of the time, and that JVMTI checks in
> the interpreter code slows it down considerably. (I measured it myself for
> this patch, it gives about 20% hit in build times).
>
> Current
On Wed, 4 Nov 2020 12:21:12 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
Hello
Andrew Haley resigned as JDK 7u project lead [1].
Andrew Brygin offered to take over leadership of JDK 7u. [2] I have no
other nominations.
Under the bylaws for Project Roles [3], a new Project Lead may be
nominated by the Group Leads of the Project's sponsoring groups.
The Build
> This introduces support for a new `@spec` tag that can be used as either an
> inline tag or as a block tag. It is used to identify references to external
> specifications, in such a way that the references can be collected together
> on a new summary page, called "Other Specifications",
On Tue, 13 Oct 2020 12:51:54 GMT, Andy Herrick wrote:
> JDK-8252870: Finalize (remove "incubator" from) jpackage
This pull request has now been integrated.
Changeset: 26e7ef78
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/26e7ef78
Stats: 1733 lines in 259
On Mon, 2 Nov 2020 20:21:44 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview
> JDK-8252870: Finalize (remove "incubator" from) jpackage
Andy Herrick has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Merge branch 'master' into JDK-8252870
- Merge branch 'master' into JDK-8252870
- Merge
On Mon, 2 Nov 2020 18:36:32 GMT, Jorn Vernee wrote:
> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c
>
> This removes the reported warning.
>
> Note that the _LP64 macro was not being propagated to the benchmark native
> libraries on Windows. The comment says that this is due to
On Wed, 4 Nov 2020 10:13:59 GMT, Kim Barrett wrote:
>> Hello!
>>
>> As an IDE developer, I'm thinking about IDE inspection that may suggest the
>> new method. My idea is to suggest replacing every `ref.get() == obj` with
>> `ref.refersTo(obj)`. Is this a good idea or there are cases when
Current Zero interpreter has the optimization for JVMTI support. It recognizes
that JVMTI is disabled most of the time, and that JVMTI checks in the
interpreter code slows it down considerably. (I measured it myself for this
patch, it gives about 20% hit in build times).
Current optimization
On Tue, 3 Nov 2020 22:25:08 GMT, Magnus Ihse Bursie wrote:
> With clang 10.0, the compiler now detects a new class of warnings. The
> `misleading-indentation` warning has previously been disabled on gcc for
> hotspot and libfdlibm. Now we need to disable it for clang as well.
This pull
On Thu, 22 Oct 2020 02:40:44 GMT, Jonathan Gibbons wrote:
> This introduces support for a new `@spec` tag that can be used as either an
> inline tag or as a block tag. It is used to identify references to external
> specifications, in such a way that the references can be collected together
>
On Wed, 4 Nov 2020 12:59:24 GMT, Aleksey Shipilev wrote:
> Current submit workflow omits `hs_err*.log` and `replay*.log` files, because
> zip matches the paths, and so only the hs_errs/replays in the current dir are
> picked up (and there are none). It should be preceded with `*` to match
On Wed, 4 Nov 2020 14:38:53 GMT, Erik Joelsson wrote:
>> Thank you, @erikj79. Trivial? (I would like to get is soon, in order to
>> capture more hs_errs for current failures)
>
> I'm fine with a quick integration of this.
Thank you.
-
PR:
On Wed, 4 Nov 2020 13:43:58 GMT, Aleksey Shipilev wrote:
>> Marked as reviewed by erikj (Reviewer).
>
> Thank you, @erikj79. Trivial? (I would like to get is soon, in order to
> capture more hs_errs for current failures)
I'm fine with a quick integration of this.
-
PR:
On Wed, 4 Nov 2020 13:40:49 GMT, Erik Joelsson wrote:
>> Current submit workflow omits `hs_err*.log` and `replay*.log` files, because
>> zip matches the paths, and so only the hs_errs/replays in the current dir
>> are picked up (and there are none). It should be preceded with `*` to match
>>
On Wed, 4 Nov 2020 12:59:24 GMT, Aleksey Shipilev wrote:
> Current submit workflow omits `hs_err*.log` and `replay*.log` files, because
> zip matches the paths, and so only the hs_errs/replays in the current dir are
> picked up (and there are none). It should be preceded with `*` to match
On Tue, 3 Nov 2020 22:25:08 GMT, Magnus Ihse Bursie wrote:
> With clang 10.0, the compiler now detects a new class of warnings. The
> `misleading-indentation` warning has previously been disabled on gcc for
> hotspot and libfdlibm. Now we need to disable it for clang as well.
Marked as
Current submit workflow omits `hs_err*.log` and `replay*.log` files, because
zip matches the paths, and so only the hs_errs/replays in the current dir are
picked up (and there are none). It should be preceded with `*` to match files
in subdirs. Incidentally, this is why `*.jtr` match works.
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table
On Wed, 4 Nov 2020 05:37:00 GMT, Serguei Spitsyn wrote:
>> Hi Coleen,
>>
>> Wow, there are a lot of simplifications and code removal with this fix!
>> It looks great in general, just some nits below.
>> I also wanted to suggest renaming the 'set_needs_processing' to
>> 'set_needs_rehashing'.
On Mon, 2 Nov 2020 19:59:10 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Mon, 2 Nov 2020 19:41:08 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Mon, 2 Nov 2020 19:37:39 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Mon, 2 Nov 2020 18:39:59 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Wed, 4 Nov 2020 09:31:13 GMT, Tagir F. Valeev wrote:
> Hello!
>
> As an IDE developer, I'm thinking about IDE inspection that may suggest the
> new method. My idea is to suggest replacing every `ref.get() == obj` with
> `ref.refersTo(obj)`. Is this a good idea or there are cases when
On Tue, 3 Nov 2020 20:37:07 GMT, Jorn Vernee wrote:
>> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c
>>
>> This removes the reported warning.
>>
>> Note that the _LP64 macro was not being propagated to the benchmark native
>> libraries on Windows. The comment says that this is
On Tue, 3 Nov 2020 21:40:39 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 127:
>>
>>> 125: // The table cleaning, posting and rehashing can race for
>>> 126: // concurrent GCs. So fix it here once we have a lock or are
>>> 127: // at a safepoint.
>>
>> I
On Wed, 4 Nov 2020 07:52:12 GMT, Kim Barrett wrote:
>> So the design is that when the oops have new addresses, we set a flag in the
>> table to rehash it. Not sure why this is wrong and why wouldn't it work for
>> shenandoah? @zhengyu123 ? When we call WeakHandle.peek()/resolve() after
>>
On Wed, 4 Nov 2020 00:08:10 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
On Wed, 4 Nov 2020 09:31:13 GMT, Tagir F. Valeev wrote:
>> The API looks good, thanks for getting this in.
>
> Hello!
>
> As an IDE developer, I'm thinking about IDE inspection that may suggest the
> new method. My idea is to suggest replacing every `ref.get() == obj` with
>
On Tue, 3 Nov 2020 20:12:35 GMT, Magnus Ihse Bursie wrote:
>> Ok, will do. (FWIW, you can expand the context of the diff with the arrow
>> buttons on the left side of the view. Above or below the line numbers)
>
> (Yes, I know. I just didn't think that doing so would reveal anything about
>
On Wed, 4 Nov 2020 07:41:39 GMT, Kim Barrett wrote:
>>>Though it might be possible to go even further and eliminate
>>>WeakProcessorPhases as a thing separate from OopStorageSet.
>>
>> This makes sense. Can we file another RFE for this? I was sort of surprised
>> by how much code was
On Tue, 3 Nov 2020 21:31:35 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 2979:
>>
>>> 2977:
>>> 2978: // Concurrent GC needs to call this in relocation pause, so after the
>>> objects are moved
>>> 2979: // and have their new addresses, the table can be
On Tue, 3 Nov 2020 23:38:08 GMT, Coleen Phillimore wrote:
>> Ok, so I'm not sure what to do with this:
>>
>> enum Phase {
>> // Serial phase.
>> JVMTI_ONLY(jvmti)
>> // Additional implicit phase values follow for oopstorages.
>> `};`
>>
>> I've removed the only thing in this
On Wed, 28 Oct 2020 15:56:48 GMT, Alan Bateman wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve wording in refersTo javadoc
>
> The API looks good, thanks for getting this in.
Hello!
As an IDE developer,
On Tue, 3 Nov 2020 20:37:07 GMT, Jorn Vernee wrote:
>> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c
>>
>> This removes the reported warning.
>>
>> Note that the _LP64 macro was not being propagated to the benchmark native
>> libraries on Windows. The comment says that this is
On Sun, 4 Oct 2020 03:59:59 GMT, Kim Barrett wrote:
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
>
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-April/029203.html
>
42 matches
Mail list logo
