Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-17 Thread David Holmes
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote: > Enable the security manager in rmiregistry's launcher arguments. Hi Stuart, I think specifying "allow" would be the behaviour preserving change here. That avoids any risk that enabling the SM earlier changes some behaviour during VM

[jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-17 Thread Stuart Marks
Enable the security manager in rmiregistry's launcher arguments. - Commit messages: - Add security manager property to rmiregistry launcher arguments. Changes: https://git.openjdk.java.net/jdk18/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18=45=00 Issue:

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Andrew Leonard
On Fri, 17 Dec 2021 16:29:21 GMT, Magnus Ihse Bursie wrote: >> Oh, that's ... interesting. (I'm pretty sure I wrote that code myself :)) >> >> I still think it would be good to keep the new code close to the old. If we >> set SOURCE_DATE to "updated", I think that should reflect in >>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Andrew Leonard
On Fri, 17 Dec 2021 17:53:12 GMT, Erik Joelsson wrote: >> But I think the code in InitSupport will be executed always; Init.gmk is our >> "bootstrapper" / "trampoline" which wraps all calls to make (and >> InitSupport.gmk contains gory implementation details of Init.gmk). > > SOURCE_DATE_EPOCH

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Andrew Leonard
On Fri, 17 Dec 2021 17:54:46 GMT, Erik Joelsson wrote: >> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard > >

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Erik Joelsson
On Fri, 17 Dec 2021 16:29:21 GMT, Magnus Ihse Bursie wrote: >> Oh, that's ... interesting. (I'm pretty sure I wrote that code myself :)) >> >> I still think it would be good to keep the new code close to the old. If we >> set SOURCE_DATE to "updated", I think that should reflect in >>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Erik Joelsson
On Fri, 17 Dec 2021 09:18:03 GMT, Andrew Leonard wrote: > If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Magnus Ihse Bursie
On Fri, 17 Dec 2021 16:27:39 GMT, Magnus Ihse Bursie wrote: >> @magicus I looked at that, but the problem is SOURCE_DATE_EPOCH is set in >> InitSupport.gmk depending on whether SOURCE_DATE=="updated" : >>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Magnus Ihse Bursie
On Fri, 17 Dec 2021 13:51:28 GMT, Andrew Leonard wrote: >> make/common/MakeBase.gmk line 145: >> >>> 143: # If reproducible builds are enabled then set SOURCE_DATE_ISO_8601 >>> string variable >>> 144: ifeq ($(ENABLE_REPRODUCIBLE_BUILD), true) >>> 145: SOURCE_DATE_ISO_8601 := $(shell $(DATE)

Integrated: 8278954: Using clang together with devkit on linux doesn't work for building

2021-12-17 Thread Gilles Duboscq
On Fri, 17 Dec 2021 11:27:43 GMT, Gilles Duboscq wrote: > When running `configure`, using `--with-devkit=` to point to a typical linux > devkit along with `--with-toolchain-path=` and `--with-toolchain-type=clang` > to point to a clang-based toolchain results in: > > configure:75064: checking

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Andrew Leonard
On Fri, 17 Dec 2021 11:18:10 GMT, Magnus Ihse Bursie wrote: >> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard > >

Re: RFR: 8278954: Using clang together with devkit on linux doesn't work for building

2021-12-17 Thread Gilles Duboscq
On Fri, 17 Dec 2021 13:35:04 GMT, Erik Joelsson wrote: >> When running `configure`, using `--with-devkit=` to point to a typical linux >> devkit along with `--with-toolchain-path=` and `--with-toolchain-type=clang` >> to point to a clang-based toolchain results in: >> >> configure:75064:

Re: RFR: 8278954: Using clang together with devkit on linux doesn't work for building

2021-12-17 Thread Erik Joelsson
On Fri, 17 Dec 2021 11:27:43 GMT, Gilles Duboscq wrote: > When running `configure`, using `--with-devkit=` to point to a typical linux > devkit along with `--with-toolchain-path=` and `--with-toolchain-type=clang` > to point to a clang-based toolchain results in: > > configure:75064: checking

RFR: 8278954: Using clang together with devkit on linux doesn't work for building

2021-12-17 Thread Gilles Duboscq
When running `configure`, using `--with-devkit=` to point to a typical linux devkit along with `--with-toolchain-path=` and `--with-toolchain-type=clang` to point to a clang-based toolchain results in: configure:75064: checking whether the C compiler works configure:75086: /dl/tools/clang -m64

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Magnus Ihse Bursie
On Fri, 17 Dec 2021 09:18:03 GMT, Andrew Leonard wrote: > If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard

RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date

2021-12-17 Thread Andrew Leonard
If "reproducible build" is enabled, then utilize the new --date option in the building of jar's and jmods. Validating the boot jdk supports --date for the building of the jars. Signed-off-by: Andrew Leonard - Commit messages: - 8278766: Enable OpenJDK build support for