Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-26 Thread David Holmes
On 27/01/2022 10:19 am, Tyler Steele wrote: On Tue, 25 Jan 2022 06:10:19 GMT, Thomas Stuefe wrote: Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into JDK-8203290 -

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-26 Thread Tyler Steele
On Tue, 25 Jan 2022 06:10:19 GMT, Thomas Stuefe wrote: >> Tyler Steele has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JDK-8203290 >> - Implements JFR on AIX >> >>-

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Daniel D . Daugherty
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Yumin Qi
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Integrated: JDK-8279636: Update JCov version to 3.0.12

2022-01-26 Thread Alexandre Iline
On Wed, 26 Jan 2022 00:08:36 GMT, Alexandre Iline wrote: > JDK-8279636: Update JCov version to 3.0.12 This pull request has now been integrated. Changeset: d2a50a64 Author:Alexandre Iline URL: https://git.openjdk.java.net/jdk/commit/d2a50a64920d22bbbd19ac7fa8681ff177799faf Stats:

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-26 Thread Erik Joelsson
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-26 Thread Zhengyu Gu
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000],

Re: RFR: JDK-8279636: Update JCov version to 3.0.12

2022-01-26 Thread Erik Joelsson
On Wed, 26 Jan 2022 00:08:36 GMT, Alexandre Iline wrote: > JDK-8279636: Update JCov version to 3.0.12 Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7218

Re: RFR: JDK-8280583: Always build NMT [v3]

2022-01-26 Thread Zhengyu Gu
On Wed, 26 Jan 2022 08:36:44 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >>

Re: RFR: JDK-8280583: Always build NMT [v3]

2022-01-26 Thread Magnus Ihse Bursie
On Wed, 26 Jan 2022 08:36:44 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >>

Re: RFR: JDK-8280583: Always build NMT [v3]

2022-01-26 Thread Thomas Stuefe
On Wed, 26 Jan 2022 08:42:46 GMT, Aleksey Shipilev wrote: > This looks fine to me. Thanks, Aleksey! - PR: https://git.openjdk.java.net/jdk/pull/7213

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Alan Bateman
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from

Re: RFR: JDK-8280583: Always build NMT [v3]

2022-01-26 Thread Aleksey Shipilev
On Wed, 26 Jan 2022 08:36:44 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >>

Re: RFR: JDK-8280583: Always build NMT [v2]

2022-01-26 Thread Thomas Stuefe
On Wed, 26 Jan 2022 08:26:27 GMT, Aleksey Shipilev wrote: > There is some major weirdness in this PR: it includes a lot of unrelated > changes. Consider rebasing to current master and force-pushing? Done. I wondered about that, I did merge master - normally, this shows up as a single merge

Re: RFR: JDK-8280583: Always build NMT [v3]

2022-01-26 Thread Thomas Stuefe
> After discussing this on hotspot-runtime-dev [1], the general opinion seems > to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT > unconditional. This affects minimal builds only. As pointed out in the mail > thread, the overhead is very small and it would get rid of one

Re: RFR: JDK-8280583: Always build NMT [v2]

2022-01-26 Thread Aleksey Shipilev
On Wed, 26 Jan 2022 06:23:41 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >>