Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v16]

2022-01-28 Thread Thomas Stuefe
On Fri, 28 Jan 2022 15:07:56 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v16]

2022-01-28 Thread Thomas Stuefe
On Fri, 28 Jan 2022 15:07:56 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v16]

2022-01-28 Thread Tyler Steele
> Just in time for the holidays I have completed an implementation of the JFR > functionality for AIX. As a side note, this is my first submission to OpenJDK > 👋 > > ### Implementation notes and alternatives considered > > After modifying the build system to allow the --enable-jvm-feature-jfr t

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-28 Thread Tyler Steele
On Fri, 28 Jan 2022 10:40:51 GMT, Magnus Ihse Bursie wrote: >> Tyler Steele has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JDK-8203290 >> - Implements JFR on AIX >> >>- Im

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Zhengyu Gu
On Fri, 28 Jan 2022 09:38:14 GMT, Christian Hagedorn wrote: > > > That's interesting. Is this implementation still around somewhere? I'm > > > glad that some of the mentioned things are not a problem anymore. > > > > > > Not I know. IIRC, it was based on DWARF 2. > > Okay, thanks. > > > > >

Integrated: 8280863: Update build README to reflect that MSYS2 is supported

2022-01-28 Thread TheShermanTanker
On Thu, 27 Jan 2022 08:49:08 GMT, TheShermanTanker wrote: > Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) > was merged in 16, MSYS2 became capable of building a functional JDK on > Windows. This PR updates some outdated documentation in building.html and > buildin

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported [v2]

2022-01-28 Thread TheShermanTanker
On Fri, 28 Jan 2022 09:12:06 GMT, Magnus Ihse Bursie wrote: >> TheShermanTanker has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Fri, 28 Jan 2022 09:58:26 GMT, Thomas Stuefe wrote: > > > Two general remarks. One concern I have is that the new functionality > > > should be super stable, since nothing is more annoying than to crash > > > during stack dumping in hs-err file; I much rather have a call stack > > > without

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-28 Thread Magnus Ihse Bursie
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Thomas Stuefe
On Fri, 28 Jan 2022 09:19:04 GMT, Christian Hagedorn wrote: > > Two general remarks. One concern I have is that the new functionality > > should be super stable, since nothing is more annoying than to crash during > > stack dumping in hs-err file; I much rather have a call stack without bells

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Fri, 28 Jan 2022 02:26:21 GMT, Yasumasa Suenaga wrote: > I think this feature is very useful, thanks Christian! Thanks Yasumasa! > SA already has similar feature to gather call stacks with DWARF, so it would > be nice to share DWARF parser between SA and HotSpot. I agree, that would be a g

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported [v3]

2022-01-28 Thread Magnus Ihse Bursie
On Fri, 28 Jan 2022 09:28:44 GMT, TheShermanTanker wrote: >> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) >> was merged in 16, MSYS2 became capable of building a functional JDK on >> Windows. This PR updates some outdated documentation in building.html and >> bui

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Thu, 27 Jan 2022 13:43:00 GMT, Zhengyu Gu wrote: > > That's interesting. Is this implementation still around somewhere? I'm glad > > that some of the mentioned things are not a problem anymore. > > Not I know. IIRC, it was based on DWARF 2. Okay, thanks. > > > > * Different compiler (and

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported [v3]

2022-01-28 Thread TheShermanTanker
> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) > was merged in 16, MSYS2 became capable of building a functional JDK on > Windows. This PR updates some outdated documentation in building.html and > building.md to reflect that change. > > I appreciate any reviews, a

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Christian Hagedorn
On Thu, 27 Jan 2022 09:26:50 GMT, Thomas Stuefe wrote: > Hi Christian, this is very nice and useful! Thanks Thomas! > Two general remarks. One concern I have is that the new functionality should > be super stable, since nothing is more annoying than to crash during stack > dumping in hs-err f

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported [v2]

2022-01-28 Thread Magnus Ihse Bursie
On Fri, 28 Jan 2022 08:49:56 GMT, TheShermanTanker wrote: >> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) >> was merged in 16, MSYS2 became capable of building a functional JDK on >> Windows. This PR updates some outdated documentation in building.html and >> bui

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported [v2]

2022-01-28 Thread Magnus Ihse Bursie
On Fri, 28 Jan 2022 08:49:56 GMT, TheShermanTanker wrote: >> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) >> was merged in 16, MSys 2 became capable of building a functional JDK on >> Windows. This PR updates some outdated documentation in building.html and >> bu

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported

2022-01-28 Thread Magnus Ihse Bursie
On Thu, 27 Jan 2022 08:49:08 GMT, TheShermanTanker wrote: > Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) > was merged in 16, MSys 2 became capable of building a functional JDK on > Windows. This PR updates some outdated documentation in building.html and > buildi

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported

2022-01-28 Thread TheShermanTanker
On Thu, 27 Jan 2022 08:49:08 GMT, TheShermanTanker wrote: > Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) > was merged in 16, MSys 2 became capable of building a functional JDK on > Windows. This PR updates some outdated documentation in building.html and > buildi

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported [v2]

2022-01-28 Thread TheShermanTanker
> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) > was merged in 16, MSys 2 became capable of building a functional JDK on > Windows. This PR updates some outdated documentation in building.html and > building.md to reflect that change. > > I appreciate any reviews,

Re: RFR: 8280863: Update build README to reflect that MSYS2 is supported

2022-01-28 Thread Magnus Ihse Bursie
On Fri, 28 Jan 2022 08:21:13 GMT, TheShermanTanker wrote: >> The updated wording seems fine to me. >> >> The html file should not be edited by hand, but generated (by pandoc) using >> the make target `update-build-docs`. If you don't have access to pandoc, I >> can help you regenerate the fil

Re: RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) (Update building.md and building.html to reflect change)

2022-01-28 Thread TheShermanTanker
On Thu, 27 Jan 2022 14:37:51 GMT, Erik Joelsson wrote: > The updated wording seems fine to me. > > The html file should not be edited by hand, but generated (by pandoc) using > the make target `update-build-docs`. If you don't have access to pandoc, I > can help you regenerate the file. > > I