Re: RFR: JDK-8218177: Bump jib format_version to support new devkit archive layout

Looks good. Thanks, Christian > On Jan 31, 2019, at 4:23 PM, Erik Joelsson wrote: > > With the new devkits I deployed recently (Oracle internal), the file layout > changed as a top level directory inside the tar archive was introduced. This > works in most cases, but there are certain

Re: (urgent) RFR: JDK-8218084: Revert JDK-8218057

Looks good, thanks for dealing with this so quickly Thanks, Christian > On Jan 30, 2019, at 12:47 PM, Erik Joelsson wrote: > > The addition of new build profiles in jib-profiles.js caused our internal > build and test system to break down. While we fix the resilience of that > system, we

Re: RFR: JDK-8216021: RunTest.gmk might set concurrency level to 1 on Windows

Looks good, thanks for fixing this! Thanks, Christian > On Jan 3, 2019, at 2:30 AM, Erik Joelsson wrote: > > When running tests using "make run-test-prebuilt" on Windows, the calculation > of available memory may fail. This only happens on certain systems, and is > likely related to which

Re: RFR: JDK-8215991: Stop hiding exception from ArtifactResolver failures in tests

Looks good. Thanks, Christian > On Jan 2, 2019, at 5:46 AM, Erik Joelsson wrote: > > In the test lib, we have an ArtifactResolver which is used by tests that need > external resources. Internally at Oracle we hook Jib into this to provide > such dependencies. For other users, it's possible

Re: RFR: JDK-8211727: Adjust default concurrency settings for running tests on Sparc

Hi Erik, Looks good, thanks for fixing this. Thanks, Christian > On Nov 13, 2018, at 1:34 PM, Erik Joelsson wrote: > > This patch changes the formula for default test concurrency in RunTest.gmk. > The current formula is: > > min(cpus/2, 12) > > This seems to work well enough on the x64

Re: RFR: JDK-8213005: Missing symbols in hs_err files on Windows after JDK-8212028

Hi Erik, This looks good, thanks for fixing this! Thanks, Christian > On Oct 25, 2018, at 4:27 PM, Erik Joelsson wrote: > > When running tests through the new RunTest makefile framework in Mach5, we > are now missing symbol information in hs_err files on Windows. This is caused > by the new

RFR: 8212008: Use of TREAT_EXIT_CODE_1_AS_0 hide problems with jtreg Java

Hi, When running JDK and Hotspot jtreg tests through make, TREAT_EXIT_CODE_1_AS_0 is set to true. Any issue with the Java installation used to run jtreg won’t be reflected in the exit code. This has been seen a bunch of times in our internal CI system where we thought we ran tests but instead

Re: RFR(S/M) [trivial] 8206429 : [REDO] 8202561 clean up TEST.groups

I agree with Igor, this wouldn’t have been found by “normal” pre-integration testing. Change looks good, sorry for the extra work you had to do. Thanks, Christian > On Jul 5, 2018, at 5:33 PM, Igor Ignatyev wrote: > > well, I did test it last time, I just didn't expect that some parts of

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

b is queued? I’ve opened an enhancement for adding a notification once the job has been handed off to our build and test farm. Thanks, Christian > > Thanks, > Iris > > -Original Message- > From: Christian Tornqvist > Sent: Thursday, April 12, 2018 6:

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

look into sending an email notification that the job has been started if that would help? Thanks, Christian > Would have been helpful in this situation . > > Best regards, Matthias > > >> -Original Message- >> From: Christian Tornqvist [mailto:christian.tor

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Matthias, > On Apr 12, 2018, at 3:49 35AM, Baesken, Matthias > wrote: > > Hi, could someone please sponsor the change now ? > > And could someone please check what happened to the submit-repo ? > Yesterday I pushed to the submit repo to check my

Re: RFR(M): 8200126: [TESTBUG] Open source VM runtime signal tests

Hi Misha, This looks good, thanks for doing this. Thanks, Christia > On Mar 29, 2018, at 10:41 04PM, Mikhailo Seledtsov > wrote: > > While testing I discovered build errors on Mac and Solaris. The following > statement "

Re: RFR: JDK-8199197: Set _NT_SYMBOL_PATH when running tests on windows

Hi Erik, This looks good, many thanks for fixing this! Thanks, Christian > On Mar 7, 2018, at 12:06 32PM, Erik Joelsson wrote: > > When running tests on Windows in a distributed environment we currently don't > have access to debug symbols, which causes stack

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Forgot to say that the webrev looks good! > On Feb 23, 2018, at 3:53 PM, Christian Tornqvist > <christian.tornqv...@oracle.com> wrote: > > Sounds like a good plan :) > > Thanks, > Christian > >>> On Feb 23, 2018, at 3:22 PM, Lois Foltan <lois.fol...@

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Sounds like a good plan :) Thanks, Christian > On Feb 23, 2018, at 3:22 PM, Lois Foltan <lois.fol...@oracle.com> wrote: > >> On 2/23/2018 3:18 PM, Christian Tornqvist wrote: >> >> Hi Lois, >> >> Why do we link jvm.dll with -base? > Hi Chris

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Hi Lois, Why do we link jvm.dll with -base? Thanks, Christian > On Feb 23, 2018, at 3:11 PM, Lois Foltan wrote: > > Please review this fix to ignore linker warning (LNK4281). This is a new > linker warning generated by VS2017 v15.5 to "to point out any 64-bit image

RFR: 8196197 - Enable the make system to calculate concurrency for JDK tests

Please review this small change that makes the JDK make test target use the same method for calculating jtreg concurrency as Hotspot. Verified locally and in Mach5. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8196197/webrev.00/

RFR: 8194636 - Apply CONCURRENCY_FACTOR to max value in concurrency calculation

Please review this small change that allows the CONCURRENCY_FACTOR to also be applied when we hit the max value (currently 12) when calculating concurrency. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8194636/webrev.00/

Re: RFR: 8191768 - Introduce a concurrency factor to be able to scale up or down jtreg concurrency when running Hotspot tests

> On Nov 29, 2017, at 2:22 AM, David Holmes <david.hol...@oracle.com> wrote: > > Catching up after mini-vacation ... > > On 23/11/2017 2:47 AM, Christian Tornqvist wrote: >> Please review this small change that allows a user to scale up or down the >> conc

RFR: 8191768 - Introduce a concurrency factor to be able to scale up or down jtreg concurrency when running Hotspot tests

Please review this small change that allows a user to scale up or down the concurrency for running Hotspot jtreg tests using CONCURRENCY_FACTOR. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8191768/webrev.00/ Bug:

RFR: 8189115 - Pass JIB_DATA_DIR to jtreg harness

Please review this small change that allows a user to specify a location for the JIB cache when running jtreg tests that use the JIB Artifact resolver. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8189115/webrev.00/

RFR: 8188038 - Add Windows-x64-open bundles to jib-profiles.js

Please review this small change that adds the bundle names for the Windows-x64-open and ri builds to jib-profiles. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8188038/webrev.00/ Thanks, Christian

Re: RFR: JDK-8186470: JDK10 hotspot integration has broken all MacOS dummy builds

Hi Erik, This looks good, thanks for fixing this. Thanks, Christian > On Aug 22, 2017, at 7:59 AM, Erik Joelsson wrote: > > When running the build on Macosx with a very long path to the root dir, we > have started hitting the command line length limit while linking

RFR(XS): 8184772 - Make it possible to pass arguments only to the Java running the tests when running jtreg through make

Hi everyone, Please review this small change that enables passing options only to the Java under test when running jtreg through the make files. Options passed as -vmoption will be passed to both to the Java compiling and running the tests, options passed as -javaoptions are only passed to the

Re: JDK-8180600: make run-test does not work with jib test dependencies

Hi Erik, This looks good, thanks for fixing this. Thanks, Christian > On May 18, 2017, at 8:18 AM, Erik Joelsson wrote: > > The new run-test target does not work with the new jib test dependencies > feature in jdk10-hs. The fix is small, just adding JIB_JAR to the

Re: RFR: JDK-8180081: Adjust Jib and JDL configuration for 10 to support promotable builds

Hi Erik, This looks good, thanks for fixing this! Thanks, Christian > On May 10, 2017, at 2:12 PM, Erik Joelsson wrote: > > This patch contains adjustments for the jib-profiles.js configuration needed > for supporting the next generation Oracle internal build and

Re: RFR: JDK-8179078: Jib run-test-prebuilt profile missing dependency on bootjdk

Hi Erik, This looks good, I’ve verified that the fix works. Thanks for fixing this! Thanks, Christian > On Apr 21, 2017, at 10:43 AM, Erik Joelsson wrote: > > (resending to include Christian) > > > On 2017-04-21 16:37, Erik Joelsson wrote: >> Hello, >> >> When

RE: RFR(M): 8175300 - Enable artifact resolution for jtreg tests

Updated webrev based on feedback from Magnus Ihse Bursie: http://cr.openjdk.java.net/~ctornqvi/webrev/8175300/webrev.01/ -Original Message- From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On Behalf Of Christian Tornqvist Sent: Tuesday, March 7, 2017 3:03 PM To: hotspot

RFR(M): 8175300 - Enable artifact resolution for jtreg tests

Hi everyone, Please review this change that adds the ability to have external dependencies in jtreg tests. As a proof of concept, I've added Scimark to the Hotspot repository. The concept is this, annotate the test with one or more @Artifact annotation describing the external dependencies,

RFR(XS): 8168137 - import-hotspot build target not removed from hotspot-ide-project

Hi, Please review this small change to not use the import-hotspot make target, also updated where to find jvm.dll once the build has completed. Tested using make hotspot-ide-project and then using VS to build/rebuild/debug using the generated project files. Webrev:

RE: JDK-8171163 Merge 9de6a70d5d81 broke test/Makefile

Hi Magnus, This looks good, thanks for fixing this. Thanks, Christian -Original Message- From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On Behalf Of Magnus Ihse Bursie Sent: Tuesday, December 13, 2016 7:49 AM To: build-dev ; hotspot-dev

Re: RFR: JDK-8156018: Hotspot visual studio project generation broken

Hi Erik, Looks good, thanks for fixing this! Thanks, Christian > On May 9, 2016, at 6:09 AM, Erik Joelsson wrote: > > Friendly reminder. If at least someone who cares about VS projects could > try it out and stamp this, that should be enough I think? > > /Erik > >>

RE: RFR(S): 8027480 - Build Windows x64 fastdebug builds using /homeparams

Adding build-dev as well -Original Message- From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On Behalf Of Christian Tornqvist Sent: Tuesday, August 19, 2014 7:39 PM To: hotspot-...@openjdk.java.net Subject: RFR(S): 8027480 - Build Windows x64 fastdebug builds using

RE: RFR(S): 8027480 - Build Windows x64 fastdebug builds using /homeparams

in ProjectCreator. New webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8027480/webrev.01/ Thanks, Christian -Original Message- From: Daniel D. Daugherty [mailto:daniel.daughe...@oracle.com] Sent: Wednesday, August 20, 2014 9:48 AM To: Christian Tornqvist Cc: hotspot-...@openjdk.java.net

RE: RFR(S): 8027480 - Build Windows x64 fastdebug builds using /homeparams

[rsp+10h],edx mov qword ptr [rsp+8],rcx pushrbp pushrsi Thanks, Christian -Original Message- From: Daniel D. Daugherty [mailto:daniel.daughe...@oracle.com] Sent: Wednesday, August 20, 2014 11:17 AM To: Christian Tornqvist Cc: hotspot-...@openjdk.java.net; build-dev

RE: RFR(S): 8027480 - Build Windows x64 fastdebug builds using /homeparams

12:02 PM To: Christian Tornqvist Cc: hotspot-...@openjdk.java.net; build-dev@openjdk.java.net Subject: Re: RFR(S): 8027480 - Build Windows x64 fastdebug builds using /homeparams On 8/20/14 9:48 AM, Christian Tornqvist wrote: indicate that we shouldn't need this change in our debug/fastdebug

RE: Proposal: jtreg tests with native components

Hi Staffan, This sounds like a great proposal that would solve many of our issues with tests requiring native code. Would it be possible for the make system to pick up a custom makefile from a test folder? The use cases I see are: 1. Launcher type tests (we have a few of these), these needs to

Re: RFR: 8007446: Add /MP to cl.exe speeds up windows builds of OpenJDK.

Looks good, many thanks for fixing this! Thanks, Christian On Oct 3, 2013, at 5:01, Erik Joelsson erik.joels...@oracle.com wrote: Please review this simple patch adding /MP to the windows cl.exe command lines when supported. In my tests, the speed improvement is around 40% on the hotspot

RE: RFR (XS) JDK-8025569: -XX:+CheckUnhandledOops crashes on Windows

Hi Lois, Looks good, might be worth clarifying that this disables CheckUnhandledOops for both 32 and 64-bit Windows. Thanks, Christian From: hotspot-runtime-dev-boun...@openjdk.java.net [mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Lois Foltan Sent: Tuesday,

RE: RFR (M): 8008772: remove gamma launcher

Hi Vladimir, Nils attached the patch to the email, but I've put the patch at http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also Thanks, Christian -Original Message- From: hotspot-dev-boun...@openjdk.java.net [mailto:hotspot-dev-boun...@openjdk.java.net] On Behalf Of Vladimir