Hi Christoph,
thanks for reviewing, testing and for the approval. Pushed.
Best regards,
Martin
From: Langer, Christoph
Sent: Samstag, 16. Januar 2021 12:03
To: Doerr, Martin ; jdk-updates-...@openjdk.java.net;
build-dev@openjdk.java.net
Cc: Lindenmaier, Goetz
Subject: RE: [11u] RFR: 8257633
Hi Götz,
thanks for the review.
Best regards,
Martin
From: Lindenmaier, Goetz
Sent: Freitag, 15. Januar 2021 11:29
To: Doerr, Martin ; jdk-updates-...@openjdk.java.net;
build-dev@openjdk.java.net
Cc: Langer, Christoph
Subject: RE: [11u] RFR: 8257633: Missing -mmacosx-version-min=X flag when
Hi,
JDK-8257633 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change doesn't apply cleanly because of an unrelated context change in the
neighboring code.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8257633
Original change:
n
> -Original Message-
> From: Roland Westrelin
> Sent: Montag, 11. Januar 2021 17:40
> To: Doerr, Martin ; jdk-updates-
> d...@openjdk.java.net; build-dev@openjdk.java.net
> Cc: Lindenmaier, Goetz ; Langer, Christoph
>
> Subject: RE: [11u] RFR: 82
Roland Westrelin
> Sent: Montag, 11. Januar 2021 17:16
> To: Doerr, Martin ; jdk-updates-
> d...@openjdk.java.net; build-dev@openjdk.java.net
> Cc: Lindenmaier, Goetz ; Langer, Christoph
>
> Subject: Re: [11u] RFR: 8256810: Incremental rebuild broken on Macosx
>
>
&
Hi,
JDK-8256810 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change doesn't apply cleanly because of an unlrelated context change (Solaris
removal).
Bug:
https://bugs.openjdk.java.net/browse/JDK-8256810
Original change:
https://github.com/openjdk/jdk/commit/4c86e46d
and best regards,
Martin
> -Original Message-
> From: Yasumasa Suenaga
> Sent: Dienstag, 18. August 2020 05:03
> To: David Holmes ; Baesken, Matthias
> ; hotspot-runtime-...@openjdk.java.net;
> build-dev@openjdk.java.net; Doerr, Martin
> Subject: Re: PING: RFR: 8250598
Hi Matthias,
Looks good. Thanks for fixing it.
Best regards,
Martin
> Am 26.06.2020 um 09:59 schrieb David Holmes :
>
> Hi Matthias,
>
> That all seems fine to me.
>
> David
>
>> On 26/06/2020 5:06 pm, Baesken, Matthias wrote:
>> Hello, please review this small patch that fixes the
Hi Kim,
builds out of the box on AIX with IBM XL C/C++ for AIX, V16.1.0 (We already use
clang frontend by default.)
Very cool!
Best regards,
Martin
> -Original Message-
> From: build-dev On Behalf Of Kim
> Barrett
> Sent: Freitag, 5. Juni 2020 09:53
> To: build-dev
> Cc:
Thanks for the reviews! Pushed.
Best regards,
Martin
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 12. Mai 2020 11:01
> To: build-dev@openjdk.java.net
> Cc: Doerr, Martin
> Subject: RE: RFR(XS): 8244756: Build broken with some awk version af
Hi Magnus,
thank you for proposing a fix which allows building with old awk on AIX. Works
fine.
Here's the webrev:
http://cr.openjdk.java.net/~mdoerr/8244756_AIX_fix_awk_expr/webrev.00/
Would you like to be mentioned as author?
Best regards,
Martin
Hi Matthias,
thanks for removing no longer existing files from the list.
I guess the list will need further updates to become really useful, but your
change looks good.
Best regards,
Martin
> -Original Message-
> From: hotspot-dev On Behalf Of
> Erik Joelsson
> Sent: Freitag, 17.
Hi Christoph,
looks good. Thanks for fixing this part in 11u.
Best regards,
Martin
> -Original Message-
> From: build-dev On Behalf Of
> Langer, Christoph
> Sent: Montag, 23. Dezember 2019 15:30
> To: jdk-updates-dev
> Cc: build-dev
> Subject: [11u] RFR: 8236500: Windows ucrt.dll
Hi Christoph,
looks good. Thanks for backporting.
Best regards,
Martin
> -Original Message-
> From: jdk-updates-dev On
> Behalf Of Langer, Christoph
> Sent: Montag, 23. Dezember 2019 15:00
> To: jdk-updates-dev
> Cc: build-dev
> Subject: [11u] RFR: 8232167: Visual Studio install
mber 2019 23:35
> To: Doerr, Martin ; Baesken, Matthias
> ; Erik Joelsson ;
> 'build-dev@openjdk.java.net' ; 'hotspot-
> d...@openjdk.java.net'
> Subject: Re: building libjvm with -Os for space optimization - was : RE: RFR:
> 8234525: enable link-time section-gc for linux s390x
, though.
Best regards,
Martin
> -Original Message-
> From: Claes Redestad
> Sent: Mittwoch, 27. November 2019 18:57
> To: Baesken, Matthias ; Doerr, Martin
> ; Erik Joelsson ; 'build-
> d...@openjdk.java.net' ; 'hotspot-
> d...@openjdk.java.net'
> Subject: Re:
Hi Matthias and Erik,
I also think this is an interesting option.
I like the idea to generate smaller libraries. In addition to that, I could
also imagine building with -Os (size optimized) by default and only select -O3
for performance critical files (e.g. C2's register allocation, some gc
Hi Matthias,
thanks for fixing xlc16 support for jdk11u. I appreciate it.
Fix looks good to me.
Best regards,
Martin
From: Baesken, Matthias
Sent: Mittwoch, 30. Oktober 2019 15:38
To: jdk-updates-...@openjdk.java.net; 'build-dev@openjdk.java.net'
Cc: Langer, Christoph ; Doerr, Martin
ent: Dienstag, 29. Oktober 2019 13:25
To: Doerr, Martin ; 'hotspot-...@openjdk.java.net'
Cc: 'build-dev@openjdk.java.net'
Subject: RE: RFR: 8233078 : fix minimal VM build on Linux ppc64(le)
Hi Martin, thanks for the input .
I did the adjustments you suggested; new webrev :
http://cr.openjdk.java.
critical.
stubGenerator_ppc.cpp:
Code should better be protected by #ifdef COMPILER2 than commenting out.
Otherwise, looks good to me.
Thanks,
Martin
From: Baesken, Matthias
Sent: Dienstag, 29. Oktober 2019 12:42
To: 'hotspot-...@openjdk.java.net'
Cc: 'build-dev@openjdk.java.net' ; Doerr, Martin
Hi Matthias,
looks good to me. I think this makes sense for jdk14 where we only support
xlclang++ on AIX.
Best regards,
Martin
> -Original Message-
> From: build-dev On Behalf Of
> Baesken, Matthias
> Sent: Montag, 22. Juli 2019 12:03
> To: Baesken, Matthias ; 'build-
>
+1
Thanks,
Martin
> -Original Message-
> From: build-dev On Behalf Of
> Langer, Christoph
> Sent: Montag, 8. Juli 2019 15:26
> To: Baesken, Matthias ; Thomas Stüfe
>
> Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net
> Subject: [CAUTION] RE: 8227389: Remove
Hi Matthias,
the change looks good to me.
According to an old redbook [1], this flag makes stacks and r/w sections of the
lib non-executable. This makes sense.
Best regards,
Martin
[1] AIX 5L Differences Guide Version 5.3 Edition
-Original Message-
From: Erik Joelsson
Hi Volker,
the wiki is already up to date, so I like your new version which just refers to
it. Reviewed.
Best regards,
Martin
-Original Message-
From: build-dev On Behalf Of Volker Simonis
Sent: Dienstag, 5. März 2019 16:17
To: build-dev
Subject: RFR(XS): 8220164: Fix build
Hi Matthias,
excellent. Looks good to me. This should make AIX ready for JEP 347.
Thanks
Martin
From: Baesken, Matthias
Sent: Montag, 18. Februar 2019 13:53
To: Magnus Ihse Bursie ;
'build-dev@openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR : 8218965: aix: support xlclang
election mechanism is clearified?
Best regards,
Martin
-Original Message-
From: Baesken, Matthias
Sent: Freitag, 15. Februar 2019 14:31
To: Magnus Ihse Bursie ;
'build-dev@openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR : 8218965: aix: support xlclang++ in the compiler detec
Hi Matthias,
looks good to me, too.
Best regards,
Martin
-Original Message-
From: hotspot-dev On Behalf Of Baesken,
Matthias
Sent: Donnerstag, 7. Februar 2019 10:13
To: Magnus Ihse Bursie ;
'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Subject: RE: RFR [XS] :
regards,
Martin
-Original Message-
From: Severin Gehwolf
Sent: Freitag, 12. Oktober 2018 11:20
To: build-dev
Cc: Doerr, Martin ; Baesken, Matthias
Subject: RFR: 8212110: Build of saproc.dll broken on Windows 32 bit after
JDK-8210647
Hi,
Please review this fix for a build failure
+1
Thanks for improving the code.
Best regards,
Martin
-Original Message-
From: Lindenmaier, Goetz
Sent: Montag, 8. Oktober 2018 12:36
To: Volker Simonis ; Doerr, Martin
Cc: build-dev ;
hotspot-runtime-...@openjdk.java.net runtime
Subject: RE: RFR(XS): 8211837: Creation
Hi Volker,
looks good. Thanks for fixing.
Of course, it would be great if this could be used to fix minimal/zero build,
too.
Best regards,
Martin
-Original Message-
From: hotspot-runtime-dev On
Behalf Of Volker Simonis
Sent: Montag, 8. Oktober 2018 10:19
To: build-dev ;
Thanks for the reviews. Pushed.
Best regards,
Martin
-Original Message-
From: Erik Joelsson
Sent: Mittwoch, 26. September 2018 20:02
To: Doerr, Martin ; 'build-dev@openjdk.java.net'
Subject: Re: RFR(XS): 8211097: aix: fix build after JDK-8210919
Looks good.
/Erik
On 2018-09-26
Hi,
we need to fix the build on AIX as suggested by Magnus.
Webrev:
http://cr.openjdk.java.net/~mdoerr/8211097_aix_fix_build_after_8210919/webrev.00/
Please review.
Thanks,
Martin
;
'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR : 8210205 : build fails on AIX in hotspot cpp tests (for
example getstacktr001.cpp)
Thanks , can I have a second review please ?
Best regards, Matthias
From: Lindenmaier, Goetz
Sent: Donnerstag, 30
Hi Igor,
we get compiler warnings on linux ppc64le (GCC 4.8.5):
libnativeGC05.c:80:19: error: 'pair_getj_mid' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
j = (*env)->CallIntMethod(env, pair, pair_getj_mid);
^
v <build-dev@openjdk.java.net>; Doerr, Martin <martin.do...@sap.com>
Subject: RE: 8201226 missing JNIEXPORT / JNICALL at some places in function
declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some
places in function declarations/implementations
Hello, I had to do
Hi,
we only support 64 bit on s390. Seems like the code could be cleaned up or
updated. Thanks for looking into it.
Best regards,
Martin
-Original Message-
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-boun...@openjdk.java.net]
On Behalf Of David Holmes
Sent: Montag, 23.
Hi Gustavo,
thanks for providing the webrevs.
I have ran the StrictMath jck tests which fail when building with -O3 and
without -ffp-contract=off:
FailedTests:
api/java_lang/StrictMath/desc.html#acos
javasoft.sqe.tests.api.java.lang.StrictMath.acos_test
api/java_lang/StrictMath/desc.html#asin
37 matches
Mail list logo
