On Tue, 14 Jun 2022 10:09:37 GMT, Magnus Ihse Bursie wrote:
>> When we started introducing some possibly more intrusive compiler flags and
>> functionality for reproducible builds, we also introduced a flag to turn
>> this off out of an abundance of caution. But we have been been using this
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>>
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Marked as reviewed by erikj (Reviewer).
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9122
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
Marked as reviewed by erikj (Reviewer).
-
PR:
On Tue, 7 Jun 2022 19:57:48 GMT, Alexey Pavlyutkin
wrote:
> Hi!
>
> Here is a fix to jdk.jdi that fixes reproducible build for Windows. The idea
> of the fix is to re-use value of --with-hotspot-build-time option to generate
> deterministic timestamp exactly like it's done to hotspot
On Tue, 7 Jun 2022 18:15:30 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote:
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the
On Thu, 2 Jun 2022 09:17:59 GMT, Magnus Ihse Bursie wrote:
> I encountered a bunch of issues when running with msys2 on Windows (but one
> of them could have happened on cygwin as well).
>
> * fixpath must set MSYS2_ARG_CONV_EXCL="*" before running cmd.exe to figure
> out the temp directory,
On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote:
> LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option
> for all JDK launchers, including java launcher.
> JAVA_ARGS should not be defined for java launcher (in contrast to the other
> JDK launchers), and the command
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by erikj (Reviewer).
On Tue, 24 May 2022 17:09:10 GMT, Magnus Ihse Bursie wrote:
> The logic in BASIC_SETUP_DEVKIT for setting a correct sysroot for Xcode is
> hard to follow. This should be straightened out. We also expose variables
> that are no longer used. So there's a bit of related cleanup.
>
> The new
On 2022-05-12 04:58, Magnus Ihse Bursie wrote:
On 2022-05-12 13:17, Michael Hall wrote:
A solution like including a bundle identifier something like
net.java.openjdk.MYAPP.java would be possible at packaging time but
not at build time.
To fix this at build time you would need to generate a
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
On Wed, 11 May 2022 20:55:29 GMT, Adam Farley wrote:
> These warnings are ignored while building the build+full jdks with gcc,
> but only ignored while building the full JDK if using clang. This
> produces tons of warnings we normally ignore, e.g. unused parameter.
>
> I suggest that if we're
On Mon, 9 May 2022 23:18:47 GMT, Erik Joelsson wrote:
> The way LauncherCommon.gmk is currently written, it's only meant to be
> included from "make/module//Launcher.gmk", or at least only from one
> single place for each module. This is because the man page generat
On Tue, 10 May 2022 08:46:44 GMT, Severin Gehwolf wrote:
>> `make test TEST="gtest:> `1.10.0`. It expects `suites` to be present in the google test output
>> whereas the OpenJDK build infra code expects `cases`. I'm not sure when/if
>> that changed, but here is a proposed fix.
>>
>> Thoughts?
On Tue, 10 May 2022 08:42:10 GMT, Severin Gehwolf wrote:
> Apparently gtest 1.8.1 uses `cases`. I've updated the patch to handle both:
> `suites` and `cases`. If somebody could test it with gtest 1.8.1 I'd
> appreciate it.
Verified that it works with 1.8.1, which does indeed use `cases`.
On 2022-05-10 04:52, Baesken, Matthias wrote:
So maybe it time to look at it, it might be easier to have a smaller set
of VS releases to support.
Because of how much specific logic we need in configure for each version
of Visual Studio, we have generally kept configure support for older
The way LauncherCommon.gmk is currently written, it's only meant to be included
from "make/module//Launcher.gmk", or at least only from one single
place for each module. This is because the man page generation that happens in
LauncherCommon.gmk is module global. For the jdk.jpackage module,
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Thu, 5 May 2022 19:02:51 GMT, Alexey Semenyuk wrote:
> Copy missing manifest-related parameters to `SetupJdkExecutable` calls
> building app launchers from `SetupBuildLauncher`
>
On Thu, 5 May 2022 09:00:47 GMT, Athijegannathan Sundararajan
wrote:
> This test requires jdk8 to be available while running jdk tests. But
> JDK8_HOME is defined to be BOOT_JDK and so version check fails in the test.
> The test vacuously passes just printing a message. There are already
On Wed, 4 May 2022 03:06:44 GMT, Yasumasa Suenaga wrote:
> We can specify `git` binary via `GIT` in configure script, but it does not
> affect in SourceRevision.gmk .
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8526
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Mon, 2 May 2022 06:25:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285915?
>>
>> With this change, the environment details collected by the failure handler
>> will now include the contents of the
On Fri, 29 Apr 2022 22:50:45 GMT, Ioi Lam wrote:
> During `java -Xshare:dump -XX:-UseCompressedOops`, the location of the Java
> heap is chosen by the OS. Due to Address Space Layout Randomization, the heap
> will always start at a different location. This causes the archive for
>
On Fri, 29 Apr 2022 12:43:02 GMT, Magnus Ihse Bursie wrote:
> A debug printout in configure was introduced in JDK-8285093. It should be
> removed.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8467
On Fri, 29 Apr 2022 12:51:21 GMT, Jaikiran Pai wrote:
> Quick question - the path you note, is that even applicable for x64? I see
> that it has a "System32" so just curious.
Yes, System32 is not related to 32 vs 64 bit. As I understand it, that name was
introduced when moving from 16 to 32
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
On Wed, 27 Apr 2022 19:16:48 GMT, Erik Joelsson wrote:
> The make option '--output-sync recurse' can be useful in certain situations,
> especially when dealing with very verbose output from makefiles and you want
> to parse them after the fact. However, when running make inte
On Thu, 28 Apr 2022 10:24:37 GMT, Matthias Baesken wrote:
> Currently , in target "product-bundles" , the Alpine Linux build fails when
> BusyBox tar is used.
> Error is :
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8449
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote:
>> We are trying to cross build a RISC-V version of OpenJDK. We specified
>> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an
>> error message.
>>
>>
>> configure: error: /usr/bin/bash
>>
On Thu, 28 Apr 2022 08:14:08 GMT, Nick Gasson wrote:
> Is there a reason we can't import the latest upstream config.sub? That
> already handles RISC-V and AArch64 correctly.
>
> https://git.savannah.gnu.org/cgit/config.git/plain/config.sub
That would indeed be convenient, but unfortunately
On Thu, 28 Apr 2022 07:16:30 GMT, Matthias Baesken wrote:
> Hi Erik/David/Phil, we already have a good central place where we set the
> definition of WIN32_LEAN_AND_MEAN
>
> autoconf/flags-cflags.m4:460: ALWAYS_DEFINES_JDK="-DWIN32_LEAN_AND_MEAN
> -D_CRT_SECURE_NO_DEPRECATE
The make option '--output-sync recurse' can be useful in certain situations,
especially when dealing with very verbose output from makefiles and you want to
parse them after the fact. However, when running make interactively on the
command line, it certainly gets in the way, as output from each
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
>
On 2022-04-27 06:55, Baesken, Matthias wrote:
Hi, today I was running into build problems with busybox tar on Alpine
Linux .
When building “product-bundles” I get :
/bin/tar: unrecognized option: I
BusyBox v1.34.1 (2022-04-04 10:19:27 UTC) multi-call binary
Usage: tar c|x|t
On Wed, 27 Apr 2022 09:50:35 GMT, Pengfei Li wrote:
> We are trying to cross build a RISC-V version of OpenJDK. We specified
> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an
> error message.
>
>
> configure: error: /usr/bin/bash
>
On Tue, 19 Apr 2022 20:38:31 GMT, Magnus Ihse Bursie wrote:
> Analogous to `UTIL_ARG_ENABLE`, we need a `UTIL_ARG_WITH` which wraps
> ´AC_ARG_WITH`, provides a declarative rather than programmatic way of
> handling configure arguments. It can also make sure that all edge cases are
> covered,
On Tue, 19 Apr 2022 10:41:07 GMT, Magnus Ihse Bursie wrote:
> JEP 298 was about removing demos and samples. Unfortunately,
> [JDK-8173801](https://bugs.openjdk.java.net/browse/JDK-8173801) which should
> have removed all files in src/samples, left a few non-source files (key
> stores and
On Mon, 18 Apr 2022 09:07:03 GMT, Feilong Jiang wrote:
> This patch adds Zero support for the 32-bit RISC-V architecture.
>
> Additional tests:
>
> - [x] Linux zero RISCV32 cross-compilation
> - [x] Resulting binaries run on QEMU User mode without problems
Build change looks good.
On Fri, 15 Apr 2022 11:49:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO
On Thu, 14 Apr 2022 16:13:59 GMT, Andrew Leonard wrote:
> JDK-8282769 added support for more ISO-8601 formats, but remove handling of
> just a date "-MM-DD" being present, which is the case for a configure
> using --with-source-date=version which uses the date string from
>
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A
On Thu, 14 Apr 2022 11:19:04 GMT, Claes Redestad wrote:
> This patch examines and optimizes `Wrapper` lookups.
>
> First wrote a few simple microbenchmarks to verify there are actual speedups
> from using perfect hash tables in `sun.invoke.util.Wrapper` compared to
> simpler lookup mechanisms
On Mon, 11 Apr 2022 17:26:12 GMT, Andrew Leonard wrote:
>> test/jdk/build/AbsPathsInImage.java line 167:
>>
>>> 165: if (Files.isSymbolicLink(file)) {
>>> 166: return super.visitFile(file, attrs);
>>> 167: } else if (fileName.endsWith(".pdb"))
On Mon, 11 Apr 2022 12:55:16 GMT, Erik Joelsson wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file AS
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 09:43:37 GMT, Andrew Leonard wrote:
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where
On Fri, 8 Apr 2022 14:57:02 GMT, Magnus Ihse Bursie wrote:
> There's been unnecessary (near) duplication of functionality, and messy
> logic, in the langtools gensrc step, for a long time. (Basically since we got
> rid of the mercurial forest...)
>
> This is a first attempt at cleaning this
On Fri, 8 Apr 2022 13:23:23 GMT, Andrew Leonard wrote:
> @magicus I will create a new PR, with .file <...S> directives added to the
> linux platform assembly files, and undo the relative path linking. Does that
> seem reasonable?
Will that not affect the ability to debug these files, as GDB
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000],
On Thu, 7 Apr 2022 18:17:57 GMT, Andrew Leonard wrote:
>> make/common/NativeCompilation.gmk line 1159:
>>
>>> 1157: ifeq ($(call isTargetOs, linux), true)
>>> 1158: ifeq ($$($1_COMPILE_WITH_DEBUG_SYMBOLS), true)
>>> 1159: $1_LINK_OBJS_RELATIVE := true
>>
>> I realize
On Thu, 7 Apr 2022 15:51:30 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Trigger checks
>
> make/common/NativeCompilation.gmk line 1159:
>
>> 1157: ifeq ($(call isTargetOs,
On Thu, 7 Apr 2022 00:56:42 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package
On Wed, 6 Apr 2022 10:27:40 GMT, Andrew Leonard wrote:
> This PR fixes the non-deterministic behavior when building on linux with
> different userids or within
> different workspace folders.
> It fixes the following issues:
> - MakeZipReproducible.java used to produce reproducible src.zip
On Wed, 30 Mar 2022 12:25:52 GMT, Aleksey Shipilev wrote:
> JMH 1.35 is released, so we can bump the devkit too.
>
> Additional testing:
> - [x] JMH devkit creation
> - [x] Sample benchmarks
Marked as reviewed by erikj (Reviewer).
-
PR:
On Wed, 30 Mar 2022 01:05:08 GMT, Magnus Ihse Bursie wrote:
> When a user has problems with their build environment that trips up their
> builds, the cause is often one of just a few "popular" gotchas. For us
> working with the build system, we've seen them all before, but for the
>
On Mon, 28 Mar 2022 16:40:31 GMT, Mikael Vidstedt wrote:
>> Oracle is updating the version of Visual Studio for building the JDK on
>> Windows to Visual Studio 2022 17.1.0.
>>
>> This change adds support for building devkits based on VS 2022. Instead of
>> creating a new script file for that
On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote:
> The version output of GNU time changed from "GNU time" to "GNU Time" in
> version 1.8. We need to update our check for identifying GNU time to handle
> this.
This pull request has now been integrated
> The version output of GNU time changed from "GNU time" to "GNU Time" in
> version 1.8. We need to update our check for identifying GNU time to handle
> this.
Erik Joelsson has updated the pull request incrementally with one additional
commit since the last revi
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
On Wed, 23 Mar 2022 16:22:55 GMT, Aleksey Shipilev wrote:
> Looks okay, provided you tested with some version of GNU [Tt]ime.
Thanks! I hit this while trying to use GNU time on my mac to get LOG=profile to
work, to profile compilation times of individual compilation units. I built
latest
The version output of GNU time changed from "GNU time" to "GNU Time" in version
1.8. We need to update our check for identifying GNU time to handle this.
-
Commit messages:
- JDK-8283575
Changes: https://git.openjdk.java.net/jdk/pull/7925/files
Webrev:
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
On Tue, 22 Mar 2022 19:07:12 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote:
> Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
> which is used by libsplashscreen.
>
> Policy is not to change the upstream code locally unless it is also changed
> in the same way upstream.
> We could consider
On Tue, 22 Mar 2022 14:04:07 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Mon, 21 Mar 2022 10:45:27 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] -
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Fri, 18 Mar 2022 20:33:54 GMT, Mikael Vidstedt wrote:
> Oracle is updating the version of GCC for building the JDK on Linux to 11.2.
>
> Testing: tier1-5 + additional significant testing. Re-running
> tier1,builds-tier{2,3,4,5} now for good luck.
Marked as reviewed by erikj (Reviewer).
On Thu, 17 Mar 2022 13:11:19 GMT, Julian Waters wrote:
> TOOLCHAIN_SETUP_MSVC_DLL always points to --with-msvcr-dll if it couldn't
> find the requested file, even if the dll being searched for was msvcp.dll for
> instance. This small patch fixes the potentially confusing advice to point to
>
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Mar 2022 13:14:39 GMT, Magnus Ihse Bursie wrote:
> Nowadays only clang is available as compiler for macOS. We should remove
> remnants of the gcc support.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7841
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote:
> Implementation of [JDK-8275062: "Allow jpackage create installers for
> services"](https://bugs.openjdk.java.net/browse/JDK-8275062)
> CSR
Build change looks good.
-
PR: https://git.openjdk.java.net/jdk/pull/7793
On 2022-03-11 23:17, Julian Waters wrote:
I meant in toolchain.m4, which allows gcc for macOS
Apple used to ship GCC as part of Xcode, and the original Mac port of
OpenJDK used that GCC. This was eventually removed from Xcode and the
OpenJDK build was changed to use Clang instead. To make
On Sat, 12 Mar 2022 03:26:29 GMT, Mikael Vidstedt wrote:
> Background, from JBS:
>
> In file included from
> googletest-release-1.8.1/googletest/src/gtest-all.cc:42:
> googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function
> 'bool testing::internal::StackGrowsDown()':
>
On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote:
> Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names,
> which means the test jobs in GHA workflows are unable to run.
>
> See for example JDK 18u GHA run:
>
> Build step produce:
>
>
> Creating
On Thu, 10 Mar 2022 11:49:06 GMT, Magnus Ihse Bursie wrote:
> If VERSION_BUILD is empty, we must still store a "0" in
> MACOSX_BUNDLE_BUILD_VERSION.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7773
On Tue, 8 Mar 2022 19:11:02 GMT, Ioi Lam wrote:
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a
On Mon, 7 Mar 2022 23:32:33 GMT, Magnus Ihse Bursie wrote:
> For reproducability, we should set the source date on jib profiles from the
> buildId.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7735
On Mon, 7 Mar 2022 22:47:13 GMT, Magnus Ihse Bursie wrote:
> The BSD version of the date command that ships with macOS cannot handle all
> ISO 8601 formats. More specifically, it cannot handle trailing milliseconds.
>
> This fix will allow it to be more tolerant.
Are we losing the timezone
On Mon, 7 Mar 2022 17:23:40 GMT, Magnus Ihse Bursie wrote:
>> When doing reproducible builds, controlling the build time is imperative. To
>> make this as easy as possible, some changes are needed in the build system.
>>
>> * If source-date is set to anything other than "updated" (meaning
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote:
> Should I change the JBS issue title to match the PR title, or is it preferred
> for the PR title to change?
They need to match. You can either do it manually, or change the title to just
the bug number and the bot will change it for you.
On Sat, 5 Mar 2022 08:57:45 GMT, Magnus Ihse Bursie wrote:
>> When doing reproducible builds, controlling the build time is imperative. To
>> make this as easy as possible, some changes are needed in the build system.
>>
>> * If source-date is set to anything other than "updated" (meaning
On Mon, 7 Mar 2022 08:07:30 GMT, Julian Waters wrote:
>> Some of the --without options are not properly handled and will crash when
>> processed (For example, --without-version-string), in other cases the
>> --without-* option will actually silently produce incorrect results instead
>> of
Hello Julian,
You are misunderstanding Magnus here. What he means is that we are
compiling the version numbers into Java classes and native libraries
(through generating Java source files with the version information in
them and by setting -D flags when compiling C/C++). Because of this, if
On Fri, 4 Mar 2022 12:00:15 GMT, Magnus Ihse Bursie wrote:
> Over and over again, people are running into issues when their git config has
> core.autocrlf set to true or input. (This is apparently done by default by
> some Windows git installations.)
>
> This will not work with the OpenJDK
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote:
> When doing reproducible builds, controlling the build time is imperative. To
> make this as easy as possible, some changes are needed in the build system.
>
> * If source-date is set to anything other than "updated" (meaning that it
On Wed, 2 Mar 2022 14:30:43 GMT, Magnus Ihse Bursie wrote:
>> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
>> this, together with a valid backend using `--with-hsdis`, will bundle the
>> generated hsdis library with the JDK.
>>
>> The PR also includes a
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote:
> When doing reproducible builds, controlling the build time is imperative. To
> make this as easy as possible, some changes are needed in the build system.
>
> * If source-date is set to anything other than "updated" (meaning that it
On Wed, 2 Mar 2022 13:12:52 GMT, Magnus Ihse Bursie wrote:
>> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
>> this, together with a valid backend using `--with-hsdis`, will bundle the
>> generated hsdis library with the JDK.
>>
>> The PR also includes a
On Tue, 22 Feb 2022 16:10:22 GMT, Magnus Ihse Bursie wrote:
> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
> this, together with a valid backend using `--with-hsdis`, will bundle the
> generated hsdis library with the JDK.
>
> The PR also includes a refactoring of
On Tue, 22 Feb 2022 15:47:05 GMT, Magnus Ihse Bursie wrote:
> Long overdue follow-up bug from JEP 381 (removal of Solaris support). We used
> to make a difference between gnm (GNU nm) and nm (GNU nm on all platforms
> except Solaris, where it were Solaris nm), but this does not make sense
>
1 - 100 of 4242 matches
Mail list logo
