On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> This PR removes the need for relative object file linking introduced by >> JDK-8284437 for linux libraries, by specifying >> .file <relative source path> directives in the linux .S source files. The >> source files specify a .file ASSEMBLY_SRC_FILE >> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk. >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > Andrew Leonard has updated the pull request incrementally with one additional > commit since the last revision: > > 8284661: Reproducible assembly builds without relative linking > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> test/jdk/build/AbsPathsInImage.java line 167: > 165: if (Files.isSymbolicLink(file)) { > 166: return super.visitFile(file, attrs); > 167: } else if (fileName.endsWith(".pdb")) { The .debuginfo suffix has at least historically been used on more OSes than just Linux. I think we should only include .debuginfo files in this test if the OS is also Linux. ------------- PR: https://git.openjdk.java.net/jdk/pull/8177