On 2020-03-09 02:20, Aleksey Shipilev wrote:
On 3/9/20 10:10 AM, David Holmes wrote:
On 9/03/2020 6:30 pm, Magnus Ihse Bursie wrote:
When reworking the JVM feature handling, I wanted to try to compile
Hotspot with various features enabled/disabled. I quickly found out that
it's not really
) files.
New web rev: http://cr.openjdk.java.net/~shurailine/JDK-8240241/webrev.01/
Shura
On Mar 3, 2020, at 12:56 PM, Erik Joelsson <mailto:erik.joels...@oracle.com>> wrote:
Looks good.
/Erik
On 2020-03-03 12:45, Alexandre (Shura) Iline wrote:
Hi.
Can you take a look on th
Looks good.
/Erik
On 2020-03-04 10:09, Mikael Vidstedt wrote:
Please review this change which adds a few linux-aarch64 build profiles and
updates the linux-aarch64 configure arguments in the Oracle jib-profiles.js,
JBS: https://bugs.openjdk.java.net/browse/JDK-8240535
webrev:
Looks good.
/Erik
On 2020-03-03 12:45, Alexandre (Shura) Iline wrote:
Hi.
Can you take a look on this change introducing make support for JCov
DiffCoverage command.
DiffCoverage allows to generate a textual report showing coverage for only
changed source code,
This is an example of how
Build changes look ok.
/Erik
On 2020-02-29 05:02, Weijun Wang wrote:
Please take a review at
https://cr.openjdk.java.net/~weijun/8240261/webrev.00
Thanks,
Max
Hello Timmy,
On 2020-02-28 05:32, Timmy Jose wrote:
Hello,
I have a tarball that I downloaded from
https://builds.shipilev.net/workspaces/jdk-jdk.tar.xz, and was trying to
build the same.
I have no idea what version of the source this is, but I'm guessing it's
a recent snapshot of our
On 2020-02-28 01:04, Magnus Ihse Bursie wrote:
On 2020-02-28 09:59, Magnus Ihse Bursie wrote:
On 2020-02-27 16:07, Erik Joelsson wrote:
On 2020-02-27 06:16, Magnus Ihse Bursie wrote:
I don't think it should be a fatal error. If you have a codesign
binary on your path that does not support
Looks good.
/Erik
On 2020-02-27 06:56, Magnus Ihse Bursie wrote:
The JVM feature rewrite changed spec.gmk so that JVM_FEATURE_
was only set for the variants actually being built. However, in
buildjdk-spec.gmk we override the selected variant with 'server' when
building the buildjdk, but we
On 2020-02-27 06:16, Magnus Ihse Bursie wrote:
I don't think it should be a fatal error. If you have a codesign
binary on your path that does not support --option runtime, you should
still be able to build, but not sign. Change it to a warning, and let
the user continue without CODESIGN.
My
This looks good to me. Style wise I would ask you to break the long line
as it makes future side-by-side comparisons and merges annoying.
/Erik
On 2020-02-26 09:30, Junyuan Zheng wrote:
Hi all,
A recent change in OpenJDK tip
(https://hg.openjdk.java.net/jdk/jdk/rev/dcf88e5c8c07) contains a
Looks good.
/Erik
On 2020-02-24 05:15, Magnus Ihse Bursie wrote:
We've been sorely lacking a way to test the configure script, leading
to just pre-checkin adhoc testing.
Here is a simple framework for running unit tests of functions in our
configure script. The initial tests included are
Looks good to me as long as everyone is happy with the descriptions.
/Erik
On 2020-02-24 00:53, Magnus Ihse Bursie wrote:
On 2020-02-21 16:36, Magnus Ihse Bursie wrote:
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed.
Looks good to me.
/Erik
On 2020-02-21 08:13, Magnus Ihse Bursie wrote:
Prior to JDK-8239450, it was possible to explicitly set the JVM
feature 'minimal', even when building variant server. The reason for
doing this was to get the code in JvmFeatures.gmk that sets
JVM_OPTIMIZATION := SIZE
Baring any component specific opinions on the suggested descriptions of
each feature, the patch looks good to me.
/Erik
On 2020-02-21 07:05, Magnus Ihse Bursie wrote:
The JVM feature rewrite was actually somewhat of a step backwards in
terms of presenting information for the user what
Looks good, nice restructure!
/Erik
On 2020-02-21 02:39, Magnus Ihse Bursie wrote:
The file basics.m4 in make/autoconf is mixing two different concerns:
1) Providing utility/helper functions to the rest of the autoconf files
2) Doing basic or initial setup that does not belong elsewhere.
It
Hello,
On 2020-02-20 01:05, Magnus Ihse Bursie wrote:
On 2020-02-19 16:00, Erik Joelsson wrote:
Hello Magnus,
This is certainly a nice improvement.
Thanks! It's been long overdue...
It looks good to me. I have some comments on implementation details,
but nothing serious enough to require
Hello Magnus,
This is certainly a nice improvement. It looks good to me. I have some
comments on implementation details, but nothing serious enough to
require a new webrev.
Instead of using "echo $foo | sed 's/,/ /g'", since we know we run in
bash, could just use ${foo//,/ }.
be removed.
Thanks, Roger
On 2/13/20 7:41 PM, Erik Joelsson wrote:
Hello,
The fix to make idea.sh support both git and mercurial had the
unfortunate side effect of bailing out completely if neither was
found. This happens to be the case when we run our build system tests
(which includes running
/8237192.2/
Cheers
Christoph
*From:*Langer, Christoph
*Sent:* Montag, 17. Februar 2020 10:17
*To:* Erik Joelsson ; Magnus Ihse Bursie
; 'build-dev@openjdk.java.net'
*Cc:* 'hotspot-...@openjdk.java.net' ;
Baesken, Matthias
*Subject:* RE: RFR: 8237192: Generate stripped/public pdbs on Windows
Looks good.
/Erik
On 2020-02-14 05:51, Erik Helin wrote:
On 2/13/20 6:21 PM, Erik Joelsson wrote:
Hello Erik,
Looks good.
Thanks for reviewing!
On 2/13/20 6:21 PM, Erik Joelsson wrote:
Style wise I try to put closing braces for logical blocks on a new
line, aligned with the opening brace
Looks good.
/Erik
On 2020-02-13 17:44, Leonid Mesnik wrote:
Hi
Could you please review following fix which extend JibArtifactManager to
support download and installation of artifacts with layout different from maven
style.
It is planned that user provide name and properties to resolve
Hello,
The fix to make idea.sh support both git and mercurial had the
unfortunate side effect of bailing out completely if neither was found.
This happens to be the case when we run our build system tests (which
includes running idea.sh) in our distributed test environment. I think
idea.sh
difference b/w .00 and .01
Thanks,
— Igor
On Feb 13, 2020, at 9:23 AM, Erik Joelsson wrote:
Looks good, but could you change the "version" field to "5.0", it should work
now.
/Erik
On 2020-02-13 08:50, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8238943
Hello Erik,
Looks good. Style wise I try to put closing braces for logical blocks on
a new line, aligned with the opening brace. I think that helps making
the already quite convoluted makefile logic a tad more readable.
/Erik
On 2020-02-13 04:44, Erik Helin wrote:
Hi all,
this small patch
Looks good, but could you change the "version" field to "5.0", it should
work now.
/Erik
On 2020-02-13 08:50, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00
10 lines changed: 1 ins; 0 del; 9 mod;
Hi all,
could you please review the patch which changes jtreg
-macos_sign_bundles/04/
Rene
On Wed, Feb 12, 2020 at 8:09 PM Erik Joelsson wrote:
Hello Rene,
On 2020-02-12 02:54, René Schünemann wrote:
Hello Erik,
thank you for your guidance.
I have implemented your requested changes.
Updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534
This looks like https://bugs.openjdk.java.net/browse/JDK-8237879
Workaround is to get an older version of GNU make (trivial to download
and build yourself) and configure with MAKE=yourmake on the configure
command line.
/Erik
On 2020-02-12 14:15, Ty Young wrote:
Hi,
Attempting to build
debug symbols will be installed in the
bundles and also in the jmods.
Please let me know what you think.
Thanks & Best regards
Christoph
*From:*Magnus Ihse Bursie
*Sent:* Freitag, 7. Februar 2020 14:09
*To:* Baesken, Matthias ; Erik Joelsson
; Langer, Christoph
; David Holmes ;
'build
closed implementation)
Here is a webrev with my suggested whitespace fixes and the touch.
http://cr.openjdk.java.net/~erikj/8238534/webrev.02/
[1] http://openjdk.java.net/groups/build/doc/code-conventions.html
/Erik
Rene
On Tue, Feb 11, 2020 at 6:57 PM Erik Joelsson wrote:
On 2020-02-11
Build changes look ok to me. Someone from hotspot should review the cpp
file.
/Erik
On 2020-02-12 08:14, John Paul Adrian Glaubitz wrote:
Hi!
This is an updated RFR to add basic RISC-V support to Zero.
This patch is being used for the riscv64 port in Debian.
Please review the changes in
Looks good.
/Erik
On 2020-02-11 14:29, Roger Riggs wrote:
Please review a small change to the idea.sh script that generates an
IntelliJ project.
It detects either Mercurial or Git repos and generates the appropriate
vcs.xml.
Webrev:
Looks good.
/Erik
On 2020-02-11 12:47, Mikael Vidstedt wrote:
Please review this small change which updates the devkit used when using jib to
build linux-aarch64.
JBS: https://bugs.openjdk.java.net/browse/JDK-8238912
Webrev:
On 2020-02-11 01:08, René Schünemann wrote:
Hello Erik,
thank you for your review. Please see my answers below.
Rene
On Mon, Feb 10, 2020 at 9:34 PM Erik Joelsson wrote:
Hello René,
That looks better. I still have some issues though.
I don't understand line 273 and 305. There is no reason
Looks good.
/Erik
On 2020-02-11 05:08, Magnus Ihse Bursie wrote:
On 2/10/20 6:07 PM, Erik Joelsson wrote:
The webrev is empty.
Ouch. :( I've recently reinstalled my machine, and apparently not all
tooling is working as before. I'm sorry I didn't notice that.
Here's a new attempt, this time
iew and I totally agree with you. It would
definitely be better avoid temp dirs.
I will try to move the creation of the signed image to MacBundles.gmk
and then re-use the SetubBundleFile in Bundles.gmk.
Rene
On Fri, Feb 7, 2020 at 5:19 PM Erik Joelsson wrote:
Hello René,
It's good to see an o
The webrev is empty.
/Erik
On 2020-02-10 00:09, Magnus Ihse Bursie wrote:
In JDK-8213184, a rushed revert was pushed to stop breaking CI builds.
A long-term solution is needed, where test-prebuilt can be restored to
jib-profiles.js. This will require the run-test-prebuilt top-level
make
Adding hotspot-dev since this is caused by a source change in hotspot
and not really a build issue. We see it in our internal arm builds as well.
/Erik
On 2020-02-07 13:38, Marc Hoffmann wrote:
Dear JDK developers,
it looks like building http://hg.openjdk.java.net/jdk/jdk/
Hello René,
It's good to see an open solution to this, but I have some opinions on
the patch.
The concept of building into "temp dirs" that are then removed is a
practice we try to avoid in the build. Whenever possible, each rule
should be a well defined transformation from a set of source
.
* The code need to make sure to separate stripped.pdb and normal pdb
files, when enabled.
* And there must not be a heavy penalty in added code complexity.
/Erik
/Magnus
Thanks
Christoph
-Original Message-
From: build-dev On Behalf Of Erik
Joelsson
Sent: Donnerstag, 23. Januar 20
quot;something like"
wording) but I see your point. Changed it.
/Erik
Thanks
Christoph
-Original Message-
From: Magnus Ihse Bursie
Sent: Mittwoch, 5. Februar 2020 10:54
To: Erik Joelsson ; core-libs-dev ; build-dev ; Langer,
Christoph
Subject: Re: RFR: JDK-8238225: Issues
Looks good.
/Erik
On 2020-02-05 03:11, Magnus Ihse Bursie wrote:
On more than one occasion, we have had reports about not being able to
build on Windows due to Visual Studio being installed with a different
language. This causes the check in toolchain.m4 to fail as it assumes
the compiler
Looks good.
/Erik
On 2020-02-05 03:33, Magnus Ihse Bursie wrote:
From the bug report:
"I'm seeing errors like this now:
/ws/dev1/open/src/java.base/share/native/libzip/zlib/inflate.c:766:25:
error: this statement may fall through [-Werror=implicit-fallthrough=]
state->mode = EXLEN;
It
Looks good.
/Erik
On 2020-02-05 03:08, Magnus Ihse Bursie wrote:
I ran into the check that verifies that the C and C++ compilers are
from the same version, but the output was duplicated. It turns out we
check both the normal toolchain and the build toolchain (of course),
but we are not clear
Looks good!
/Erik
On 2020-02-05 03:03, Magnus Ihse Bursie wrote:
When calling FLAGS_COMPILER_CHECK_ARGUMENTS or any of its variants, we
almost always need to add -Werror to the set of arguments to check as
otherwise we would not get a failure for unsupported arguments. This
should be added
Does anyone have an opinion on this?
/Erik
On 2020-01-31 07:31, Erik Joelsson wrote:
In JDK-8235687 the MacOS bundle distribution of the JDK was changed to
conform to Apple requirements by changing Contents/MacOS/libjli.dylib
from a symlink into ../Home/lib/libjli.dylib to a copy of that file
Looks good to me.
/Erik
On 2020-02-03 00:02, Magnus Ihse Bursie wrote:
JEP 347 "Adopt C++14 Language Features in HotSpot" (JDK-8208089) will
require that all compilers support the C++14 language extension. The
first gcc version to fully support C++14 is 5.0. We need to raise the
bar from 4.8
In JDK-8235687 the MacOS bundle distribution of the JDK was changed to
conform to Apple requirements by changing Contents/MacOS/libjli.dylib
from a symlink into ../Home/lib/libjli.dylib to a copy of that file. The
problem with having a symlink there is that Contents/MacOS/libjli.dylib
is the
Looks good.
/Erik
On 2020-01-31 01:37, Magnus Ihse Bursie wrote:
As reported by Martin Buchholz :
TEST_MODE
The test mode (`-agentvm`, `-samevm` or `-othervm`).
but TEST_MODE=-agentvm is rejected - it must be TEST_MODE=agentvm.
and Jon Gibbons noted:
.. and samevm mode no longer
When running the make tests for the build itself, RunTest.gmk currently
does not attempt at parsing the results. Because of this, failures
aren't detected and so the build does not fail if a test fails. This
patch adds a very rudimentary parsing, defining the whole test run as 1
test and
On 2020-01-29 02:58, Magnus Ihse Bursie wrote:
I got tired of the code duplication of "$(call
DependOnVariableFileName, $1, $2)". Here's a new webrev with shorter
lines,
and hopefully better readability overall:
On 2020-01-28 03:05, Magnus Ihse Bursie wrote:
On 2020-01-28 00:13, Erik Joelsson wrote:
Please review this fix to make the build compatible with GNU make
4.3. See bug for details on the fix, but this change basically adds
an empty rule like this for the example failure:
/localhome/git/jdk
Please review this fix to make the build compatible with GNU make 4.3.
See bug for details on the fix, but this change basically adds an empty
rule like this for the example failure:
Looks good.
/Erik
On 2020-01-27 09:13, Claes Redestad wrote:
Hi,
when generating the default classlist, doing an extra pass with a
-Xshare:dump between means the final classlist will be more in line
with what will be used at runtime.
Webrev:
Looks good.
/Erik
On 2020-01-24 01:27, Baesken, Matthias wrote:
Hi Erik, thanks for the comments, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8236714.7/
Best regards, Matthias
Hello,
That's better, but there are still some issues.
flags-cflags.m4
Code is repeated in both
On 2020-01-23 00:03, Baesken, Matthias wrote:
Hi Erik, yes true sorry for answering your comments a bit late .
If a user runs jlink and includes all the jmods we ship with the JDK, the result
should be essentially equivalent to the original JDK image. The way the
stripped pdb files are
Hello,
That's better, but there are still some issues.
flags-cflags.m4
Code is repeated in both if and else block.
jdk-options.m4
The default is now true for all platforms. I would suggest moving the
s390x conditional down into an elif after the elif for "no".
LibCommon.gmk
Please revert
This still does not address anything in my objection.
/Erik
On 2020-01-22 07:46, Baesken, Matthias wrote:
Hello, here is an updated version :
http://cr.openjdk.java.net/~mbaesken/webrevs/8237192.3/
this one supports a configure switch "--enable-stripped-pdbs"to enable the
feature .
Hello Matthias,
You can keep the setting up of all the flags in flags-cflags.m4 and
flags-ldflags.m4 based on the value of ENABLE_LINKTIME_GC. You can also
default the value of this new parameter to true for s390x to keep the
current behavior for that platform. As it is in this patch, the JVM
That looks good.
/Erik
On 2020-01-21 06:45, Baesken, Matthias wrote:
Hi Erik, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8237374.1/
Best regards, Matthias
-Original Message-
From: Erik Joelsson
Sent: Freitag, 17. Januar 2020 15:18
To: Baesken, Matthias ; 'build-dev
Hello Matthias,
Providing these stripped pdb files in the distribution is a good idea,
but finding a good solution in the build is unfortunately more
complicated than this. The JDK image we ship should (with very few
exceptions) be the result of running jlink on all the jmods. If a user
runs
Hello Matthias,
Using BUILDING_MULTIPLE_JVM_VARIANTS as condition is clever and happens
to coincide with the set of variants that also support CDS, but I would
say this correlation is incidental. I would still prefer an explicit
test for if any of the variants that do support CDS is in the
Looks good.
/Erik
On 2020-01-16 22:47, Baesken, Matthias wrote:
Hello, please review this very small change .
It removes file that are not present any more from the OPT_SPEED_SRC file list
in JvmFeatures.gmk .
( this is a list of files to be optimized for speed when we otherwise optimize
On 2020-01-16 10:48, Ioi Lam wrote:
On 1/16/20 9:09 AM, Erik Joelsson wrote:
I would lean towards changing the check from "if any of the variants
do not support CDS, disable it" to "if any of the variants support
CDS, enable it". The cds jvm feature is only a
I would lean towards changing the check from "if any of the variants do
not support CDS, disable it" to "if any of the variants support CDS,
enable it". The cds jvm feature is only added to the variants that
support it anyway.
If you do this, you probably need to figure out how to explicitly
This does indeed look like a bug to me. At least at Oracle, we no longer
build any multi JVM configs regularly, so things like this falls through
the cracks.
/Erik
On 2020-01-16 02:18, Baesken, Matthias wrote:
Hello, I noticed the following strange "feature" (or is it a bug?) .
When
On 2020-01-15 07:29, Volker Simonis wrote:
Do you know if newer versions of GCC use the gold linker by default? I
remember from some experiments which I did many years ago that gold was
considerably faster compared to the default ld linker.
The default linker is system configured so it depends
Given the discussion regarding lto on hotspot and the extreme increased
build time, have you noticed any difference in build times with this patch?
/Erik
On 2020-01-15 00:27, Baesken, Matthias wrote:
Hi Erik, thanks for the review and for forwarding , you are correct
corelibs-dev is
(adding core-libs-dev)
Change looks good to me, but would like input from at least someone in
core-libs.
/Erik
On 2020-01-14 06:07, Baesken, Matthias wrote:
Hello, the following change enables the link-time section-gc for linux .
gcc and ld support enabling "garbage collection" of unused
Looks good.
/Erik
On 2020-01-13 10:48, Alexandre (Shura) Iline wrote:
Hi.
Can you please review this simple change:
---
$ hg diff
diff -r f7edb9ca045c make/conf/jib-profiles.js
--- a/make/conf/jib-profiles.js Fri Jan 10 15:38:25 2020
Hello Severin,
Looks good.
/Erik
On 2020-01-10 09:28, Bob Vandette wrote:
I like it!
I have to manually copy the libs each time.
BTW: I have a PR in our internal queue to update the graal repo so it can
build with the latest JDK 14.
Bob.
On Jan 10, 2020, at 10:45 AM, Severin Gehwolf
Christoph
*From:*Erik Joelsson
*Sent:* Donnerstag, 2. Januar 2020 09:09
*To:* Langer, Christoph ; build-dev
*Subject:* Re: RFR: 8236488: Support for configure option
--with-native-debug-symbols=internal is impossible on Windows
Hello Christoph,
I think the change makes sense and follows
Hello Christoph,
I think the change makes sense and follows the established behavior on
AIX for invalid settings.
In GtestImage.gmk, instead of repeating the SetupCopy call, you can do
something like this:
41 $(foreach v, $(JVM_VARIANTS), \
42 $(eval $(call SetupCopyFiles,
Build files look good.
/Erik
On 2019-12-24 19:22, Sergey Bylokhov wrote:
Hello.
Here is an updated version:
Bug: https://bugs.openjdk.java.net/browse/JDK-8235975
Patch (2 Mb):
http://cr.openjdk.java.net/~serb/8235975/webrev.03/open.patch
Fix:
Hello Matthias,
Looks good except for the comment. There is no need to add a comment for
something that has been removed, it will just look confusing.
Documenting it in the JBS issue is enough.
Thanks for cleaning this up!
/Erik
On 2019-12-20 09:37, Baesken, Matthias wrote:
Hello, please
Looks good!
/Erik
On 2019-12-18 18:58, Stefan Karlsson wrote:
Adding build-dev.
StefanK
On 2019-12-18 18:52, Stefan Karlsson wrote:
Hi all,
Please review this patch to add a configure check to see if the SDK
supports the APIs needed to build ZGC on Windows.
Looks good.
/Erik
On 2019-12-16 04:27, Claes Redestad wrote:
Hi,
please review this patch[1] which makes the JMH behave more
in line with expectations when adding multiple flags using
the VM_OPTIONS and JAVA_OPTIONS control variables.
E.g., these fail before the patch:
make test TEST=...
Looks good.
/Erik
On 2019-12-12 11:20, Mikael Vidstedt wrote:
Please review this change that adds the newly introduced
--enable-deprecated-ports=yes argument to the relevant build profiles.
Bug: https://bugs.openjdk.java.net/browse/JDK-8235814
webrev:
Looks good.
/Erik
On 2019-12-11 13:38, Mikael Vidstedt wrote:
Please review this change which addresses the warning produced when running
configure, introduced by JDK-8234370.
Bug: https://bugs.openjdk.java.net/browse/JDK-8235789
Webrev:
Looks good.
/Erik
On 2019-12-11 10:46, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
- adds $(X_CFLAGS) to compiler command line.
Patch contributed by Arthur Eubanks (aeuba...@google.com).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8235728
[2]
Build change looks good.
/Erik
On 2019-12-11 06:54, Andy Herrick wrote:
Fix looks fine to me.
adding build-dev since even this simple a makefile change should be
reviewed by build-dev
On 12/10/2019 10:24 PM, Alexander Matveev wrote:
Please review fix [2] for jpackage bug [1].
- Changed
This patch fixes the COMPARE_BUILD baseline. The SVG files generated by
GraphViz are non-deterministic, so adding a sed filter to compensate.
There is also an issue since jpackage was added, where we now have
executables as resources in lib/modules. Those need to be compared as
executables.
We need to customize the image dirs in order to support the new Macos
signing requirements at Oracle. To support this, we need Bundles.gmk to
accept more variable overrides for where the various images are located.
Bug: https://bugs.openjdk.java.net/browse/JDK-8235686
Webrev:
To be able to fully sign and notarize a jdk-bundle on MacOS, the file
Contents/MacOS/libjli.dylib cannot be a symlink. The easy fix is to
simply make it a normal file. Longer term we will evaluate what this
file is actually needed for, but for now, we just need to make the JDK
compatible with
e Thursday to
make it into JDK14 without special approval.
Best regards
Christoph
-Original Message-
From: build-dev On Behalf Of René
Schünemann
Sent: Dienstag, 10. Dezember 2019 09:27
To: Erik Joelsson
Cc: build-dev@openjdk.java.net
Subject: Re: RFR: JDK-8235585: Enable macOS codesigni
Hello René,
Nice to see an OpenJDK solution to this. (Our Oracle solution requires
too much corp specific customization to really benefit from code sharing
with a simple codesign based implementation)
On 2019-12-09 08:06, René Schünemann wrote:
Here is the webrev:
Build changes look good.
/Erik
On 2019-12-06 22:13, Joe Darcy wrote:
Hello,
The time approaches to break ground on JDK 15! Please review the build
changes in the in-progress webev for the JDK 15 inception updates:
http://cr.openjdk.java.net/~darcy/8225361.5/
The make system changes
Looks good.
/Erik
On 2019-12-06 07:40, Jan Lahoda wrote:
Hi,
During build, several warnings are printed:
---
Compiling 68 files for COMPILE_CREATE_SYMBOLS
Sounds good and looks good.
/Erik
On 2019-12-05 20:18, Henry Jen wrote:
OK, so I created an issue[1] for follow up for Windows build and reverted the
change in flags-cflags.m4, if nothing else, I’ll push without another webrev
pinging that I get an +1 from someone in build-de, Erik?
[1]
The issue with jtreg has now been fixed in b16. Here is an updated webrev:
http://cr.openjdk.java.net/~erikj/8230067/webrev.02/index.html
/Erik
On 2019-08-23 14:10, Erik Joelsson wrote:
There seems to be a bug in the new jtreg version, so need to hold off
on this.
/Erik
On 2019-08-22 14:22
Fine with me.
/Erik
On 2019-12-05 09:20, Joe Darcy wrote:
On 12/5/2019 9:06 AM, Erik Joelsson wrote:
On 2019-12-04 19:29, Joe Darcy wrote:
Hello,
First on the build front, the -source/-target used in the bootstrap
build of langtools was stuck at 9; in the change I'm proposing to
update
On 2019-12-04 19:29, Joe Darcy wrote:
Hello,
First on the build front, the -source/-target used in the bootstrap
build of langtools was stuck at 9; in the change I'm proposing to
update it to 13, the minimum boot JDK:
--- old/make/autoconf/boot-jdk.m4 2019-12-04 19:16:42.209000999 -0800
I'm fine with this.
/Erik
On 2019-12-04 15:30, Dan Smith wrote:
On Dec 3, 2019, at 5:24 PM, Jonathan Gibbons
wrote:
Hi Dan,
I think it's a combination of oral tradition and long-standing precedent.
Earlier this year, I raised this general issue, partly because of inconsistent
use of
-generate-debug-info?view=vs-2019
[1]
https://docs.microsoft.com/en-us/cpp/build/reference/pdb-use-program-database?view=vs-2019
-Original Message-
From: Erik Joelsson
Sent: Mittwoch, 4. Dezember 2019 15:46
To: Bob Vandette
Cc: Langer, Christoph ; build-
d...@openjdk.java.net; core-libs-
is produced.
Bob.
On Dec 4, 2019, at 9:11 AM, Erik Joelsson wrote:
Correct, with the Microsoft toolchain there is no support for internal. I don't
know what happens to the build if you try to configure it that way. Feel free
to come up with a reasonable behavior.
/Erik
On 2019-12-04 00:06
Looks good.
/Erik
On 2019-12-04 02:06, Ramkumar Sunderbabu wrote:
Hi all,
Please review this small patch.
Added "-Djdk.attach.allowAttachSelf=true" to jconsole launcher make file. This
will allow jconsole to connect to itself.
JBS: https://bugs.openjdk.java.net/browse/JDK-8228448
Correct, with the Microsoft toolchain there is no support for internal.
I don't know what happens to the build if you try to configure it that
way. Feel free to come up with a reasonable behavior.
/Erik
On 2019-12-04 00:06, Langer, Christoph wrote:
Hi,
I'm currently looking into native
On 2019-11-26 16:39, Weijun Wang wrote:
On Nov 27, 2019, at 12:14 AM, Erik Joelsson wrote:
On 2019-11-25 16:42, Weijun Wang wrote:
On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote:
Build change looks good.
Thanks.
One question: I see the output to stdout from FieldGen.java shown
(adding build-dev)
Build changes look good.
/Erik
On 2019-11-20 09:37, Andy Herrick wrote:
I posted new composite webrev [7], and git patch [8] after pushing fix
for JDK-8234402 [6].
[7] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/
[8]
Looks good.
/Erik
On 2019-11-26 05:07, Baesken, Matthias wrote:
Hello Erik, Florian , currently relro is set already for libjvm.
I think if this works nicely for libjvm, it shouldn't do any harm to set it as
well
in the BASIC_LDFLAGS for other binaries .
I would propose a patch like :
On 2019-11-26 04:53, Baesken, Matthias wrote:
Erik, may I add you as a reviewer too ?
Yes.
/Erik
801 - 900 of 4242 matches
Mail list logo
