Re: RFR: JDK-8155786: Determine modules depending on upgradeable modules directly and indirectly

2016-05-23 Thread Ivan Krylov
(perhaps this question belongs to the jigsaw-dev list..) How upgradable modules are defined. JEP-261 uses this term but does not define it AFAICS. Thanks, Ivan On 19/05/2016 16:15, Alan Bateman wrote: On 18/05/2016 15:39, Erik Joelsson wrote: This patch replaces the list of indirectly upgradeab

Re: visual-studio-community?

2014-11-14 Thread Ivan Krylov
Are you looking at just the hotspot builds within VS or entire JDK? I am not sure that the VS makes a great java editor, so I've only looked at the hotspot part. Previously hotspot had a VS project generator and even though it would generate VS2010 projects - those would be fine within VS2010. T

Re: Cross-building Windows binaries using the mingw toolchain

2014-05-01 Thread Ivan Krylov
What would this give in practical terms? Suppose you are working on a cross-platform bug or feature. You want to make sure that the fix works on Windows as well. I would think that testing the fix with cross-compiled build would be insufficient for the reasons that Volker lists. If the produced

Re: RFR: Bug ID: 9007227: - make/sanity-rules.gmk:61: *** multiple target patterns. Stop

2013-11-19 Thread Ivan Krylov
I went through the exercise of building openjdk 7-8 on Windows and concur it isn't trivial. But google helps and I found very the helpful Volker's blogpost very quickly. This problem should not be solved by adding extra pointer to workarounds. The build system on Windows should work with the lat

Re: JDK-7082220 : Visual Studio projects broken after change: backport to OpenJDK7/hotspot

2013-09-23 Thread Ivan Krylov
Ah, you've figured it out. Thanks for the resolution summary. Ivan On Sep 24, 2013, at 10:41 AM, Ivan Krylov wrote: > Francis, > > Is it possible for you to change the locale into English? > There are a few sed commands in the make script that may not work nicely with &g

Re: JDK-7082220 : Visual Studio projects broken after change: backport to OpenJDK7/hotspot

2013-09-23 Thread Ivan Krylov
Francis, Is it possible for you to change the locale into English? There are a few sed commands in the make script that may not work nicely with non-ascii symbols I just did the same make on the same clone and it succeeded. Ivan On Sep 24, 2013, at 6:46 AM, Francis ANDRE wrote: > Erik > >

Re: JDK-7082220 : Visual Studio projects broken after change: backport to OpenJDK7/hotspot

2013-09-23 Thread Ivan Krylov
I just did a fresh clone of hotspot from jdk7u-dev. The command line build finished ok. The project files got created also just fine but build from Visual studio failed: 1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Platforms\x64\Microsoft.Cpp.x64.Targets(63,5): error : Required file ""

Re: jdk8 build times

2013-09-23 Thread Ivan Krylov
I thought I would pitch in my build times: On i7 MBP with SSD, when booted natively into Windows 7 64bits - 9 min 32 sec Same but virtualized with 4 cores and 4 Gb ram: 15 min 10 sec Ivan On 8/29/13 9:36 AM, Weijun Wang wrote: I have watched this thread for some time. Yes, SSD should be faste

Re: RFR (XXS) 8020622 - Visual Studio 2012 project creation for hotspot

2013-09-08 Thread Ivan Krylov
Hi Ioi, I'd suggest that the next time rules.make gets modified - the default version of VS should become VS2010, not 2003 as it is now. 0.02, Ivan On Aug 27, 2013, at 8:55 AM, Yumin Qi wrote: > Looks good to me. > > Thanks > Yumin > > On 8/26/2013 6:17 PM, Ioi Lam wrote: >> Please review

Re: RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-08 Thread Ivan Krylov
I can't be a reviewer for this change but I do want to support it. I'd be happy to see this rudimentary dependency go away. Ideally I would like to see later a back port to JDK7. Ivan On Sep 7, 2013, at 12:21 AM, Vadim Pakhnushev wrote: > Hi all, > > Please review the fix for this bug: > ht

Re: jdk8 link failure - might be due to uninstalling VS2011 Express

2013-09-01 Thread Ivan Krylov
Pete, Are you building 32-bit or 64-bit hotspot? Can you specify what micros~2.0 actually is? Ivan On Sep 1, 2013, at 9:48 AM, Pete Brunet wrote: > My jdk8 build fails in hotspot build. I have VS2010 installed but it's > possible this is related to having uninstalled VS2011 Express prior to >

Re: OpenJDK Build README

2013-08-28 Thread Ivan Krylov
I should have mentioned that the original subject is about the the "OpenJDK Build README" document On Aug 28, 2013, at 5:16 PM, Ivan Krylov wrote: > Hello, > > I looked today at the readme doc for JDK 8 and came up with a couple of > comments > 1) The doc does not

readme

2013-08-28 Thread Ivan Krylov
Hello, I looked today at the readme doc for JDK 8 and came up with a couple of comments 1) The doc does not mention nashhorn that is being pulled along with the other repos, perhaps it is worth mentioning in the doc. 2) I was under impression that for both JDK7 and JDK8 SP1 of MS Visual Studio i

Re: Windows cross compiles

2013-08-26 Thread Ivan Krylov
The VS compiler supports building 64-bit targets on 32-bit Windows/cl.exe but at some point along the jdk build process the newly built bin\java.exe is being used and that should fail on your 32-bit OS. 0.02, Ivan On Aug 26, 2013, at 12:24 PM, Erik Joelsson wrote: > > > On 2013-08-26 03:51

Re: JDK8 32-bit "docs" build fails on 64-bit Windows

2011-10-30 Thread Ivan Krylov
Hi Ulf. The links below point to variables that contain info on what jvm we're building. Volker's questions was about the bootstrap vm. Using file-like util seems a better option because it simply parses the ELF header of the execulable (or COFF in case of windows) and we don't want to start j

Re: JDK8 32-bit "docs" build fails on 64-bit Windows

2011-10-28 Thread Ivan Krylov
be on holiday and on the EclipsCon next week but after that I can submit a patch if you want. On the other side I'll be not offended if you fix it:) Regards, Volker On Fri, Oct 28, 2011 at 4:48 PM, Dmitry Samersoff wrote: Ivan, On 2011-10-28 17:54, Ivan Krylov wrote: Dima, But we're t

Re: JDK8 32-bit "docs" build fails on 64-bit Windows

2011-10-28 Thread Ivan Krylov
Dima, But we're talking about Windows. Given that we use cygwin anyway we could use file.exe from Cygwin > file java.exe java.exe: PE32 executable (console) Intel 80386, for MS Windows Ivan On 2011-10-28 17:47, Dmitry Samersoff wrote: Volker, under UNIX : file /opt/jdk7/bin/java | grep 32-

Re: JDK8 32-bit "docs" build fails on 64-bit Windows

2011-10-27 Thread Ivan Krylov
Seems that instead of overriding we should be setting MAX_VM_MEMORY = max (MAX_VM_MEMORY, 1024) Ivan On 2011-10-27 20:41, Volker Simonis wrote: I've just realized that building the JDK documentation for a 32-bit build of JDK8 on Windows (with JDK7 as bootstrap JDK) fails: C:/OpenJDK/jdk1.7.0_01

Auto Reply: build-dev Digest, Vol 48, Issue 9

2011-04-26 Thread ivan . krylov
This is an automated reply message. I will be at JavaOne in Moscow on April 11th-13th. The response time might be bigger than usual. For all urgent issues please contact Misha Bykov at [email protected]. Please keep me in CC lists for all emails so that I catch up with the status upon retur