Re: RFR: JDK-8191203 Remove duplicated jimage.hpp

2017-11-21 Thread Jim Laskey (Oracle)
The file was moved from hs to the jdk to simplify the API, not sure why it’s still there. A bulk merge issue maybe. I don’t recall clearly but I think the BSD license was a request from that other big company. Cheers, — Jim > On Nov 21, 2017, at 10:00 AM, Magnus Ihse Bursie >

Re: How to get full path linkage for the jvm shared library

2017-03-02 Thread Jim Laskey (Oracle)
t.com> wrote: > > On 02/03/17 12:53, Jim Laskey (Oracle) wrote: >> Seems that -Wl,-rpath, does what I need. > > -rpath is very dangerous. -rpath-link is much better. > > Andrew. >

Re: How to get full path linkage for the jvm shared library

2017-03-02 Thread Jim Laskey (Oracle)
Seems that -Wl,-rpath, does what I need. > On Mar 1, 2017, at 5:58 PM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > I have a service library that creates an instance of the jvm (on OEL linux.) > I have no control of where the library is used o

Re: JDK 8 cannot be built on Sierra, correct?

2017-02-02 Thread Jim Laskey (Oracle)
> David DeHaven suggests creating a VM to build in. > > http://mail.openjdk.java.net/pipermail/build-dev/2017-January/018518.html > > /Erik > > On 2017-02-01 20:00, Jim Laskey (Oracle) wrote: >> I haven’t tried in a while, but I ran up against it today. >> &

JDK 8 cannot be built on Sierra, correct?

2017-02-01 Thread Jim Laskey (Oracle)
I haven’t tried in a while, but I ran up against it today. Neither the xcode-select (xcode4) or configure --with-xcode-path work. dyld: Library not loaded: @rpath/DVTFoundation.framework/Versions/A/DVTFoundation Referenced from:

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

2016-12-15 Thread Jim Laskey (Oracle)
+1 > On Dec 15, 2016, at 11:32 AM, Sundararajan Athijegannathan > wrote: > > Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 > > top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ > jdk webrev:

Re: Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

2016-11-22 Thread Jim Laskey (Oracle)
+1 > On Nov 22, 2016, at 5:07 PM, Mandy Chung wrote: > > This patch moves src.zip and jrt-fs.jar from the top-level into > the `lib` directory in the run-time image as we proposed [1]. > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ >

random jdk9-dev build error

2016-06-29 Thread Jim Laskey (Oracle)
After a clean got dtrace: failed to compile script /Projects/jdk9-dev/build/macosx-x86_64-normal-server-fastdebug/hotspot/variant-server/support/dtrace/hotspot_jni.h.d: line 1: empty D program translation unit second time worked fine.

Re: RFR 8156847: jdk.dynalink package is shown under "Other Packages" section

2016-05-16 Thread Jim Laskey (Oracle)
+1 > On May 16, 2016, at 12:08 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8156847/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8156847 > > Thanks, > > -Sundar >

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-11 Thread Jim Laskey (Oracle)
+1 > On May 11, 2016, at 12:56 PM, Claes Redestad > wrote: > > Hi, > > please review this change to enable the --order-resources plugin during > build, which helps cold start scenarios by improving locality > > Bug: https://bugs.openjdk.java.net/browse/JDK-8156756

Re: Having problem building jdk9-dev

2016-05-09 Thread Jim Laskey (Oracle)
Boot JDK - got to stop installing EA > On May 9, 2016, at 11:11 AM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > Forwarding from jdk9-dev. > >> Begin forwarded message: >> >> From: "Jim Laskey (Oracle)" <james.las...@oracle.

Fwd: Having problem building jdk9-dev

2016-05-09 Thread Jim Laskey (Oracle)
Forwarding from jdk9-dev. > Begin forwarded message: > > From: "Jim Laskey (Oracle)" <james.las...@oracle.com> > Subject: Re: Having problem building jdk9-dev > Date: May 9, 2016 at 11:07:15 AM ADT > To: jdk9-dev <jdk9-...@openjdk.java.net>, jigsaw-dev

Re: RFR: 8150044: Generate classlists at build-time

2016-05-04 Thread Jim Laskey (Oracle)
and straightforward too. > > /Erik > > [1] http://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz > > On 2016-05-04 16:13, Jim Laskey (Oracle) wrote: >> Correct. How do I set up autogen so I can apply these changes? >> >> >>> On May 4, 2016, at 11:11

Re: RFR: 8150044: Generate classlists at build-time

2016-05-04 Thread Jim Laskey (Oracle)
Correct. How do I set up autogen so I can apply these changes? > On May 4, 2016, at 11:11 AM, Erik Joelsson wrote: > > Build changes look ok to me, but I also helped write most of them. > > This certainly adds some build complexity and might seem overly so for just

Re: Build craziness

2016-04-25 Thread Jim Laskey (Oracle)
; On 2016-04-25 13:24, Jim Laskey (Oracle) wrote: >> A re-run worked fine (but note that the first time was after a clean.) >> >> — Jim >> >>> On Apr 25, 2016, at 8:19 AM, Erik Joelsson <erik.joels...@oracle.com> wrote: >>> >>> Does it

Re: Build craziness

2016-04-25 Thread Jim Laskey (Oracle)
A re-run worked fine (but note that the first time was after a clean.) — Jim > On Apr 25, 2016, at 8:19 AM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Does it happen repeatedly? > > /Erik > > On 2016-04-25 12:31, Jim Laskey (Oracle) wrote: >

Re: Build craziness

2016-04-25 Thread Jim Laskey (Oracle)
> On 2016-04-22 18:10, Jim Laskey (Oracle) wrote: >> >>> Begin forwarded message: >>> >>> From: "Jim Laskey (Oracle)" <james.las...@oracle.com> >>> Subject: Build craziness >>> Date: April 22, 2016 at 11:59:35 AM ADT >>&g

Fwd: Build craziness

2016-04-22 Thread Jim Laskey (Oracle)
> Begin forwarded message: > > From: "Jim Laskey (Oracle)" <james.las...@oracle.com> > Subject: Build craziness > Date: April 22, 2016 at 11:59:35 AM ADT > To: jigsaw-dev <jigsaw-...@openjdk.java.net> > > make clean ; make images > > Buildin

Re: CLANG special case

2015-10-06 Thread Jim Laskey (Oracle)
browse/JDK-8138820> >> So far as I know this is not tracked under any other bug id. >> >> -phil. >> >> On 10/06/2015 05:30 AM, Jim Laskey (Oracle) wrote: >>> I’ve updated to El Capitan and, of course, builds fail, and, of course, I >>> m

CLANG special case

2015-10-06 Thread Jim Laskey (Oracle)
I’ve updated to El Capitan and, of course, builds fail, and, of course, I modify hotspot/make/bsd/makefiles/gcc.make one more time and… I think this conditional clause should be removed at the very least (commenting to indicate needs investigation), or someone should research and see which

Re: RFR 8133347: Add makefiles support and basic session, persistence history navigation with jline

2015-08-13 Thread Jim Laskey (Oracle)
+1 On Aug 12, 2015, at 2:03 PM, Sundararajan Athijegannathan sundararajan.athijegannat...@oracle.com wrote: Hi, Please review changes for the bug: https://bugs.openjdk.java.net/browse/JDK-8133347 This is a subtask of jjs should use jline

Jake, hashes and aliases

2015-04-17 Thread Jim Laskey (Oracle)
java.lang.module.ResolveException: Hash of java.security.jgss (IPAH/Z1wbzCE8aG78apqik6QR94TaBJqcatAkW+35rs=) differs to expected hash (O61Gv4243oRyV7LoD/FjaNBXgRtREFjG4p1Q//V8cGI=) at java.lang.module.Resolver.fail(java.base@9.0/Resolver.java:416) at

Re: Jake, hashes and aliases

2015-04-17 Thread Jim Laskey (Oracle)
I was wrong - that didn’t resolve my issue. On Apr 17, 2015, at 5:07 PM, Jim Laskey (Oracle) james.las...@oracle.com wrote: java.lang.module.ResolveException: Hash of java.security.jgss (IPAH/Z1wbzCE8aG78apqik6QR94TaBJqcatAkW+35rs=) differs to expected hash (O61Gv4243oRyV7LoD

clang 6.1 inteference

2015-04-13 Thread Jim Laskey (Oracle)
Run into an issue after upgrade to clang 6.1 /Volumes/Elephant/Projects/sandbox/hotspot/src/share/vm/opto/chaitin.cpp:2098:8: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] if( !this ) {

Re: RFR 8068650: https://bugs.openjdk.java.net/browse/JDK-8068650

2015-01-08 Thread Jim Laskey (Oracle)
+1 On Jan 8, 2015, at 2:52 AM, A. Sundararajan sundararajan.athijegannat...@oracle.com wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8068650/ for https://bugs.openjdk.java.net/browse/JDK-8068650 This issue was caused by another makefile fix to generate docs for nashorn.

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Jim Laskey (Oracle)
+1 On Nov 28, 2014, at 6:41 AM, A. Sundararajan sundararajan.athijegannat...@oracle.com wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8066146 Thanks, -Sundar

-Wformat-nonliteral

2014-03-28 Thread Jim Laskey (Oracle)
/Projects/jdk9-dev/hotspot/src/share/vm/utilities/debug.cpp:105:19: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf(err, format, ap); ^~ Try to build jdk9-dev tip I ran into this. Wassup? -- Jim

Re: -Wformat-nonliteral

2014-03-28 Thread Jim Laskey (Oracle)
Yes On Mar 28, 2014, at 11:05 AM, Staffan Larsen staffan.lar...@oracle.com wrote: Building with clang? https://bugs.openjdk.java.net/browse/JDK-8037816 https://bugs.openjdk.java.net/browse/JDK-8019470 /Staffan On 28 mar 2014, at 14:28, Jim Laskey (Oracle) james.las...@oracle.com

sjavac

2013-03-11 Thread Jim Laskey (Oracle)
The Nashorn team is wondering about the status of sjavac and the builds. Note: https://jbs.oracle.com/bugs/browse/JDK-8009788 . There are two occurances of -cp which should be convered to -classpath in makefiles/BuildNashorn.gmk . Cheers, -- Jim

Re: 8008977: profiles build broken by Nashorn build changes

2013-03-04 Thread Jim Laskey (Oracle)
I have a change set making its way to tl that removes this requirement. -- Jim On 2013-03-04, at 11:54 AM, Kelly O'Hair kelly.oh...@oracle.com wrote: It seems to me that using $ in class names when they are NOT Inner Classes is a huge mistake. Mark my words, this will come back to haunt

Re: 8008977: profiles build broken by Nashorn build changes

2013-03-04 Thread Jim Laskey (Oracle)
On 2013-03-04, at 11:58 AM, Jim Laskey (Oracle) james.las...@oracle.com wrote: I have a change set making its way to tl that removes this requirement. -- Jim On 2013-03-04, at 11:54 AM, Kelly O'Hair kelly.oh...@oracle.com wrote: It seems to me that using $ in class names when

Re: Dollar ($) expansion still needs attention

2013-03-04 Thread Jim Laskey (Oracle)
I wanted to double check and trace the origins of the MakeBase.gmk patch before I responded. It was part of the original set Erik sent me, but looking thru the other parts of the patch it's not clear why it was necessary. http://cr.openjdk.java.net/~erikj/nashorn-build/webrev.01/ -- Jim