Yes! Thank you for your sponsor Erik!
Jing Tian
在 2019/4/17 21:16, Erik Joelsson 写道:
Looks good!
Do you need a sponsor?
/Erik
On 2019-04-16 18:29, Jing Tian wrote:
Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/
在 2019/4/17 9:26, Jing Tian 写道:
Sorry, because of my
Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/
在 2019/4/17 9:26, Jing Tian 写道:
Sorry, because of my carelessness, I have caused so much trouble.
This is the updated version.
Please review! Thank you.
Jing Tian
在 2019/4/17 0:47, Erik Joelsson 写道:
Hello,
Please add a space after
Sorry, because of my carelessness, I have caused so much trouble.
This is the updated version.
Please review! Thank you.
Jing Tian
在 2019/4/17 0:47, Erik Joelsson 写道:
Hello,
Please add a space after the $ in the examples to match the other
example lines in the file. Otherwise I'm OK
Hi Erik ,
Thank you so much for your suggestions!
Here is the updated version
http://cr.openjdk.java.net/~lzhai/8222444/webrev.02/.
Please review.
Jing Tian
在 2019/4/16 21:20, Erik Joelsson 写道:
Hello Jing Tian,
The last sentence doesn't really fit with the rest. I would just
remo
http://cr.openjdk.java.net/~lzhai/8222444/webrev.01/
Jing Tian
在 2019/4/15 23:24, [email protected] 写道:
As for the wording, I'd suggest "Non-US Locale" instead of
"Non-English." Some tests may depend on US customary behavior, such as
date format, decimal separator, etc.
Naoto
On
permail/compiler-dev/2019-March/013144.html
<https://mail.openjdk.java.net/pipermail/compiler-dev/2019-March/013144.html>
Cheers,
Jing Tian
Thanks Erik ,Tim and David for your review !
Thanks Leslie for your help !
Jing Tian
在 2019/3/26 5:30, David Holmes 写道:
Thanks Erik and Tim. Change pushed.
David
On 26/03/2019 1:57 am, Erik Joelsson wrote:
Looks good.
/Erik
On 2019-03-24 23:29, David Holmes wrote:
On 25/03/2019 4:23 pm
/
A patch by Jing Tian
He also fixed two existing grammar issues.
Please review it.
Thanks,
Leslie Zhai
