Re:

2009-10-22 Thread Martin Buchholz
Hi Max, Sounds to me like you're using a very recent gcc. My policy has been to use a stodgy gcc, and let other folks use bleeding edge. Fedora/Ubuntu hackers are more likely to dogfood their gcc so check out the icedtea patch set. I wish that Openjdk release engineering maintained

Re: JDK 7 build 73 is available at the openjdk.java.net website

2009-10-02 Thread Martin Buchholz
Hi, I tried building jdk7-b73 on Ubuntu dapper, and had it fail with BUILD FAILED .../jaxp/build-defs.xml:66: Could not create task or type of type: replaceregexp. Ant could not find the task or a class this task relies upon. This problem does not happen on Ubuntu hardy. It appears to

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Martin Buchholz
A way to check at runtime, since freetype 2.0.9, is - A new function named `FT_Library_Version' has been added to return the current library's major, minor, and patch version numbers. This is important since the macros FREETYPE_MAJOR, FREETYPE_MINOR, and

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-13 Thread Martin Buchholz
On Thu, Aug 13, 2009 at 13:33, Joseph D. Darcyjoe.da...@sun.com wrote: Hello. From my home network (no Sun VPN, etc.) I was successfully able to do a build of jaxp after applying Kelly's patch and (after setting up the environment a bit

Re: JDK 7 build 59 is available at the openjdk.java.net website

2009-05-17 Thread Martin Buchholz
I'm not sure whether the problem was at my end or your end, but I retried the download and everything is now fine. Martin On Sat, May 16, 2009 at 00:13, Martin Buchholz marti...@google.com wrote: Now the b59 bits are available, but there is a new problem:  $ java -jar jdk-7-ea-plug-b59-linux

Re: JDK 7 build 59 is available at the openjdk.java.net website

2009-05-16 Thread Martin Buchholz
Now the b59 bits are available, but there is a new problem: $ java -jar jdk-7-ea-plug-b59-linux-x64-14_may_2009.jar Invalid or corrupt jarfile jdk-7-ea-plug-b59-linux-x64-14_may_2009.jar Martin On Thu, May 14, 2009 at 19:59, Martin Buchholz marti...@google.com wrote: On Thu, May 14, 2009

Re: PATCH: Tired of waiting for rt.jar to build?

2009-04-28 Thread Martin Buchholz
On Mon, Apr 27, 2009 at 17:54, Martin Buchholz marti...@google.com wrote: Someone who cares about the Makefiles can also try to remove the 16000 gratuitous -C flags that makes jar's life jar hell. Hmmm Apparently I care enough. Kelly (or Tim?), please review. diff --git a/make/common

Re: PATCH: Tired of waiting for rt.jar to build?

2009-04-28 Thread Martin Buchholz
On Tue, Apr 28, 2009 at 16:27, Martin Buchholz marti...@google.com wrote: On Mon, Apr 27, 2009 at 17:54, Martin Buchholz marti...@google.com wrote: Someone who cares about the Makefiles can also try to remove the 16000 gratuitous -C flags that makes jar's life jar hell. Hmmm Apparently I

Re: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

2009-04-20 Thread Martin Buchholz
On Mon, Apr 20, 2009 at 02:06, Andrew Haley a...@redhat.com wrote: Jonathan Gibbons wrote: Andrew. Earlier this week, Mark announced that Release Team approval was required for the final M3 builds for JDK7. [1] Glad I asked. Even without that, jcheck would require that you have another

Re: Binary blobs for older trees?

2009-03-04 Thread Martin Buchholz
The jdk7 builds at http://download.java.net/jdk7/archive/ are for the non-open-source jdk7. The binary plugs for recent openjdk7 builds are available in non-obvious places like http://download.java.net/openjdk/jdk7/promoted/b45/ but b45 is the oldest available build. I would like to see all of

Re: Heads Up: JDK 7 Linux platforms moving to Fedora 9

2008-12-20 Thread Martin Buchholz
On Fri, Dec 19, 2008 at 11:39, Kelly O'Hair kelly.oh...@sun.com wrote: So what we need to do is figure out if there is a way to build on Fedora9 that allows the product to work better on other systems, or if we need to change to something other than Fedora9. Constructive suggestions are

Re: Heads Up: JDK 7 Linux platforms moving to Fedora 9

2008-12-19 Thread Martin Buchholz
build 42 has come, and the JDK binaries no longer work on my system (32-bit Ubuntu dapper). java -version gives an instant crash with floating point exception. Not very friendly. I have always liked the fact that in the past Sun's JDK engineers put in great effort to ensure that JDK binaries

Re: OpenJDK 6 build 14 source posted

2008-12-03 Thread Martin Buchholz
On Wed, Dec 3, 2008 at 11:38, Joe Darcy [EMAIL PROTECTED] wrote: The source bundle for OpenJDK 6 build 14 is available for download from: http://download.java.net/openjdk/jdk6/ The new Hotspot 11 failed to compile on a modified 64-bit (debian arch=amd64) Ubuntu dapper system as follows:

build readme typo fix

2008-09-07 Thread Martin Buchholz
diff --git a/README-builds.html b/README-builds.html --- a/README-builds.html +++ b/README-builds.html @@ -1429,7 +1429,7 @@ build output is to go. The default output directory will be build/iplatform/i. /dd -dta

Re: AWT Dev splashscreen.so is missing pnggccrd.c

2008-09-02 Thread Martin Buchholz
error, failure to find png_combine_row, and trace where this function is defined and how it might be called. The version of this function in pngrutil.c is only defined if there is _no_ mmx support. Martin On Mon, Sep 1, 2008 at 07:02, Artem Ananiev [EMAIL PROTECTED] wrote: Martin Buchholz wrote

Can't use single bugid for multiple changesets

2008-08-29 Thread Martin Buchholz
Hi Mark, I'm trying to commit my fixes for a particular bug, and I went to the trouble of cleanly separating my changes into 3 changesets, but when I try to do the push, I get: pushing to ssh://[EMAIL PROTECTED]/jdk7/tl-gate/jdk/ searching for changes remote: adding changesets remote: adding

Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Martin Buchholz
Hi Anthony, On Fri, Aug 29, 2008 at 3:30 AM, Anthony Petrov [EMAIL PROTECTED] wrote: Hi Martin, The AWT folks think we need to guard this CPPFLAGS setting with the following condition: ifneq ($(PLATFORM), windows) ... endif I am certain this would work for everyone, but ... I am a

Re: splashscreen.so is missing pnggccrd.c

2008-08-29 Thread Martin Buchholz
On Fri, Aug 29, 2008 at 3:37 AM, Anthony Petrov [EMAIL PROTECTED] wrote: On 08/28/2008 08:33 PM Martin Buchholz wrote: I'm thinking: - the MMX support is in pnggccrd.c, - but that file is never compiled in OpenJDK Why? There's the following line in the make/sun/splashscreen/Makefile

Re: splashscreen.so is missing pnggccrd.c

2008-08-28 Thread Martin Buchholz
On Thu, Aug 28, 2008 at 1:51 AM, Mark Wielaard [EMAIL PROTECTED] wrote: Hi, On Wed, 2008-08-27 at 15:34 -0700, Martin Buchholz wrote: Adding options to use the system versions of these graphics libraries is integrated into IcedTea already. IcedTea and Sun AWT engineers should work together

Re: splashscreen.so is missing pnggccrd.c

2008-08-28 Thread Martin Buchholz
- endif -endif - +# Shun the less than portable MMX assembly code in pnggccrd.c, +# and use alternative implementations in C. +CPPFLAGS += -DPNG_NO_MMX_CODE On Thu, Aug 28, 2008 at 9:33 AM, Martin Buchholz [EMAIL PROTECTED] wrote: I'm thinking: - the MMX support is in pnggccrd.c, - but that file

Re: make sanity RFE

2008-08-27 Thread Martin Buchholz
If you're running on Ubuntu, the makefiles could check for the installed-ness of various build-time dependencies. The Ubuntu packagers (i.e. doko) must already have such a list. Martin On Wed, Aug 27, 2008 at 2:25 PM, Jonathan Gibbons [EMAIL PROTECTED] wrote: For the first time, I've been

Re: splashscreen.so is missing pnggccrd.c

2008-08-27 Thread Martin Buchholz
portable MMX assembly code in pnggccrd.c. +# Newer versions of the PNG-library may not need this option. +CPPFLAGS += -DPNG_NO_MMX_CODE Martin On Wed, Aug 27, 2008 at 5:48 AM, Anthony Petrov [EMAIL PROTECTED] wrote: Hi Martin, On 08/25/2008 08:17 PM Martin Buchholz wrote: Thanks for the link

Re: splashscreen.so is missing pnggccrd.c

2008-08-27 Thread Martin Buchholz
On Wed, Aug 27, 2008 at 5:48 AM, Anthony Petrov [EMAIL PROTECTED] wrote: This is not an ideal solution. Updating to a new libpng version would be fine, however these should be some clean sources (i.e. vanilla libpng source tarball, w/o any static - const swaps, etc.), and secondly it requires

Re: make sanity RFE

2008-08-27 Thread Martin Buchholz
On Wed, Aug 27, 2008 at 3:19 PM, Dalibor Topic [EMAIL PROTECTED] wrote: sudo apt-get build-dep openjdk-6 Wow! __That__'s the command I've been looking for! Martin

Re: splashscreen.so is missing pnggccrd.c

2008-08-25 Thread Martin Buchholz
herring. Martin On Mon, Aug 25, 2008 at 3:16 AM, Anthony Petrov [EMAIL PROTECTED] wrote: Hi Martin, On 08/24/2008 04:44 AM Martin Buchholz wrote: ../../../build/linux-i586/tmp/sun/sun.awt/splashscreen/obj/png.o: In function `png_init_mmx_flags': png.c:(.text+0xbb): undefined reference

Re: splashscreen.so is missing pnggccrd.c

2008-08-24 Thread Martin Buchholz
On Sun, Aug 24, 2008 at 3:55 AM, Andrew Haley [EMAIL PROTECTED] wrote: What's the point of these changes? -const static unsigned long long _mask8_0 = 0x0102040810204080LL; I didn't want to introduce new warnings, and my gcc warned that static should come at the beginning of a declaration.

splashscreen.so is missing pnggccrd.c

2008-08-23 Thread Martin Buchholz
Hi splashscreen/build maintainers, I'm using a non-standard gnu toolchain to build OpenJDK7, and I got errors linking libsplashscreen.so: ../../../build/linux-i586/tmp/sun/sun.awt/splashscreen/obj/png.o: In function `png_init_mmx_flags': png.c:(.text+0xbb): undefined reference to

Re: JRE install bundles for 6u10 are non-executable

2008-07-30 Thread Martin Buchholz
eventually, even if not technically a part of OpenJDK. If I were still at Sun, I probably would have used Sun's internal bug-tracking system to report such bugs. Martin On Wed, Jul 30, 2008 at 4:13 AM, Andrew John Hughes [EMAIL PROTECTED] wrote: 2008/7/30 Martin Buchholz [EMAIL PROTECTED]: I

Re: JRE install bundles for 6u10 are non-executable

2008-07-30 Thread Martin Buchholz
On Wed, Jul 30, 2008 at 10:42 AM, Kelly O'Hair [EMAIL PROTECTED] wrote: If I were still at Sun, I probably would have used Sun's internal bug-tracking system to report such bugs. The bug with the execute permissions is filed, are you refering to another bug? No. Probably the ease of

Re: Building on Win 2008

2008-07-29 Thread Martin Buchholz
Porting OpenJDK to be an actual cygwin program, rather than just being built using cygwin tools, is an obvious target for open source porters. The cygwinized OpenJDK would be available as part of the Cygwin distribution. Obviously a porter would have to fight with many assumptions currently being

Re: OpenJDK 7 build failure in com/sun/tools

2008-07-03 Thread Martin Buchholz
On Wed, Jul 2, 2008 at 6:33 PM, Tim Bell [EMAIL PROTECTED] wrote: I (Tim Bell) wrote: I will test the complete OpenJDK forest part. See below for the when building the jdk repository part: My complete OpenJDK forest build ran OK on solaris-i586. Thanks. I can reproduce this problem on my

OpenJDK 7 build failure in com/sun/tools

2008-07-02 Thread Martin Buchholz
While building images in a mercurial workspace updated as of today, I get /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/classfile : no such file or directory /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/javap : no such file or directory make[1]: ***

Re: [NEW BUG] Running jtreg tests on NetBSD

2008-06-28 Thread Martin Buchholz
Of course, the non-portable constructs in the shell scripts come from a long term mindset of if it's not solaris or linux, it must be windows. Better would be if it's not windows, it must be unix Very compactly (untested): case `uname -s` in Windows* | CYGWIN*) NULL=NUL PS=; FS=\\ ;; *)

Re: Recommended GCC version?

2008-06-20 Thread Martin Buchholz
Many code bases qualify as compiler stress tests. I once recommended that the gcc team use XEmacs as a stress test because the source code's unusual C/C++/Lisp style tended to tickle gcc bugs. I fondly remember the old C preprocessor fails when a macro call contains a comment longer than 128 lines

Re: hg: jdk7/build/jdk: 2 new changesets

2008-06-11 Thread Martin Buchholz
On Wed, Jun 11, 2008 at 2:53 PM, Mark Reinhold [EMAIL PROTECTED] wrote: Date: Tue, 10 Jun 2008 18:09:10 -0700 From: Martin Buchholz [EMAIL PROTECTED] I did my last hg push from a Google machine. I have no idea why mercurial notification thinks I am [EMAIL PROTECTED] Because that's

Re: hg: jdk7/build/jdk: 2 new changesets

2008-06-10 Thread Martin Buchholz
Hi OpenJDK administrators, I did my last hg push from a Google machine. I have no idea why mercurial notification thinks I am [EMAIL PROTECTED] I'd like to have control over my identity, and these days I'd like to be known as Martin Buchholz [EMAIL PROTECTED]. Martin On Tue, Jun 10, 2008 at 5

Improper passing of variables to submake

2008-06-04 Thread Martin Buchholz
This is a bug report with patch. Tim or Kelly, please file a bug on my behalf, and review my fix. In OpenJDK7, If you do make sanity from the root of the forest, I get PREVIOUS_JDK_FILE = jdk--linux-i586.tar.gz ALT_PREVIOUS_JDK_FILE = PREVIOUS_JRE_FILE = jre--linux-i586.tar.gz

Removing vestigial MOTIF references from Makefiles

2008-06-04 Thread Martin Buchholz
Kelly or Tim, here's a bug report with patch. Please file a bug and review my fix. Compiling jawt, I see an unintended and unlikely-to-succeed CPP flag -I/include The culprit appears to be a vestigial reference to the undefined MOTIF_DIR CPPFLAGS += -I$(OPENWIN_HOME)/include \

Re: OpenJDK Build error on Ubuntu 8.04

2008-06-03 Thread Martin Buchholz
On Tue, Jun 3, 2008 at 10:09 AM, Andrew Haley [EMAIL PROTECTED] wrote: Martin Buchholz wrote: Sure, but this bug seems to suggest that we *already* rely on /bin/bash, but we pretend not to by assuming that /bin/sh runs bash. If we rely on bash, let's be straight about it. What the JDK build

duplicated sanity check warning

2008-05-31 Thread Martin Buchholz
This is a bug report. I was trying to build openjdk6, and make sanity got duplicated BUILD_JDK = true lines in the output. Looking at control/make/make/sanity-rules.gmk, I see duplicate lines ifeq ($(JDK_SRC_AVAILABLE), true) @$(ECHO)BUILD_JDK= $(BUILD_JDK) $(MESSAGE_FILE)

Re: Building OpenJDK 7 on Windows XP

2008-05-19 Thread Martin Buchholz
I propose that Sun create an externally-visible tree of binaries in the form that the JDK makefiles expect for ALT_SLASH_JAVA. Then OpenJDK developers could copy this tree to their development machine, set ALT_SLASH_JAVA to this directory, and most of the sanity warnings would evaporate. Of

JDK_DEBUG_IMAGE_DIR

2008-05-17 Thread Martin Buchholz
The only reference to JDK_DEBUG_IMAGE_DIR in the jdk workspace is ./make/common/Release.gmk:1239: $(RM) -r $(JDK_DEBUG_IMAGE_DIR) This variable is defined nowhere. As a result, make images-clobber runs the command rm -f -r This is Mostly Harmless, but what would happen if a user happened to

Re: Runing findbugs

2008-05-13 Thread Martin Buchholz
It looks like you want the -auxclasspath flag to findbugs. See http://findbugs.sourceforge.net/manual/ch11.html (I haven't actually tried this myself) Martin On Tue, May 13, 2008 at 4:37 PM, Kelly O'Hair [EMAIL PROTECTED] wrote: I'm currently looking at how we could possible include a run of

Re: OpenJDK does not build on Solaris nv82

2008-02-05 Thread Martin Buchholz
Alexey Ushakov wrote: Hello Max, Actually, we've already found this problem and passed to the team responsible for the code (Cannot provide you bug id at the moment though, but will do as soon as I get it). For now you can use following workaround in openjdk sources (that worked for me):

Re: RFC: architecture define probably masks variable names in header files

2008-01-23 Thread Martin Buchholz
Christian, I care, and agree with you. I recall many years ago, debugging a mysterious failure building Emacs. Building on Solaris-Sparc defined the symbol sparc, and this caused the build to fail, only if a component of the current working directory was sparc. Martin Christian Thalinger

Re: State of the build on Windows?

2007-07-16 Thread Martin Buchholz
Ted Neward wrote: Having installed the patched make, and having installed all of Cygwin, I then run j2se/make/jdk_generic_profile.sh and cd control/make make sanity from a fresh bash prompt, and I get: sanity-rules.gmk:64: *** multiple target patterns. Stop. ? Is this another

Re: State of the build on Windows?

2007-07-16 Thread Martin Buchholz
Ted Neward wrote: I don't know if these are potential bugs, by the way, or just bad settings on my machine, but (*) JAVA_HOME is set by CMD.exe before invoking bash (as part of a .bat file I created on my machine). Should it be getting it from the Windows environment (is it getting

<    1   2   3