On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
> This change seem to have made this group of declarations obsolete:
> `src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h:157` (follow
> the
> [link](https://github.com/openjdk/jdk/blob/89de756ffbefac452c7df559e2a4eb50bf71368
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/w
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft
On Wed, 4 May 2022 09:08:28 GMT, Matthias Baesken wrote:
> Does this mean that not setting _WIN32_WINNT means :any API is allowed" ?
Hi David , I did one more try with my current setup (VS2017 on a Win10
notebook). I did not set _WIN32_WINNT.
My little test program
#include
#inclu
On Wed, 4 May 2022 08:34:43 GMT, David Holmes wrote:
> I'm confused.
> `src\jdk.crypto.mscapi\windows\native\libsunmscapi\security.cpp` doesn't set
> _WIN32_WINNT so how is that later API being enabled? Does this mean that not
> setting _WIN32_WINNT means :any API is allowed" ?
I found this i
ops_md.c
> (so targeting older Windows versions at other places is most likely not
> useful).
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
adjust API level to Windows 8 for security.cpp and do some cleanup
--
On Tue, 3 May 2022 13:27:41 GMT, David Holmes wrote:
> I agree with Erik - the source locations need to be modified to not define
> it. If we want to keep a record perhaps add an assertion that the value is
> what was expected?
>
> I still feel we have a disconnect between this and an actual c
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft
On Tue, 3 May 2022 08:23:52 GMT, Alan Bateman wrote:
>> Hi Alan, I agree (thats why I did not change the define in harfbuzz, but I
>> missed that wepoll.c is 3rd party code as well).
>
> I assume you can revert the update to the copyright header in the latest
> version as there aren't any chan
ops_md.c
> (so targeting older Windows versions at other places is most likely not
> useful).
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust Copyright year in wepoll.c
-
Changes:
- all: https://
ops_md.c
> (so targeting older Windows versions at other places is most likely not
> useful).
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
set _WIN32_WINNT=0x0601 centrally in flags-cflags.m4
-
Changes:
On Fri, 29 Apr 2022 05:09:35 GMT, David Holmes wrote:
> That only seems to be half of the issue though. If we are defining
> _WIN32_WINNT=0x0601 because the minimum required OS API support level is
> Windows 7, then don't we need a check that the build platform is also at
> least Windows 7?
H
On Thu, 28 Apr 2022 10:24:37 GMT, Matthias Baesken wrote:
> Currently , in target "product-bundles" , the Alpine Linux build fails when
> BusyBox tar is used.
> Error is :
This pull request has now been integrated.
Changeset: 36bf6fbe
Author: Matthias Baesken
Currently , in target "product-bundles" , the Alpine Linux build fails when
BusyBox tar is used.
Error is :
-
Commit messages:
- JDK-8285728
Changes: https://git.openjdk.java.net/jdk/pull/8449/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8449&range=00
Issue: https
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/w
On Wed, 27 Apr 2022 15:10:51 GMT, Alan Bateman wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/winpro
On Thu, 22 Jul 2021 13:42:09 GMT, Matthias Baesken wrote:
> Please review the following change.
> On SUSE Linux 15 configure was running into this error, because of a missing
> X11 header :
>
> checking for X11/extensions/Xrandr.h... no
> configure: error: Could not fi
On Fri, 23 Jul 2021 08:30:28 GMT, Christoph Langer wrote:
> > Hi Christoph, thanks for looking into it. Should we do the same for the
> > other package managers in the case statement (like yum, apt-get) as well ?
> > I only observed it on SLES15 (where zypper was detected) but it might be
> >
vel libXrender-devel libXrandr-devel libXtst-devel libXt-devel
> libXi-devel'.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Deal with other package handler tools
-
Changes:
- all: https://git.openjdk.java.
On Fri, 23 Jul 2021 08:12:21 GMT, Christoph Langer wrote:
> Makes sense to me.
Hi Christoph, thanks for looking into it. Should we do the same for the other
package managers in the case statement (like yum, apt-get) as well ? I only
observed it on SLES15 (where zypper was detected) but it
Please review the following change.
On SUSE Linux 15 configure was running into this error, because of a missing
X11 header :
checking for X11/extensions/Xrandr.h... no
configure: error: Could not find all X11 headers (shape.h Xrender.h Xrandr.h
XTest.h Intrinsic.h).
I wondered about the missin
On Tue, 22 Jun 2021 07:39:28 GMT, Matthias Baesken wrote:
> This change adds a check for binutils 2.25 or higher after 8265783. The
> change 8265783 introduced on linux x86_64 a minimum requirement for binutils
> : "Minimum required would be binutils 2.25 where AVX512 support
On Tue, 22 Jun 2021 10:30:28 GMT, Magnus Ihse Bursie wrote:
> The test should really be on as version, but I agree that it does not seem
> worth the hassle to add another version check, when in practice ld and as are
> bundled together as binutils.
>
> However, I would appreciate a comment cla
dk.java.net/browse/JDK-8265783 )
> I adjusted the existing check that already checked the binutils version by
> looking at the linker output (we do not look at the assembler version and it
> seems to me we do not really invoke the assembler directly, just indirectly
> via gcc).
Mat
This change adds a check for binutils 2.25 or higher after 8265783. The change
8265783 introduced on linux x86_64 a minimum requirement for binutils :
"Minimum required would be binutils 2.25 where AVX512 support was added for
Skylake." (see https://bugs.openjdk.java.net/browse/JDK-8265783 )
I
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote:
> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS
> issue.
>
> I fixed the issue in the harfbuzz sources, but I am not sure of the policy
> here. Do we modify the harfbuzz sources or leave them untouched? Advice is
On Thu, 7 Jan 2021 08:51:25 GMT, Matthias Baesken wrote:
> Hello, for a while the AIX build fails with the following error in the
> harfbuzz build
> 1500-004: (U) INTERNAL COMPILER ERROR while compiling
> OT::MarkBasePosFormat1::collect_varia
> Solution by IBM compiler support is to use "-qdebug=necan", this
> effectively turns off an optimisation called "Early Re-canonizing" on the
> harfbuzz lib.
Matthias Baesken has refreshed the contents of this pull request, and previous
commits have been r
Hello, for a while the AIX build fails with the following error in the
harfbuzz build
1500-004: (U) INTERNAL COMPILER ERROR while compiling
OT::MarkBasePosFormat1::collect_variation_indices(hb_collect_variation_indices_context_t
*) const.
Compilation ended. Contact your Service Representat
On Wed, 11 Nov 2020 12:35:07 GMT, Matthias Baesken wrote:
> The script make/autoconf/configure should give a bit more output in case
> various errors occur (e.g. missing autoconf).
> The new output in case of missing autoconf adds the PATH; additionally we
> show on AIX some in
The script make/autoconf/configure should give a bit more output in case
various errors occur (e.g. missing autoconf).
The new output in case of missing autoconf adds the PATH; additionally we show
on AIX some info on how to install autoconf.
bash /jdk_6/jdk/jdk/configure
Runnable configure scri
On Tue, 29 Sep 2020 07:11:34 GMT, Matthias Baesken wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>>
>>> 127: NSColor* result = nil;
>>> 128:
>>> 129: if (colorIndex < ((useAppleColor) ?
>&g
On Fri, 25 Sep 2020 02:23:07 GMT, David Holmes wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2851:
>
>> 2849: if (buf != NULL) {
>> 2850: CodeBuffer buffer(buf);
>> 2851:
On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>
>> 127: NSColor* result = nil;
>> 128:
>> 129: if (color
On Fri, 18 Sep 2020 08:22:56 GMT, Matthias Baesken wrote:
> hello, this fixes the build when using VS2017. VS2019 does not have the issue
> as far as I know.
> failure was
>
>> ./test/hotspot/gtest/utilities/test_align.cpp(96): error C2220: warning
>> treated as
ht be related to an issue fixed at least in some versions of VS2019 ,
> that is discussed here :
>
> https://developercommunity.visualstudio.com/content/problem/211134/unsigned-integer-overflows-in-constexpr-functionsa.html
>
> https://bugs.openjdk.java.net/browse/JDK-8253239
Matthias B
On Fri, 18 Sep 2020 08:57:36 GMT, Aleksey Shipilev wrote:
>> Matthias Baesken has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR. The p
ht be related to an issue fixed at least in some versions of VS2019 ,
> that is discussed here :
>
> https://developercommunity.visualstudio.com/content/problem/211134/unsigned-integer-overflows-in-constexpr-functionsa.html
>
> https://bugs.openjdk.java.net/browse/JDK-8253239
Matthi
hello, this fixes the build when using VS2017. VS2019 does not have the issue
as far as I know.
failure was
> ./test/hotspot/gtest/utilities/test_align.cpp(96): error C2220: warning
> treated as error - no 'object' file generated
> ./test/hotspot/gtest/utilities/test_align.cpp(156): note: see re
39 matches
Mail list logo
