Re: [8] Review request for 8020060 MoleculeViewerTest demo doesn't work due to SecurityPermissions

2013-09-03 Thread sergey malenkov
The fix looks good for me. Thanks, SAM On 03.09.2013 14:13, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020060 webrev: http://cr.openjdk.java.net/~alexsch/8020060/webrev.00 According to the issue an applet is not

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-09 Thread Sergey Malenkov
Hi Fredrik, Thanks! It looks good to me. Regards, SAM On 09.01.2013 16:07, Fredrik Öhrström wrote: 2013/1/9 Sergey Malenkov : First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will be strange to provide sources for nonexistent (by default) classes. Second, *BeanInfo java

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-09 Thread Sergey Malenkov
(by default) classes. Second, *BeanInfo java files are generated automatically. They are not well-formatted and well-documented. Thanks, SAM On 07.01.2013 19:59, Fredrik Öhrström wrote: 2012/12/18 Sergey Malenkov : Looks OK to me. But there are a lot of images in the make/tools/swing-bea

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2012-12-24 Thread Sergey Malenkov
Hi Fredrik, Looks OK to me. But there are a lot of images in the make/tools/swing-beans/beaninfo/images folder. Could you please check the make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar library will be packed correctly? Also I think that moving of java files from t