ganization,
-revision: "3.0-59-support+1.0",
+revision: "3.0-60-support+1.0",
ext: "zip",
environment_name: "JCOV_HOME",
},
———
Thank you,
Shura
Thank you for fixing it, Magnus.
Sorry I forgot about it.
Shura
> On Apr 28, 2020, at 2:18 AM, Magnus Ihse Bursie
> wrote:
>
> Unfortunately, the fix for JDK-8240241 did not properly update the
> testing.html file (and added a trailing whitespace in the markdown file).
.01/
<http://cr.openjdk.java.net/~shurailine/JDK-8240241/webrev.01/>
Shura
> On Mar 3, 2020, at 12:56 PM, Erik Joelsson wrote:
>
> Looks good.
>
> /Erik
>
> On 2020-03-03 12:45, Alexandre (Shura) Iline wrote:
>> Hi.
>>
>> Can you take a look on
|Content dlTags = new
HtmlTree(HtmlTag.DL).setStyle(HtmlStyle.notes);
...
lines: 428 new; 40 covered; 4 not covered; 43 not code; 341 no information
Webrev: http://cr.openjdk.java.net/~shurailine/JDK-8240241/webrev.00/
Shura.
xt: "zip",
environment_name: "JCOV_HOME",
},
---
Thank you.
Shura
xt: "zip",
environment_name: "JCOV_HOME",
},
Thank you.
Shura
Bug: https://bugs.openjdk.java.net/browse/JDK-8226359
ining about it not been
controlled.
So I suggest to push the change as is. Let me know if you are OK with that. We
can reconsider later, if there would be a need for it.
Thank you.
Shura
> On Apr 9, 2019, at 6:31 AM, Erik Joelsson wrote:
>
> Hello Shura,
>
> If JCOV_FILTERS is eve
> On Apr 9, 2019, at 6:31 AM, Erik Joelsson wrote:
>
> Hello Shura,
>
> If JCOV_FILTERS is ever expected to be set on the make command line
> (typically when running make run-test-prebuilt), then it would be good if we
> could add a way to set it through TEST_OPTS=JCO
uld be specified several
times.)
-exclude_module(em) 'string value' (Option could be specified several
times.)
-fm 'string value' (Option could be specified several times.)
-fm_list 'string value'
Bug: https://bugs.openjdk.java.net/browse/JDK-8221857
Webrev: http://cr.openjdk.java.net/~shurailine/JDK-8221857/webrev.00/
Thank you.
Shura
: "b07",
+// file: "bundles/jcov-3_0.zip",
+organization: common.organization,
+revision: "3.0-57-support+1.0",
+ext: "zip",
environment_name: "JCOV_HOME",
},
Thank you.
Shura
>> and in the prebuilt case, it's the responsibility of RunTestPrebuilt.gmk to
>> adjust things for the lack of a proper spec.gmk and in RunTestPrebuilt.gmk
>> we already check that JDK_IMAGE_DIR points to an existing directory.
>>
>> /Erik
>>
>>> /Magnus
the variable JCOV_IMAGE_DIR unconditionally
> in spec.gmk, so that check would always be true anyway.
>
> What you are asking for is adding a new check that JCOV_HOME is set (this is
> a consequence of setting --with-jcov) and that JCOV_IMAGE_DIR actually points
> to something valid (
Hi,
Please take a look on a change to allow JCov test execution through jib.
Please notice that this fix also changes behavior of RunTest.gmk when
conflicting combination of options is used. JCOV_IMAGE_DIR is now expected to
be set when TEST_OPTS_JCOV is true.
Shura
Bug: https
Looks good.
Shura
> On Jan 24, 2019, at 6:46 AM, Magnus Ihse Bursie
> wrote:
>
> This patch covers some different minor cleanups that I accumulated after
> working on RunTest:
> * Do not override JDK_IMAGE_DIR for jcov testing; instead introduce
> JDK_UNDER_TEST (
Looks good.
pre-run-test target is a much cleaner way to achieve the same result.
Thank you.
Shura
> On Jan 23, 2019, at 2:08 AM, Magnus Ihse Bursie
> wrote:
>
> Recently, jcov support was added to RunTest. This highlighted the need to
> have a structured way to run en
Hi.
Please take a look on a change which is adding new jib profiles to support make
changes introduced by JDK-8214309.
Bug: https://bugs.openjdk.java.net/browse/JDK-8217357
Webrev: http://cr.openjdk.java.net/~shurailine/8217357/webrev.02/
Thank you.
Shura
> On Jan 15, 2019, at 5:35 AM, Magnus Ihse Bursie
> wrote:
>
> Hi Shura,
>
> I see that this is pushed already, but I still have some questions and/or
> follow-up requests:
>
> 1) Do you expect the jcov-test-* targets to be used often? We've recently ran
a
jdk/internal/misc/VM/RuntimeArguments.java
jdk/modules/etc/JdkQualifiedExportTest.java
tools/jar/multiRelease/ApiValidatorTest.java
Again, a thorough analysis will need to be done - here I just quickly scanned
the jtr files.
Shura
> On Jan 8, 2019, at 6:15 PM, David Holmes wrote:
>
e/JDK-8215729
Webrev: http://cr.openjdk.java.net/~shurailine/8215729/webrev.01/
Shura
option.
Webrev: http://cr.openjdk.java.net/~shurailine/8214309/webrev.02
Many thanks to Erik for helping out with this change.
Shura
perties.getProperty("IMPLEMENTOR");
+return (implementorProperty == null) ? "null" :
implementorProperty.replace("\"", "");
} catch (IOException e) {
e.printStackTrace();
}
Thank you.
Shura
Thank you for review!
I have fixed and tested - all good.
Will push tomorrow morning.
Shura
> On Apr 11, 2017, at 1:19 AM, Magnus Ihse Bursie
> wrote:
>
> On 2017-04-10 09:51, Erik Joelsson wrote:
>> Hello,
>>
>> CompileDemos.gmk: 270: The $(call install-f
After some back and forth it was decided that the client demos should stay
intact for JDK9 and be reworked into tests as a part of another JEP.
With that, could you take another look on the suggested changes?
http://cr.openjdk.java.net/~shurailine/8173801/webrev.03
Thank you.
Shura
> On
Creating some other makefiles was not planned as a part of this JEP, Phil.
If the demos are used for testing, do you want me do turn them into manual
tests?
Shura
> On Mar 3, 2017, at 2:45 PM, Phil Race wrote:
>
> And to be clear, the provision for still building these client demos
/JDK-8173801
Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
Shura
25 matches
Mail list logo
