Hi Naoto,
Looks ok.
src/java.base/share/legal/icu.md: Line 7: Can the copyright character
be changed to (c) to make it easier to check copyrights
Thanks, Roger
On 05/22/2019 09:36 PM, naoto.s...@oracle.com wrote:
Hi Erik,
Thank you for your comments. Updated the webrev accordingly:
Build changes look good.
/Erik
On 2019-05-22 18:36, naoto.s...@oracle.com wrote:
Hi Erik,
Thank you for your comments. Updated the webrev accordingly:
https://cr.openjdk.java.net/~naoto/8221431/webrev.04/
Naoto
On 5/22/19 4:13 PM, Erik Joelsson wrote:
Hello Naoto,
In GensrcEmojiData.gmk:
Hi Erik,
Thank you for your comments. Updated the webrev accordingly:
https://cr.openjdk.java.net/~naoto/8221431/webrev.04/
Naoto
On 5/22/19 4:13 PM, Erik Joelsson wrote:
Hello Naoto,
In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double
$$. I would recommend calling the
Hello Naoto,
In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double
$$. I would recommend calling the newer MakeTargetDir macro instead. It
doesn't take an argument.
Otherwise build changes look good.
/Erik
On 2019-05-22 15:56, naoto.s...@oracle.com wrote:
Adding
Adding build-dev, as the change adds a small build tool to parse emoji-data.
Naoto
On 5/22/19 3:26 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8221431
The proposed CSR and changeset are located at:
