Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-21 Thread Tim Bell
On 07/21/16 05:34, Alan Burlison wrote: On 21/07/2016 01:40, Tim Bell wrote: Looks good to me. It is already common practice for the build to set: LC_ALL=C export LC_ALL Note that this doesn't seem to be happening for the tests run by 'make test', at least not on Solaris. The result

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-21 Thread Alan Burlison
On 21/07/2016 01:40, Tim Bell wrote: Looks good to me. It is already common practice for the build to set: LC_ALL=C export LC_ALL Note that this doesn't seem to be happening for the tests run by 'make test', at least not on Solaris. The result is a bunch of date/time formatting test

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-20 Thread Tim Bell
On 07/20/16 17:48, Naoto Sato wrote: Thanks for the review Tim! On 7/20/16 5:40 PM, Tim Bell wrote: Naoto: Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-20 Thread Naoto Sato
Thanks for the review Tim! On 7/20/16 5:40 PM, Tim Bell wrote: Naoto: Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/ The gist of the issue is that those

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-20 Thread Tim Bell
Naoto: Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/ The gist of the issue is that those tools used to generate sources at build time were affected by the

[9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-18 Thread Naoto Sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/ The gist of the issue is that those tools used to generate sources at build time were affected by the