Re: [NEW BUG]: Configure broken on MIPS

2018-03-26 Thread Ao Qi
Thank you very much David:) 2018-03-26 12:38 GMT+08:00 David Holmes : > https://bugs.openjdk.java.net/browse/JDK-8200213 > > Sponsoring. > > David > - > > > On 26/03/2018 12:50 PM, Ao Qi wrote: >> >> 2018-03-23 18:05 GMT+08:00 David Holmes : >>> >>> On 23/03/2018 7:54 PM, Magnus Ihse Bursie wr

Re: [NEW BUG]: Configure broken on MIPS

2018-03-25 Thread David Holmes
https://bugs.openjdk.java.net/browse/JDK-8200213 Sponsoring. David - On 26/03/2018 12:50 PM, Ao Qi wrote: 2018-03-23 18:05 GMT+08:00 David Holmes : On 23/03/2018 7:54 PM, Magnus Ihse Bursie wrote: On 2018-03-23 09:55, David Holmes wrote: On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrot

Re: [NEW BUG]: Configure broken on MIPS

2018-03-25 Thread Ao Qi
2018-03-23 18:05 GMT+08:00 David Holmes : > On 23/03/2018 7:54 PM, Magnus Ihse Bursie wrote: >> >> >> On 2018-03-23 09:55, David Holmes wrote: >>> >>> On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:22, David Holmes wrote: > > Hi Thomas, > > On 23/03

Re: [NEW BUG]: Configure broken on MIPS

2018-03-25 Thread David Holmes
On 24/03/2018 10:15 AM, John Paul Adrian Glaubitz wrote: On Mar 23, 2018, at 7:04 PM, Ao Qi wrote: It might be some time still. I'm working on a complete overhaul of all CFLAGS and LDFLAGS, where this is a part of that picture, but I was not planning on addressing just this thing urgently. S

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread John Paul Adrian Glaubitz
On Mar 23, 2018, at 7:04 PM, Ao Qi wrote: >>> >>> It might be some time still. I'm working on a complete overhaul of all >>> CFLAGS and LDFLAGS, where this is a part of that picture, but I was not >>> planning on addressing just this thing urgently. >>> >>> So, I think this patch will do for no

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread Magnus Ihse Bursie
On 2018-03-24 01:00, David Holmes wrote: On 24/03/2018 1:58 AM, Magnus Ihse Bursie wrote: On 2018-03-23 11:05, David Holmes wrote: On 23/03/2018 7:54 PM, Magnus Ihse Bursie wrote: On 2018-03-23 09:55, David Holmes wrote: On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:2

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread David Holmes
On 24/03/2018 1:58 AM, Magnus Ihse Bursie wrote: On 2018-03-23 11:05, David Holmes wrote: On 23/03/2018 7:54 PM, Magnus Ihse Bursie wrote: On 2018-03-23 09:55, David Holmes wrote: On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:22, David Holmes wrote: Hi Thomas, On 23/0

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread Magnus Ihse Bursie
On 2018-03-23 11:05, David Holmes wrote: On 23/03/2018 7:54 PM, Magnus Ihse Bursie wrote: On 2018-03-23 09:55, David Holmes wrote: On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:22, David Holmes wrote: Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, wo

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread David Holmes
On 23/03/2018 7:54 PM, Magnus Ihse Bursie wrote: On 2018-03-23 09:55, David Holmes wrote: On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:22, David Holmes wrote: Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, would it not be pragmatic to accept Ao's patc

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread Ao Qi
>> >> It might be some time still. I'm working on a complete overhaul of all >> CFLAGS and LDFLAGS, where this is a part of that picture, but I was not >> planning on addressing just this thing urgently. >> >> So, I think this patch will do for now. It solves the immediate problem >> for MIPS, and

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread Magnus Ihse Bursie
On 2018-03-23 09:55, David Holmes wrote: On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:22, David Holmes wrote: Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly woul

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread David Holmes
On 23/03/2018 6:46 PM, Magnus Ihse Bursie wrote: On 2018-03-23 06:22, David Holmes wrote: Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly would not make matters worse. And let Magnus f

Re: [NEW BUG]: Configure broken on MIPS

2018-03-23 Thread Magnus Ihse Bursie
On 2018-03-23 06:22, David Holmes wrote: Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly would not make matters worse. And let Magnus follow up with a cleanup change later? Well I hop

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread Thomas Stüfe
On Fri, Mar 23, 2018 at 6:22 AM, David Holmes wrote: > Hi Thomas, > > On 23/03/2018 2:55 PM, Thomas Stüfe wrote: > >> Hi David, >> >> would it not be pragmatic to accept Ao's patch - it looks fine to me - >> since it certainly would not make matters worse. And let Magnus follow up >> with a clean

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread David Holmes
Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly would not make matters worse. And let Magnus follow up with a cleanup change later? Well I hope Magnus's change is forthcoming. AFAICS it

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread Thomas Stüfe
Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly would not make matters worse. And let Magnus follow up with a cleanup change later? Best Regards, Thomas On Fri, Mar 23, 2018 at 2:37 AM, David Holmes wrote: > On 23/03/2018 11:33 AM, Ao Qi wrot

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread David Holmes
On 23/03/2018 11:33 AM, Ao Qi wrote: So what should be the next? Is that another problem, or should the MIPS broken configure be fixed together? There should be one proper fix to cover all affected platforms. David 2018-03-23 5:04 GMT+08:00 David Holmes : On 23/03/2018 12:13 AM, Erik Joelss

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread Ao Qi
So what should be the next? Is that another problem, or should the MIPS broken configure be fixed together? 2018-03-23 5:04 GMT+08:00 David Holmes : > On 23/03/2018 12:13 AM, Erik Joelsson wrote: >> >> Hello, >> >> The fix looks correct, but I'm starting to think that maybe the >> conditional shou

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread David Holmes
On 23/03/2018 12:13 AM, Erik Joelsson wrote: Hello, The fix looks correct, but I'm starting to think that maybe the conditional should be inverted and instead list the architectures that actually use -m64? It seems a whole lot of them don't. Magnus indicated he was working on a better soluti

Re: [NEW BUG]: Configure broken on MIPS

2018-03-22 Thread Erik Joelsson
Hello, The fix looks correct, but I'm starting to think that maybe the conditional should be inverted and instead list the architectures that actually use -m64? It seems a whole lot of them don't. /Erik On 2018-03-21 23:24, Ao Qi wrote: Hi, I found configure of http://hg.openjdk.java.net/

[NEW BUG]: Configure broken on MIPS

2018-03-21 Thread Ao Qi
Hi, I found configure of http://hg.openjdk.java.net/jdk/jdk was broken on MIPS. the output of configure: ... configure: Using default toolchain gcc (GNU Compiler Collection) checking for gcc... /usr/bin/gcc checking resolved symbolic links for CC... /usr/bin/mips64el-linux-gnuabi64-gcc-6 configur