Erik,
Thanks for the sponsorship!
Regards,
Su -
On Mon, Nov 19, 2018, 17:52 Erik Joelsson Done: https://bugs.openjdk.java.net/browse/JDK-8214062
>
> /Erik
>
> On 2018-11-19 08:18, Erik Joelsson wrote:
> > I can sponsor it.
> >
> > /Erik
>
Done: https://bugs.openjdk.java.net/browse/JDK-8214062
/Erik
On 2018-11-19 08:18, Erik Joelsson wrote:
I can sponsor it.
/Erik
On 2018-11-17 09:55, Sergey wrote:
Hi David,
s/repositorys/repositories/
Thanks,
David
I've fixed that one and double checked the rest of the diff.
H
I can sponsor it.
/Erik
On 2018-11-17 09:55, Sergey wrote:
Hi David,
s/repositorys/repositories/
Thanks,
David
I've fixed that one and double checked the rest of the diff.
Hope it is fine now.
That also would be great if anyone could sponsor that patch.
Thanks,
Sergei
diff -
Hi David,
> s/repositorys/repositories/
>
> Thanks,
> David
>
>
I've fixed that one and double checked the rest of the diff.
Hope it is fine now.
That also would be great if anyone could sponsor that patch.
Thanks,
Sergei
diff --git a/doc/building.md b/doc/building.md
--- a/doc/building.md
++
One typo:
On 17/11/2018 6:20 am, Sergey wrote:
Erik,
The whole section about trees should be removed. That extension is just
for managing a forest of repositories, which we no longer do.
/Erik
Whoops, thanks for pointing that out!
I've fixed it.
diff --git a/doc/building.md b/doc/
Looks good to me.
/Erik
On 2018-11-16 12:20, Sergey wrote:
Erik,
The whole section about trees should be removed. That extension is
just
for managing a forest of repositories, which we no longer do.
/Erik
Whoops, thanks for pointing that out!
I've fixed it.
diff --git a/d
Erik,
> The whole section about trees should be removed. That extension is just
> for managing a forest of repositories, which we no longer do.
>
> /Erik
>
>
Whoops, thanks for pointing that out!
I've fixed it.
diff --git a/doc/building.md b/doc/building.md
--- a/doc/building.md
+++ b/doc/build
One comment below, otherwise good.
On 2018-11-16 06:01, Sergey wrote:
Hi Erik, David,
Thanks for review comments, I've applied fixes accordingly.
Here [1] is the only place where I've left "forest" wording.
I've attached and inlined an updated patch.
Looking forward for further improvements or
Hi Erik, David,
Thanks for review comments, I've applied fixes accordingly.
Here [1] is the only place where I've left "forest" wording.
I've attached and inlined an updated patch.
Looking forward for further improvements or sponsorship.
Thanks,
su -
[1]
http://hg.openjdk.java.net/jdk/sandbox/f
I don't have anything further to add. The best person to update these
docs is the person trying to use them for the first time :)
Thanks,
David
On 16/11/2018 4:35 am, Sergey wrote:
Erik,
Thanks for a quick response!
The defpath part is not obsolete, but "forest" -> "repository" should
proba
Erik,
Thanks for a quick response!
> The defpath part is not obsolete, but "forest" -> "repository" should
> probably be applied to the whole file. The last section about "trees" is
> certainly obsolete however.
Ok, got it! Thanks for clarification!
> As long as you are generating the html vers
Hello Sergey,
On 2018-11-15 07:41, Sergey wrote:
Hi Erik, David,
Thanks for review comments! I've almost addressed them,
however, I have a question worth asking before finalizing a patch.
At the *building.md:1396* [1] (as well as in it's html alter-ego) there's
a section:
>### Setting Up a Fo
Hi Erik, David,
Thanks for review comments! I've almost addressed them,
however, I have a question worth asking before finalizing a patch.
At the *building.md:1396* [1] (as well as in it's html alter-ego) there's
a section:
>### Setting Up a Forest for Pushing Changes (defpath)
I believe it is
Also s/forest/repository/
David
On 14/11/2018 4:30 am, Erik Joelsson wrote:
Good catch, that should indeed be corrected. I would also remove the
"all repositories" part. Something like:
"Run `hg pull -u` to make sure you have the latest changes."
/Erik
On 2018-11-12 12:45, Sergey wrote:
Hi
Good catch, that should indeed be corrected. I would also remove the
"all repositories" part. Something like:
"Run `hg pull -u` to make sure you have the latest changes."
/Erik
On 2018-11-12 12:45, Sergey wrote:
Hi,
I'm not sure if that's the right mailing list, however, I'll try.
Recently,
Hi,
I'm not sure if that's the right mailing list, however, I'll try.
Recently, when I was taking a closer look at build documentation:
* doc/building.html
* doc/building.md
I've noticed there get_source.sh being mentioned. I believe that's a
leftover of JEP-296 Consolidate JDK Forest into a Sing
16 matches
Mail list logo
