Yes! Thank you for your sponsor Erik!
Jing Tian
在 2019/4/17 21:16, Erik Joelsson 写道:
Looks good!
Do you need a sponsor?
/Erik
On 2019-04-16 18:29, Jing Tian wrote:
Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/
在 2019/4/17 9:26, Jing Tian 写道:
Sorry, because of my
Looks good!
Do you need a sponsor?
/Erik
On 2019-04-16 18:29, Jing Tian wrote:
Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/
在 2019/4/17 9:26, Jing Tian 写道:
Sorry, because of my carelessness, I have caused so much trouble.
This is the updated version.
Please review! Thank
Webrev: http://cr.openjdk.java.net/~lzhai/8222444/webrev.03/
在 2019/4/17 9:26, Jing Tian 写道:
Sorry, because of my carelessness, I have caused so much trouble.
This is the updated version.
Please review! Thank you.
Jing Tian
在 2019/4/17 0:47, Erik Joelsson 写道:
Hello,
Please add a space after
Sorry, because of my carelessness, I have caused so much trouble.
This is the updated version.
Please review! Thank you.
Jing Tian
在 2019/4/17 0:47, Erik Joelsson 写道:
Hello,
Please add a space after the $ in the examples to match the other
example lines in the file. Otherwise I'm OK with
Hello,
Please add a space after the $ in the examples to match the other
example lines in the file. Otherwise I'm OK with this version.
/Erik
On 2019-04-16 09:10, Jing Tian wrote:
Hi Erik ,
Thank you so much for your suggestions!
Here is the updated version
Hi Erik ,
Thank you so much for your suggestions!
Here is the updated version
http://cr.openjdk.java.net/~lzhai/8222444/webrev.02/.
Please review.
Jing Tian
在 2019/4/16 21:20, Erik Joelsson 写道:
Hello Jing Tian,
The last sentence doesn't really fit with the rest. I would just
remove it
Hello Jing Tian,
The last sentence doesn't really fit with the rest. I would just remove
it and then list examples for both situations like this:
$ LANG=en_US make test TEST=...
$ make test JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US"
TEST=...
While exporting LANG is
As for the wording, I'd suggest "Non-US Locale" instead of
"Non-English." Some tests may depend on US customary behavior, such as
date format, decimal separator, etc.
Naoto
On 4/15/19 6:59 AM, Erik Joelsson wrote:
Hello,
Documenting this is certainly the least we can do. If our tests depend
Hello,
Documenting this is certainly the least we can do. If our tests depend
on the locale being set to en_US, then I think the best action would be
to provide such a configuration directly in RunTests.gmk. Exporting LANG
should work for all Unix OSes, but most likely not on Windows. The
Hi,
We have discussed the issue of the test cases fail because of locale
before[1].
Thanks for the suggestions given by Naoto and David. I think we can put
this advice in the test doc, which may be better for people to test.
This advice can avoid the problem that caused by locale and we can
10 matches
Mail list logo
