Re: RFR: Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]

Looks good to me. /Erik On 2015-10-26 18:30, Omair Majid wrote: (moving from jdk9-dev) Hi, I have created a webrev at: http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/ Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg] Reviewed-by: omajid

RFR: Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]

(moving from jdk9-dev) Hi, I have created a webrev at: http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/ Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg] Reviewed-by: omajid, prr Contributed-by: Matthias Klose Regards, Omair * Philip Race

hg: jdk8/build/jdk: 8015644: makefile changes to allow integration of new features

Changeset: 16003f414ca3 Author:katleman Date: 2013-06-04 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/16003f414ca3 8015644: makefile changes to allow integration of new features Reviewed-by: tbell, erikj, dholmes Contributed-by: amy.y.w...@oracle.com ! makefiles

Re: Review Request: 8015644 : makefile changes to allow integration of new features

this mechanism yet so the change should not affect anyone else. Thanks, David On 4/06/2013 8:45 AM, Amy Wang wrote: Resend this as it was bounced. Original Message Subject: Review Request: 8015644 : makefile changes to allow integration of new features Date: Mon, 03 Ju

Re: Review Request: 8015644 : makefile changes to allow integration of new features

On 4/06/2013 8:45 AM, Amy Wang wrote: Resend this as it was bounced. Original Message Subject: Review Request: 8015644 : makefile changes to allow integration of new features Date: Mon, 03 Jun 2013 13:54:15 -0700 From: Amy Wang Organization: Oracl

Re: Review Request: 8015644 : makefile changes to allow integration of new features

, David On 4/06/2013 8:45 AM, Amy Wang wrote: Resend this as it was bounced. Original Message Subject: Review Request: 8015644 : makefile changes to allow integration of new features Date: Mon, 03 Jun 2013 13:54:15 -0700 From: Amy Wang Organization: Oracl

Re: Review Request: 8015644 : makefile changes to allow integration of new features

end this as it was bounced. Original Message Subject: Review Request: 8015644 : makefile changes to allow integration of new features Date: Mon, 03 Jun 2013 13:54:15 -0700 From: Amy Wang Organization: Oracle Corporation To: jdk8-...@openjdk.java.net Hi, All, Please

Re: Review Request: 8015644 : makefile changes to allow integration of new features

t affect anyone else. Thanks, David On 4/06/2013 8:45 AM, Amy Wang wrote: Resend this as it was bounced. Original Message Subject: Review Request: 8015644 : makefile changes to allow integration of new features Date: Mon, 03 Jun 2013 13:54:15 -0700 From: Amy Wan

Re: Review Request: 8015644 : makefile changes to allow integration of new features

as it was bounced. Original Message Subject: Review Request: 8015644 : makefile changes to allow integration of new features Date: Mon, 03 Jun 2013 13:54:15 -0700 From: Amy Wang Organization: Oracle Corporation To: jdk8-...@openjdk.java.net Hi, All, Plea

Re: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code

On 24/01/2013 00:23, Martin Buchholz wrote: : Many years ago I filed http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4904617 that remains unaddressed :-( Perhaps as part of this change or set of changes, that bug could be dealt with? Perhaps even by deleting JVM_Read? I believe there is effor

Re: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code

Hello, Makefile changes look fine to me. /Erik On 2013-01-23 23:20, Dan Xu wrote: Hi, I have a fix for JDK-8001334 to remove JVM_* functions and replace with direct system calls. It introduces newmake filechangesin IO area especially on Windows platform. Please help review and approve them

Re: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code

On 1/23/2013 4:23 PM, Martin Buchholz wrote: On Wed, Jan 23, 2013 at 2:20 PM, Dan Xu wrote: Hi, I have a fix for JDK-8001334 to remove JVM_* functions and replace with direct system calls. It introduces newmake filechangesin IO area especially on Windows platform. Please help review and appr

Re: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code

On Wed, Jan 23, 2013 at 2:20 PM, Dan Xu wrote: > Hi, > > I have a fix for JDK-8001334 to remove JVM_* functions and replace with > direct system calls. It introduces newmake filechangesin IO area especially > on Windows platform. Please help review and approve them. > > Bug: > https://jbs.oracle

Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code

Hi, I have a fix for JDK-8001334 to remove JVM_* functions and replace with direct system calls. It introduces newmake filechangesin IO area especially on Windows platform. Please help review and approve them. Bug: https://jbs.oracle.com/bugs/browse/JDK-8001334 webrev: http://cr.openjdk.java.

Re: Review makefile changes for JDK-8004729: Method parameter reflection API

On 01/22/13 20:14, Tim Bell wrote: > On 01/22/13 16:02, David Holmes wrote: >> Hi Eric, >> >> On 23/01/2013 4:47 AM, Eric McCorkle wrote: >>> Hello, >>> >>> Please review and approve the makefile changes for JDK-8004729. >>> >>>

Re: Review makefile changes for JDK-8004729: Method parameter reflection API

On 01/22/13 16:02, David Holmes wrote: Hi Eric, On 23/01/2013 4:47 AM, Eric McCorkle wrote: Hello, Please review and approve the makefile changes for JDK-8004729. This patch add a native method (getParameters0) to the Executable class, and uses the JVM_GetMethodParameters function exported

Re: Review makefile changes for JDK-8004729: Method parameter reflection API

Hi Eric, On 23/01/2013 4:47 AM, Eric McCorkle wrote: Hello, Please review and approve the makefile changes for JDK-8004729. This patch add a native method (getParameters0) to the Executable class, and uses the JVM_GetMethodParameters function exported from the JVM. http://cr.openjdk.java.net

Review makefile changes for JDK-8004729: Method parameter reflection API

Hello, Please review and approve the makefile changes for JDK-8004729. This patch add a native method (getParameters0) to the Executable class, and uses the JVM_GetMethodParameters function exported from the JVM. http://cr.openjdk.java.net/~emc/8004729/webrev.00/ For more discussion of the

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

On Nov 14, 2012, at 2:06 AM, Fredrik Öhrström wrote: > 12 nov 2012 kl. 19:04 skrev Kelly O'Hair: >> Or maybe >> if [ "$(words $(shell cat file))" -ne 0 ] ; then >> > > Well, this one is better. I'll switch to this one, eventually. No hurry on my account. -kto > > //Fredrik >

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

12 nov 2012 kl. 19:04 skrev Kelly O'Hair: > Or maybe >if [ "$(words $(shell cat file))" -ne 0 ] ; then > Well, this one is better. I'll switch to this one, eventually. //Fredrik

hg: jdk8/build: 8003274: build-infra: Makefile changes needed for sjavac

Changeset: f2ac4d0edaae Author:tbell Date: 2012-11-13 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/f2ac4d0edaae 8003274: build-infra: Makefile changes needed for sjavac Summary: changes left in build-infra that are related to sjavac Reviewed-by: ohair, tbell

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

Fredrik, On 2012-11-12 22:04, Kelly O'Hair wrote: > > Interesting. I guess I would have done something like: >if [ "`cat file | wc -w`" -ne 0 ] ; then check if we have words... > ;^) I'm for this variant, because it meaning is obvious. -Dmitry -- Dmitry Samersoff Oracle Java devel

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

On Nov 12, 2012, at 9:32 AM, Fredrik Öhrström wrote: > 12 nov 2012 kl. 17:45 skrev Kelly O'Hair: > >> Looks ok. >> >> xargs used to prune whitespace? That was a new one on me. ;^) > > After reading through this one: > http://stackoverflow.com/questions/369758/how-to-trim-whitespace-from-bash-v

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

12 nov 2012 kl. 17:45 skrev Kelly O'Hair: > Looks ok. > > xargs used to prune whitespace? That was a new one on me. ;^) After reading through this one: http://stackoverflow.com/questions/369758/how-to-trim-whitespace-from-bash-variable I can only say that it seemed like the easiest solution.

Re: Review Request: 8003274: build-infra: Makefile changes needed for sjavac

Looks ok. xargs used to prune whitespace? That was a new one on me. ;^) -kto On Nov 12, 2012, at 5:34 AM, Erik Joelsson wrote: > Here is a collection of changes found by comparing build-infra with > jdk8/build that all relate to sjavac that will be needed when sjavac makes it > into jdk8/tl.

Review Request: 8003274: build-infra: Makefile changes needed for sjavac

Here is a collection of changes found by comparing build-infra with jdk8/build that all relate to sjavac that will be needed when sjavac makes it into jdk8/tl. Fredrik is likely the author of all of them. http://cr.openjdk.java.net/~erikj/8003274/webrev.root.01/

Re: jdk8 makefile changes

Hi Kumar, I know it is a long time since you wrote this, but there have been several changes to build-infra lately that might help with your issues. We filter out the GNU link command. We try harder to locate VS10, and if still not found, it can be set using "sh configure --with-tools-dir=".

Re: Makefile changes

If these changes are integrated and on their way to jdk8/jdk8 already, it's water under the bridge, we need to see them earlier in the future. I appreciate the information though, I looked at these changesets and they look fine, but it is extremely hard to review makefile changes and know

Makefile changes

Here is the make file changes for the install workspace regarding to wix conversion of the jre/jdk installers http://sqe-rb.us.oracle.com/r/12286/ Thanks, Jennifer

Re: Makefile changes

I saw your other email, that it does apply to closed repos. In our current JDK8 PIT (b62/b63?), we have makefile/.gmk file changes in: 7184404: MacOS AU needs to support a scheduled update check 7197469: update copyright year to

Re: Makefile changes

Kelly, Does this include closed repositories like install? My understanding was that no changes had been made for closed repos. -ChrisG On 10/18/2012 1:47 PM, Kelly O'Hair wrote: If you are making any changes to the Makefiles or build process in jdk8, please let us know in the build group buil

Makefile changes

If you are making any changes to the Makefiles or build process in jdk8, please let us know in the build group build-dev@openjdk.java.net. We will need to review and approve ALL Makefile and build changes from now until we change over to the new build-infra Makefiles. The build-infra team can he

Re: jdk8 makefile changes

On 2012-07-10 16:23, Kumar Srinivasan wrote: It looks like autoconf has messed up. From the config.log HOSTCC='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTCXX='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTLD='C:/devtools/cygwin/bin/link.exe' It has picked cl.exe correctly, oopsie on link.exe. You have

Re: jdk8 makefile changes

Hi all, Forgot to send this in: Ran on 10.7.2 OS X with latest Oracle JDK 7 binary as the bootstrapper. All ran fine, ../autoconf/configure did not have execute permissions though, so had to chmod u+x it. Not sure if that's a manual step you want people to take or not. A couple of errors which

Re: jdk8 makefile changes

A Windows tip: * On Windows, I use: make BUILD_LOG_WRAPPER= VERBOSE= The logger tricks in the new makefiles seem to give Windows/CYGWIN grief, not all the time -kto On Jul 9, 2012, at 3:12 PM, Kelly O'Hair wrote: > The jdk8/build forest has been in sync for a

Re: jdk8 makefile changes

This isn't supposed to happen. At least it's the intention that configure should avoid /usr/bin/link in favour of visual studio link. VS10 in a different location is probably the reason for it. What is the path to visual studio on this system? Is the environment variable VS100COMNTOOLS to poin

Re: jdk8 makefile changes

after modifying the spec.gmk, the build is progressing. Kumar It looks like autoconf has messed up. From the config.log HOSTCC='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTCXX='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTLD='C:/devtools/cygwin/bin/link.exe' It has picked cl.exe correctly, oopsie o

Re: jdk8 makefile changes

It looks like autoconf has messed up. From the config.log HOSTCC='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTCXX='C:/PROGRA~1/MSVS10/VC/BIN/cl.exe' HOSTLD='C:/devtools/cygwin/bin/link.exe' It has picked cl.exe correctly, oopsie on link.exe. Kumar On 10/07/2012 10:59 AM, Kumar Srinivasan wrote:

Re: jdk8 makefile changes

The configure script does set a few variables in the spec.gmk file that is used but the hotspot repo. (It does read the spec.gmk file) We did forget about STATIC_CXX though, it should be added to spec.gmk and set appropriately, then the hotspot makefile that looks at it should be adjusted, beca

Re: jdk8 makefile changes

Hi Kelly, The full debug symbol support seems to have issues. In the old build we use ENABLE_FULL_DEBUG_SYMBOLS in both the JDK and Hotspot. In the new build we have ENABLE_DEBUG_SYMBOLS instead. This name difference means hotspot and the JDK are using different "flags" to control the same th

Re: jdk8 makefile changes

On 10/07/2012 11:05 AM, Omair Majid wrote: On 07/09/2012 07:44 PM, David Holmes wrote: Hi Omair, The static vs dynamic link check that you see is only in place for the JDK libraries not hotspot. For hotspot (which has not been modified as part of the build-infra project) you still need to pass

Re: jdk8 makefile changes

On 07/09/2012 07:44 PM, David Holmes wrote: > Hi Omair, > > The static vs dynamic link check that you see is only in place for the > JDK libraries not hotspot. For hotspot (which has not been modified as > part of the build-infra project) you still need to pass STATIC_CXX=false > as a make variabl

Re: jdk8 makefile changes

On 10/07/2012 10:59 AM, Kumar Srinivasan wrote: nOn 7/9/2012 5:20 PM, David Holmes wrote: On 10/07/2012 9:51 AM, Kumar Srinivasan wrote: On windows, I see a failure when building hotspot, as as follows. Kumar link.exe /SAFESEH /manifest kernel32.lib user32.lib gdi32.lib winspool.lib codlg32.li

Re: jdk8 makefile changes

nOn 7/9/2012 5:20 PM, David Holmes wrote: On 10/07/2012 9:51 AM, Kumar Srinivasan wrote: On windows, I see a failure when building hotspot, as as follows. Kumar link.exe /SAFESEH /manifest kernel32.lib user32.lib gdi32.lib winspool.lib codlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.li

Re: jdk8 makefile changes

On 7/9/2012 5:20 PM, David Holmes wrote: On 10/07/2012 9:51 AM, Kumar Srinivasan wrote: On windows, I see a failure when building hotspot, as as follows. Kumar link.exe /SAFESEH /manifest kernel32.lib user32.lib gdi32.lib winspool.lib codlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib

Re: jdk8 makefile changes

On 10/07/2012 9:51 AM, Kumar Srinivasan wrote: On windows, I see a failure when building hotspot, as as follows. Kumar link.exe /SAFESEH /manifest kernel32.lib user32.lib gdi32.lib winspool.lib codlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /m

Re: jdk8 makefile changes

On windows, I see a failure when building hotspot, as as follows. Kumar link.exe /SAFESEH /manifest kernel32.lib user32.lib gdi32.lib winspool.lib co dlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /machine:I386 /opt:REF /opt:ICF,8 /map /debu

Re: jdk8 makefile changes

Hi Omair, The static vs dynamic link check that you see is only in place for the JDK libraries not hotspot. For hotspot (which has not been modified as part of the build-infra project) you still need to pass STATIC_CXX=false as a make variable on the make invocation. David - On 10/07/20

Re: jdk8 makefile changes

Hi Kelly, On 07/09/2012 06:12 PM, Kelly O'Hair wrote: > The jdk8/build forest has been in sync for a few days, so anyone willing to > try the new build system with OpenJDK 8, please > follow these instructions: > > hg clone http://hg.openjdk.java.net/jdk8/build jdk8-build > cd jdk8-bui

Re: jdk8 makefile changes

The jdk8/build forest has been in sync for a few days, so anyone willing to try the new build system with OpenJDK 8, please follow these instructions: hg clone http://hg.openjdk.java.net/jdk8/build jdk8-build cd jdk8-build sh ./get_source.sh cd common/makefiles ../autocon

jdk8 makefile changes

Heads up... We expect to do a sync up of the jdk8/build forest with the latest in the build-infra forest in the next few days. As the new build-infra project starts getting more solid and we contemplate when we can switch the default to building with the new build-infra Makefiles (we don't kno

Re: Need reviewer: build-infra makefile changes

On 2012-06-11 14:57, Erik Joelsson wrote: And I've found two issues in the windows build that I would like to correct. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ Looks fine to me! /Magnus

Re: Need reviewer: build-infra makefile changes

I just pushed this change in. -kto On Jun 11, 2012, at 5:57 AM, Erik Joelsson wrote: > And I've found two issues in the windows build that I would like to correct. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ > > makefiles/java/redist/sajdi/Makefile > The windo

Re: Need reviewer: build-infra makefile changes

And I've found two issues in the windows build that I would like to correct. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ makefiles/java/redist/sajdi/Makefile The windows build broke when the full debug symbols were introduced.

Re: Need reviewer: build-infra makefile changes

Technically, I had plenty of reviewers via the build-infra team, my wording was a bit off on this email. Sorry. These new build-infra changes have now been pushed into the jdk8/build forest. I have NOT verified the build-infra builds, only verified that the existing old makefiles are not impact

Need reviewer: build-infra makefile changes

No impact to the current makefiles. This is changes for the new build-infra makefiles. I'm sure there is more to come. Thanks to Erik, Magnus, Fredrik, and Jonas. If I missed anyone else that has contributed on this, my apologies. 7170079: Adjustments to build-infra makefiles http://cr.openj

hg: jdk7/build/jdk: 7029704: JFB: Refix JFB Custom Revision Version Build/Makefile changes

Changeset: 1c7cac250f71 Author:asaha Date: 2011-03-21 21:36 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1c7cac250f71 7029704: JFB: Refix JFB Custom Revision Version Build/Makefile changes Reviewed-by: mr, ohair ! make/common/Defs.gmk ! make/common/Release.gmk