> This is all as expected, although perhaps questionable style.
>
> Given Fredrik's comments too, are you ok with the changes?
Thanks for the back-story on this corner of the build.
I am fine with the changes.
Tim
On Mar 12, 2012, at 10:14 PM, Tim Bell wrote:
> Hi Kelly
>
>> Need a reviewer for these build-infra changes to the strip properties
>> utility in the corba repository.
>>
>> 7153266: Adjustments to corba strip property utility (neutral to builds)
>> http://cr.openjdk.java.net/~ohair/openjdk8/i
The way properties files are handled in the jdk builds is inconsistent and this
should be
considered a bandaid until we get the common makefile logic up into the top
repository
and used by all lower level repositories.
I recall making a change a long time ago to StripProperties.java to allow for
Frederik,
> In the new build system, the StripProperties and CompileProperties
> will be annotation processors inside the smart javac wrapper inside
> langtools. Neat and clean.
OK. Thank you! It probably much better than sed script with conditional
changes.
-Dmitry
On 2012-03-13 13:47, Fredrik
2012-03-13 10:24, Dmitry Samersoff skrev:
> Frederik,
>
> Just a curious - why we need a Java program here?
> Could sed do the same with less efforts?
In the old build system, there are two StripProperties.java
in corba and in the jdk with slightly different implementations
and command line option
Frederik,
Just a curious - why we need a Java program here?
Could sed do the same with less efforts?
-Dmitry
On 2012-03-13 13:08, Fredrik Öhrström wrote:
> 2012-03-13 06:30, Tim Bell skrev:
>>
>> Sorry, I meant to pick on these lines, and also mention that
>> args.length should be an even numbe
2012-03-13 06:30, Tim Bell skrev:
>
> Sorry, I meant to pick on these lines, and also mention that
> args.length should be an even number at line 64...
>
> 107 infiles.add(args[i]);
> 108 outfiles.add(args[i]);
>
> Otherwise, my remarks apply, FWIW.
You are right,
I wrote:
> I find this is a bit alarming - won't it overwrite the input file with
> the output file?
>
> 120 String infile = inIter.next();
> 121 String outfile = outIter.next();
Sorry, I meant to pick on these lines, and also mention that
args.length should be an even n
Hi Kelly
> Need a reviewer for these build-infra changes to the strip properties utility
> in the corba repository.
>
> 7153266: Adjustments to corba strip property utility (neutral to builds)
> http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/
Looks good overall.
I find this is a
Need a reviewer for these build-infra changes to the strip properties utility
in the corba repository.
7153266: Adjustments to corba strip property utility (neutral to builds)
http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/
-kto
10 matches
Mail list logo
