Hi,
Whatever the name you come up, could you please also update
stringDedup.inline.hpp to use the same names?
Thomas Schatzl pointed out the inconsistent, I made change to use S and
Q, but apparently, I messed up in final patch.
Otherwise, looks good to me too.
-Zhengyu
On 06/15/2018
Hi Matthias,
the name SI seems also quite "common" and may result in other naming
clashes in the future.
Maybe something more readable like STAT_IMPL?
Please also change the name in the comment:
// STAT: String Dedup Stat implementation
Regards,
Rene
On Fri, Jun 15, 2018 at 9:47 AM, Baesken,
Hi Matthias,
Good catch. Patch for me is good if you guys agree on a good uncommon name.
Gruß Thomas
On Fri, Jun 15, 2018, 09:48 Baesken, Matthias
wrote:
> Please review this small change that fixes the AIX build after
> "8203641: Refactor String Deduplication into shared".
>
> We are
va.net; hotspot-...@openjdk.java.net
> Subject: Re: RFR: 8205091: AIX: build errors in hotspot after 8203641:
> Refactor
> String Deduplication into shared
>
> Hi Matthias,
>
> the name SI seems also quite "common" and may result in other naming
> clashes in the futur
Hi Mattias,
the change looks good. Could you please also update the comment in the
line above which still reads "STAT".
Also, maybe "STATI" would be a better name choice (longer is better :)
because the probability of a clash is lower (and it would nicely align
with QUEUE in the comments :) But
