RE: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-20 Thread Langer, Christoph
ava.net > Subject: Re: RFR: 8201429: Support AIX Input Method Editor > (IME) for AWT Input Method Framework (IMF) > > Hello Sergey. > > I'm not sure if I understand what you want to change... > > XCreateGC: > The colors are created upper code, they will be overwritten.

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-20 Thread Ichiroh Takiguchi
ph -Original Message- From: Philip Race [mailto:philip.r...@oracle.com] Sent: Sonntag, 20. Mai 2018 01:53 To: Langer, Christoph Cc: awt-...@openjdk.java.net; Ichiroh Takiguchi ; build-dev@openjdk.java.net; ppc-aix-port- d...@openjdk.java.net Subject: Re: RFR: 8201429: Support AIX Input Meth

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-19 Thread Sergey Bylokhov
m] Sent: Sonntag, 20. Mai 2018 01:53 To: Langer, Christoph Cc: awt-...@openjdk.java.net; Ichiroh Takiguchi ; build-dev@openjdk.java.net; ppc-aix-port- d...@openjdk.java.net Subject: Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF) I think I am 99% OK w

RE: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-28 Thread Langer, Christoph
dk.java.net; ppc-aix-port- > d...@openjdk.java.net > Subject: Re: RFR: 8201429: Support AIX Input Method Editor > (IME) for AWT Input Method Framework (IMF) > > I think I am 99% OK with this. > > In general I see what you are doing here and how you've presented the > webrev. > Treat

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-19 Thread Philip Race
I think I am 99% OK with this. In general I see what you are doing here and how you've presented the webrev. Treating even the new files as moved helps see the differences but it is still a challenge to follow all the moving pieces. So before we had just abstract class

RE: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-18 Thread Langer, Christoph
Hi all, Here is an updated webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201429.2/ Can someone from the graphics/awt team please have a look at that change? Especially checking that we don't break non-AIX platforms? Thanks in advance. @Ichiroh: Thanks for your review and tests.

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-14 Thread Ichiroh Takiguchi
ginal Message- From: Erik Joelsson [mailto:erik.joels...@oracle.com] Sent: Freitag, 4. Mai 2018 17:45 To: Langer, Christoph <christoph.lan...@sap.com>; awt- d...@openjdk.java.net Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net Subject: Re: RFR: 8201429: Support AIX Input Me

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-08 Thread Erik Joelsson
Input Method Editor (IME) for AWT Input Method Framework (IMF) Hello, It looks like what you are trying to achieve is to override awt_InputMethod.c with an OS specific version of that file. We have a construct for this in SetupNativeCompilation that should handle it automatically, if you jus

RE: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-08 Thread Langer, Christoph
le.com] > Sent: Freitag, 4. Mai 2018 17:45 > To: Langer, Christoph <christoph.lan...@sap.com>; awt- > d...@openjdk.java.net > Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > Subject: Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT > Input Met

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-04 Thread Erik Joelsson
Hello, It looks like what you are trying to achieve is to override awt_InputMethod.c with an OS specific version of that file. We have a construct for this in SetupNativeCompilation that should handle it automatically, if you just list the source dirs in priority order. I would suggest

RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-04 Thread Langer, Christoph
Hi, please help reviewing the contribution of the support for the AIX Input Method Editor (IME) in AWT's Input Method Framework. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201429.1/ Bug: https://bugs.openjdk.java.net/browse/JDK-8201429 I took Ichiroh's initial proposal [1] and tried