On 27/09/2019 16:48, Severin Gehwolf wrote:
> Hi,
>
> Could I please get a review of this 8u build change backport which adds
> --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain
> assembler only flags for some builds. For example "-Wa,--generate-
> missing-build-notes=yes"
LGTM
On Fri, Jan 17, 2020 at 2:59 AM Severin Gehwolf wrote:
> Hi,
>
> Could I get a second review from an JDK 8u Reviewer, please?
>
> Thanks,
> Severin
>
> On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote:
> > On 2019-09-27 17:48, Severin Gehwolf wrote:
> > > Hi,
> > >
> > > Could I
Hi,
Could I get a second review from an JDK 8u Reviewer, please?
Thanks,
Severin
On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote:
> On 2019-09-27 17:48, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review of this 8u build change backport which
> > adds
> > --with-extr
On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote:
> On 2019-09-27 17:48, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review of this 8u build change backport which adds
> > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain
> > assembler only flags fo
On 2019-09-27 17:48, Severin Gehwolf wrote:
Hi,
Could I please get a review of this 8u build change backport which adds
--with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain
assembler only flags for some builds. For example "-Wa,--generate-
missing-build-notes=yes", to assembly
Hi,
Could I please get a review of this 8u build change backport which adds
--with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain
assembler only flags for some builds. For example "-Wa,--generate-
missing-build-notes=yes", to assembly files only. As the build system
is different
Looks good.
Paul
On 7/16/19, 2:17 AM, "Severin Gehwolf" wrote:
Hi Paul,
Thanks for the review!
On Mon, 2019-07-15 at 18:02 +, Hohensee, Paul wrote:
> In CompileJvm.gmk, I'd replace
>
> -ASFLAGS := $(JVM_ASFLAGS), \
> +ASFLAGS := $(JVM_ASFLAGS)
Hi Paul,
Thanks for the review!
On Mon, 2019-07-15 at 18:02 +, Hohensee, Paul wrote:
> In CompileJvm.gmk, I'd replace
>
> -ASFLAGS := $(JVM_ASFLAGS), \
> +ASFLAGS := $(JVM_ASFLAGS) $(EXTRA_ASFLAGS), \
>
> with adding EXTRA_ASFLAGS to JVM_ASFLAGS right after where JVM_LDFLAGS is
> f
In CompileJvm.gmk, I'd replace
-ASFLAGS := $(JVM_ASFLAGS), \
+ASFLAGS := $(JVM_ASFLAGS) $(EXTRA_ASFLAGS), \
with adding EXTRA_ASFLAGS to JVM_ASFLAGS right after where JVM_LDFLAGS is
finalized, vis
JVM_LDFLAGS += \
$(SHARED_LIBRARY_FLAGS) \
$(JVM_LDFLAGS_FEATURES) \
$(EXTRA_L
Anyone?
On Mon, 2019-07-08 at 17:56 +0200, Severin Gehwolf wrote:
> Hi,
>
> Could I please get a review for this patch which adds a new configure
> option --with-extra-asflags? The issue at hand is that we, Red Hat,
> need to pass certain extra flags to the assembler when OpenJDK is being
> compi
* Severin Gehwolf:
> Hi Martin,
>
> On Mon, 2019-07-08 at 10:42 -0700, Martin Buchholz wrote:
>> (not really a review ...)
>>
>> I'm confused because the assembler is invoked when compiling any sort of
>> source file - C, C++, or .s/.S.
>> Wouldn't we want assembler flags passed uniformly, no ma
To my surprise I checked the default meaning of ASFLAGS in make and found
'ASFLAGS'
Extra flags to give to the assembler (when explicitly invoked on a
'.s' or '.S' file).
$ make -p |& grep -B1 AS.*FLAG
# default
LINK.S = $(CC) $(ASFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_MACH)
--
# defa
Hi Martin,
On Mon, 2019-07-08 at 10:42 -0700, Martin Buchholz wrote:
> (not really a review ...)
>
> I'm confused because the assembler is invoked when compiling any sort of
> source file - C, C++, or .s/.S.
> Wouldn't we want assembler flags passed uniformly, no matter when the
> assembler is
(not really a review ...)
I'm confused because the assembler is invoked when compiling any sort of
source file - C, C++, or .s/.S.
Wouldn't we want assembler flags passed uniformly, no matter when the
assembler is invoked?
It looks like this patch only affects compilation of .s/.S files in hotspot
Hi,
Could I please get a review for this patch which adds a new configure
option --with-extra-asflags? The issue at hand is that we, Red Hat,
need to pass certain extra flags to the assembler when OpenJDK is being
compiled. -Wa,--generate-missing-build-notes=yes in our case. That's
currently not p
15 matches
Mail list logo
