Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-12-23 Thread Philip Race
From the CSR ; >This change also improves the startup performance, on my current new > laptop mbp 16 + BigSur 11.1 the switching discrete/integrated causes unexpected delays up to 10 seconds. This also has to be a bug. I thought it had gone away. Have we reported that to Apple ? If not we

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-12-23 Thread Sergey Bylokhov
On Wed, 9 Dec 2020 17:40:34 GMT, Victor Dyakov wrote: >>> > @kevinrushforth @prrace could you please review? >>> >>> As we discussed yesterday, it is reviewed but not ready to be approved. >>> We are waiting for a reply from Apple. >> >> @prrace >> We are waiting for it for three months

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-12-09 Thread Victor Dyakov
On Tue, 17 Nov 2020 18:55:51 GMT, Sergey Bylokhov wrote: >> I ran a 3D lighting test that is designed to be a GPU stress test. It's a >> worst case, to be sure, but it take 10 times as long to render with the >> integrated GPU as it does with the discrete GPU: >> >>

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-17 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-17 Thread Phil Race
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-17 Thread Victor Dyakov
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Kevin Rushforth
On Tue, 10 Nov 2020 13:24:21 GMT, Erik Joelsson wrote: >> This is a review request for the bug particularly fixed some time ago: >> https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html >> >> In that review request it was found that the old fix does not work well in >> all cases,

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Erik Joelsson
On Tue, 10 Nov 2020 08:19:13 GMT, Sergey Bylokhov wrote: > This is a review request for the bug particularly fixed some time ago: > https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html > > In that review request it was found that the old fix does not work well in > all cases,

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Kevin Rushforth
On Tue, 10 Nov 2020 08:19:13 GMT, Sergey Bylokhov wrote: > This is a review request for the bug particularly fixed some time ago: > https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html > > In that review request it was found that the old fix does not work well in > all cases,

RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Sergey Bylokhov
This is a review request for the bug particularly fixed some time ago: https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html In that review request it was found that the old fix does not work well in all cases, see:

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 16:25, Philip Race wrote: On 8/25/20, 4:01 PM, Sergey Bylokhov wrote: It is applied if the "automatic graphics switching" is enabled, if the user disables this feature for the "power adapter" mode, then the discrete graphics will be always used. That's a bit misleading If

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Philip Race
On 8/25/20, 4:01 PM, Sergey Bylokhov wrote: It is applied if the "automatic graphics switching" is enabled, if the user disables this feature for the "power adapter" mode, then the discrete graphics will be always used. That's a bit misleading If I disable automatic graphics switching it

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
On 8/25/2020 4:17 PM, Sergey Bylokhov wrote: On 25.08.2020 16:08, Kevin Rushforth wrote: I haven't tested an FX app yet, but since this changes the plist properties, I want to see whether or not FX apps are impacted. It should be affected because the first variation of the fix was pushed

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 16:08, Kevin Rushforth wrote: I haven't tested an FX app yet, but since this changes the plist properties, I want to see whether or not FX apps are impacted. It should be affected because the first variation of the fix was pushed to the FX(if nothing changed since then):

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
This is how other applications work...  Also results are similar to other macbooks without discrete graphics. That's sort of what I was getting at with my earlier question: why have a discrete graphics card that never / seldom gets used? This may be more of a question for Apple, but it

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 15:40, Philip Race wrote: On 8/25/20, 12:27 PM, Sergey Bylokhov wrote: On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Philip Race
On 8/25/20, 12:27 PM, Sergey Bylokhov wrote: On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete graphics card that isn't used most of the

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete graphics card that isn't used most of the time. -- Kevin On 8/24/2020 11:27 PM, Sergey

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 24.08.2020 13:35, Philip Race wrote: Is there any performance cost to doing this ? I'd expect so. Any estimate ? Yes, performance is affected for sure: - SwingMark: OGL_Base: 14000 OGL_Fix: 24000 Metal: 18000 - Here is a j2dbench for the common draw operations(new/old/metal):

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-24 Thread Philip Race
Is there any performance cost to doing this ? I'd expect so. Any estimate ? And there's then no way to explicitly request the discrete card on a 15/16" MBP. Should we release note this ? -phil On 8/21/20, 3:02 AM, Magnus Ihse Bursie wrote: On 2020-08-21 06:55, Sergey Bylokhov wrote:

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-21 Thread Magnus Ihse Bursie
On 2020-08-21 06:55, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8251854 Fix: http://cr.openjdk.java.net/~serb/8251854/webrev.00 The fix looks good from a build perspective. (But it highlights the fact that we have no

RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-20 Thread Sergey Bylokhov
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8251854 Fix: http://cr.openjdk.java.net/~serb/8251854/webrev.00 This is a review request for the bug particularly fixed some time ago: https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html