On Tue, 2 Feb 2021 21:26:28 GMT, Kevin Rushforth wrote:
>> The changes look good to me, but please see my comment from my review about
>> documenting `NormalizedPathNSStringFromJavaString()` API.
>
> The following commit was integrated to jdk master since you created this
> branch:
>
> acbcde8
On Mon, 1 Feb 2021 18:33:32 GMT, Gerard Ziemski wrote:
>> Marked as reviewed by gziemski (Committer).
>
> The changes look good to me, but please see my comment from my review about
> documenting `NormalizedPathNSStringFromJavaString()` API.
The following commit was integrated to jdk master sin
On Mon, 1 Feb 2021 18:31:23 GMT, Gerard Ziemski wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop modul
>
> Marked as reviewed by gziemski (Committer).
T
On Fri, 29 Jan 2021 19:53:32 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.m line 83:
>>
>>> 81: stringWithFileSystemRepresentation:chs length:len];
>>> 82: return result;
>>> 83: }
>>
>> Why are we doing:
>>
>> `java_string -> chars -> NS
On Fri, 29 Jan 2021 17:24:05 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better an
On Mon, 1 Feb 2021 11:35:22 GMT, Magnus Ihse Bursie wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop modul
>
> Build changes look good for this PR.
> *
On Fri, 29 Jan 2021 17:24:05 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better an
On Fri, 29 Jan 2021 16:23:20 GMT, Gerard Ziemski wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop modul
>
> src/java.desktop/macosx/native/libawt_lwawt/a
On Fri, 29 Jan 2021 17:02:30 GMT, Gerard Ziemski wrote:
>> Changes requested by gziemski (Committer).
>
> Lots of small changes you had to handle here. Thank you for doing it!
I pushed a commit with the remaining -lframework ... removals in the desktop
makefiles that I had somehow missed ...
-
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
10 matches
Mail list logo
