Re: RFR: 8276654: element-list order is non deterministic [v5]

2021-11-08 Thread Magnus Ihse Bursie
On Mon, 8 Nov 2021 14:17:56 GMT, Andrew Leonard wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt file

Re: RFR: 8276654: element-list order is non deterministic [v4]

2021-11-08 Thread Andrew Leonard
On Mon, 8 Nov 2021 13:29:57 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8276654: element-list order is non deterministic >> >> Signed-off-by: Andrew Leonard > > make/modules/jdk.

Re: RFR: 8276654: element-list order is non deterministic [v5]

2021-11-08 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g

Re: RFR: 8276654: element-list order is non deterministic [v4]

2021-11-08 Thread Magnus Ihse Bursie
On Mon, 8 Nov 2021 12:41:01 GMT, Andrew Leonard wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt file

Re: RFR: 8276654: element-list order is non deterministic [v3]

2021-11-08 Thread Andrew Leonard
On Sun, 7 Nov 2021 11:55:19 GMT, Andrew Leonard wrote: >> Can someone please verify that the contents of these files after the fix is >> the same as the contents of the files for "good" builds before the fix? > >> Can someone please verify that the contents of these files after the fix is >> th

Re: RFR: 8276654: element-list order is non deterministic [v4]

2021-11-08 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g

Re: RFR: 8276654: element-list order is non deterministic [v3]

2021-11-08 Thread Magnus Ihse Bursie
On Sun, 7 Nov 2021 11:55:19 GMT, Andrew Leonard wrote: >> Can someone please verify that the contents of these files after the fix is >> the same as the contents of the files for "good" builds before the fix? > >> Can someone please verify that the contents of these files after the fix is >> th

Re: RFR: 8276654: element-list order is non deterministic [v3]

2021-11-07 Thread Andrew Leonard
On Sat, 6 Nov 2021 20:54:27 GMT, Jonathan Gibbons wrote: > Can someone please verify that the contents of these files after the fix is > the same as the contents of the files for "good" builds before the fix? @jonathan-gibbons done, all good - PR: https://git.openjdk.java.net/jdk/

Re: RFR: 8276654: element-list order is non deterministic [v3]

2021-11-06 Thread Jonathan Gibbons
On Fri, 5 Nov 2021 19:47:04 GMT, Andrew Leonard wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt file

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 19:36:34 GMT, Andrew Leonard wrote: >> yep, i'll have a look to see what I can do, not helped with existing >> variables being so long!! (GENERATE_SYMBOLS_FROM_JDK_VERSION) > > yep, split on CommaList seems better and works fine, see revision Does it work if you have space af

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 19:26:56 GMT, Andrew Leonard wrote: >> make/modules/jdk.javadoc/Gendata.gmk line 75: >> >>> 73: $(call MakeTargetDir) >>> 74: $(call LogInfo, Creating javadoc element lists) >>> 75: $(RM) $(ELEMENT_LISTS_DIR)/element-list-{$(call >>> CommaList,$(call

Re: RFR: 8276654: element-list order is non deterministic [v3]

2021-11-05 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 19:20:10 GMT, Erik Joelsson wrote: >> Andrew Leonard has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > make/modules/jdk.javadoc/Gendata.gmk

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Erik Joelsson
On Fri, 5 Nov 2021 18:46:26 GMT, Andrew Leonard wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt file

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 16:15:02 GMT, Erik Joelsson wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt files

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 16:15:02 GMT, Erik Joelsson wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt files

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 16:15:02 GMT, Erik Joelsson wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt files

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Erik Joelsson
On Fri, 5 Nov 2021 15:26:40 GMT, Andrew Leonard wrote: > Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. >

RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Andrew Leonard
Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 A intermittent problem with the make dependencies means the jdk.javadoc element-list-.txt generation can remove the src defined element|package-list-<7,8,9,10>.txt files. Recreatable by using --with-jobs=1 causing jdk.javadoc "gendata" to a