Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Andrew Leonard
On Fri, 12 Nov 2021 14:34:50 GMT, Erik Joelsson wrote: >> Sorry, I'm mis-reading the lines here. It's of course for docs-zip. Then >> it's perfectly in order! :-) > > It's using JarArchive.gmk, which is a similar, but different and probably > also needs the same treatment. We should probably

Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Erik Joelsson
On Fri, 12 Nov 2021 14:28:31 GMT, Magnus Ihse Bursie wrote: >> make/Main.gmk line 511: >> >>> 509: MAKEFILE := Docs, \ >>> 510: TARGET := docs-zip, \ >>> 511: DEPS := docs-jdk buildtools-jdk, \ >> >> Is this really needed? I did not think jrtfs-jar used zip? > > Sorry, I'm

Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Magnus Ihse Bursie
On Fri, 12 Nov 2021 14:24:00 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8276743: Make openjdk build Zip Archive generation "reproducible" >> >> Signed-off-by: Andrew Leonard >

Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Erik Joelsson
On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard wrote: >> This PR adds a new openjdk build tool MakeZipReproducible, which if >> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a >> deterministic way, ensuring ordering and timestamps are set as specified. >> >> Using

Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Magnus Ihse Bursie
On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard wrote: >> This PR adds a new openjdk build tool MakeZipReproducible, which if >> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a >> deterministic way, ensuring ordering and timestamps are set as specified. >> >> Using

Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Magnus Ihse Bursie
On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard wrote: >> This PR adds a new openjdk build tool MakeZipReproducible, which if >> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a >> deterministic way, ensuring ordering and timestamps are set as specified. >> >> Using

Re: RFR: 8276743: Make openjdk build Zip Archive generation "reproducible" [v5]

2021-11-12 Thread Andrew Leonard
> This PR adds a new openjdk build tool GenerateZip, which generates a final > "zip" file from an input folder, and creates it in a deterministic way, > ensuring ordering and timestamps are set as specified. > > Using this tool in ZipArchive.gmk will ensure src.zip is then created >