Re: RFR: JDK-8055352: AIX hprof should include its own copy of dladdr in porting_aix.c

2014-08-25 Thread Staffan Larsen
I have just sent out a review request for JDK-8043936: "Drop HPROF as demo, keep as HPROF agent shipped with JDK”. That change removes hprof completely from the demos which makes the change below obsolete. So if my change is accepted, the change below is no longer needed. Thanks, /Staffan On

Re: RFR: JDK-8055352: AIX hprof should include its own copy of dladdr in porting_aix.c

2014-08-23 Thread Alan Bateman
On 23/08/2014 07:08, Volker Simonis wrote: Hi Erik, I'll be back in office and have a closer look at your change on Tuesday. Until then - which change moved porting_aix.* to the two new locations? It seems strange that a "modularization change" requires code duplication - that's not how I unde

Re: RFR: JDK-8055352: AIX hprof should include its own copy of dladdr in porting_aix.c

2014-08-22 Thread Volker Simonis
Hi Erik, I'll be back in office and have a closer look at your change on Tuesday. Until then - which change moved porting_aix.* to the two new locations? It seems strange that a "modularization change" requires code duplication - that's not how I understand modularization:) Regards, Volker On

Re: RFR: JDK-8055352: AIX hprof should include its own copy of dladdr in porting_aix.c

2014-08-21 Thread Tim Bell
Hi Erik: Please review this minor fix for hprof demo on aix. When reorganizing the source code for modules, we put a copy of src/aix/porting/porting_aix.* in each of the two locations using it. One of them was the hprof demo. This patch removes the now unused extra source dir declaration for

RFR: JDK-8055352: AIX hprof should include its own copy of dladdr in porting_aix.c

2014-08-21 Thread Erik Joelsson
Hello, Please review this minor fix for hprof demo on aix. When reorganizing the source code for modules, we put a copy of src/aix/porting/porting_aix.* in each of the two locations using it. One of them was the hprof demo. This patch removes the now unused extra source dir declaration for hp