On 2017-12-05 06:59, David Holmes wrote:
Magnus,
It seems these changes have broken all Windows builds:
Oh f*ck. :-(
I didn't test my re-addition of the Copy-jdk.accessibility.gmk file
properly. :(
I opened https://bugs.openjdk.java.net/browse/JDK-8193045.
/Magnus
Copying support/module
Magnus,
It seems these changes have broken all Windows builds:
Copying support/modules_include/jdk.accessibility/win32/bridge
/usr/bin/cp -fP
'/cygdrive/c/jprt/T/P1/042744.daholme/s/open/src/jdk.accessibility/windows/native/include/bridge'
'/cygdrive/c/jprt/T/P1/042744.daholme/s/build/windows-
On 5/12/2017 9:59 AM, Magnus Ihse Bursie wrote:
On 2017-12-05 00:28, David Holmes wrote:
Hi Magnus,
There may be a further wart here to resolve.
But of course...
From the "bump the classfile version to 54" thread on jdk-dev:
---
Don't you also need to update:
jdk/src/java.b
On 12/4/17 3:59 PM, Magnus Ihse Bursie wrote:
And classfile_constants.h is also distributed with the image. I am
unsure of the intent/history. To play it safe i will just bump the
number.
Hmmm - that seems wrong. jvm.h is not an exported external interface
AFAIK. And we just moved it so I do
On 2017-12-05 00:28, David Holmes wrote:
Hi Magnus,
There may be a further wart here to resolve.
But of course...
From the "bump the classfile version to 54" thread on jdk-dev:
---
Don't you also need to update:
jdk/src/java.base/share/native/include/classfile_constants.h
>>
Hi Magnus,
There may be a further wart here to resolve. From the "bump the
classfile version to 54" thread on jdk-dev:
---
Don't you also need to update:
jdk/src/java.base/share/native/include/classfile_constants.h
#define JVM_CLASSFILE_MAJOR_VERSION 53
>>> I can
Looks good.
/Erik
On 2017-12-04 12:40, Magnus Ihse Bursie wrote:
On 2017-12-04 19:17, mandy chung wrote:
On 12/4/17 9:33 AM, Erik Joelsson wrote:
Hello Magnus,
The -copy targets are currently only being generated for
modules that have make/copy/Copy-.gmk makefiles present. By
removing m
On 12/4/17 12:40 PM, Magnus Ihse Bursie wrote:
Technically, it's of course possible. But it does not fit very well
with the current DeclareRecipesForPhase. I agree with Erik, that for
now the reasonable approach is to have files that only include
CopyCommon. We can consider for future updates
On 2017-12-04 19:17, mandy chung wrote:
On 12/4/17 9:33 AM, Erik Joelsson wrote:
Hello Magnus,
The -copy targets are currently only being generated for
modules that have make/copy/Copy-.gmk makefiles present. By
removing make/copy/Copy-jdk.accessibility.gmk and
make/copy/Copy-jdk.jdwp.agen
On 12/4/17 9:33 AM, Erik Joelsson wrote:
Hello Magnus,
The -copy targets are currently only being generated for
modules that have make/copy/Copy-.gmk makefiles present. By
removing make/copy/Copy-jdk.accessibility.gmk and
make/copy/Copy-jdk.jdwp.agent.gmk, those targets are no longer create
Hello Magnus,
The -copy targets are currently only being generated for modules
that have make/copy/Copy-.gmk makefiles present. By removing
make/copy/Copy-jdk.accessibility.gmk and
make/copy/Copy-jdk.jdwp.agent.gmk, those targets are no longer created
so the logic in CopyCommon will not be ex
On 2017-12-04 13:56, David Holmes wrote:
On 4/12/2017 10:44 PM, Magnus Ihse Bursie wrote:
On 2017-12-04 12:17, David Holmes wrote:
Hi Magnus,
On 4/12/2017 9:06 PM, Magnus Ihse Bursie wrote:
JDK-8190484 was created as a follow-up bug to the unification of
the duplicated jvm.h, jvm_md.h and jmm
On 4/12/2017 10:44 PM, Magnus Ihse Bursie wrote:
On 2017-12-04 12:17, David Holmes wrote:
Hi Magnus,
On 4/12/2017 9:06 PM, Magnus Ihse Bursie wrote:
JDK-8190484 was created as a follow-up bug to the unification of the
duplicated jvm.h, jvm_md.h and jmm.h, to determine the proper
location of t
On 2017-12-04 12:17, David Holmes wrote:
Hi Magnus,
On 4/12/2017 9:06 PM, Magnus Ihse Bursie wrote:
JDK-8190484 was created as a follow-up bug to the unification of the
duplicated jvm.h, jvm_md.h and jmm.h, to determine the proper
location of these files. This has now been decided to be
hots
Hi Magnus,
On 4/12/2017 9:06 PM, Magnus Ihse Bursie wrote:
JDK-8190484 was created as a follow-up bug to the unification of the
duplicated jvm.h, jvm_md.h and jmm.h, to determine the proper location
of these files. This has now been decided to be hotspot/share/include
and hotspot/os/$OS/includ
JDK-8190484 was created as a follow-up bug to the unification of the
duplicated jvm.h, jvm_md.h and jmm.h, to determine the proper location
of these files. This has now been decided to be hotspot/share/include
and hotspot/os/$OS/include, respectively.
This patch moves the relevant files there,
16 matches
Mail list logo
