Looks good.
/Erik
On 2017-11-21 03:13, Magnus Ihse Bursie wrote:
I ran a duplicate name check on the source base. Then I discovered
that there is a jimage.hpp in both
src/hotspot/share/classfile/jimage.hpp and
src/java.base/share/native/libjimage/jimage.hpp. They are identical
(apart from c
Magnus:
Looks good to me as well.
Tim
On 11/21/17 06:11, Jim Laskey (Oracle) wrote:
The file was moved from hs to the jdk to simplify the API, not sure why it’s
still there. A bulk merge issue maybe. I don’t recall clearly but I think the
BSD license was a request from that other big compa
The file was moved from hs to the jdk to simplify the API, not sure why it’s
still there. A bulk merge issue maybe. I don’t recall clearly but I think the
BSD license was a request from that other big company.
Cheers,
— Jim
> On Nov 21, 2017, at 10:00 AM, Magnus Ihse Bursie
> wrote:
>
> O
On 2017-11-21 12:44, David Holmes wrote:
Hi Magnus,
This seems fine to me.
Do you know what the story is with the copyright header?
No, I don't. It was introduced in JDK-8149776, which has just a brief
rationale:
"Allow the jimage native code to be more easily re-used in JVM
implementations w
Hi Magnus,
This seems fine to me.
Do you know what the story is with the copyright header?
Thanks,
David
On 21/11/2017 9:13 PM, Magnus Ihse Bursie wrote:
I ran a duplicate name check on the source base. Then I discovered that
there is a jimage.hpp in both src/hotspot/share/classfile/jimage.hp
I ran a duplicate name check on the source base. Then I discovered that
there is a jimage.hpp in both src/hotspot/share/classfile/jimage.hpp and
src/java.base/share/native/libjimage/jimage.hpp. They are identical
(apart from copyright headers), and once again, we shouldn't have both.
David Holm
