I like the new structure. Looks good.
/Erik
On 2020-05-19 04:33, Magnus Ihse Bursie wrote:
How derpy of me. I forgot to post the link to the updated webrev!
http://cr.openjdk.java.net/~ihse/JDK-8244093-move-ide-support/webrev.02/
/Magnus
On 2020-05-18 16:50, Magnus Ihse Bursie wrote:
Hi
The move looks good - but afaik, Netbeans also used to have some
langtools-specific project files.
There's also the topic of where to put source files that are in support
of the IDE. For instance there are a couple of Ant task which used to
support netbeans, and another to support Intellij
On 2020-05-19 12:41, Maurizio Cimadamore wrote:
The move looks good - but afaik, Netbeans also used to have some
langtools-specific project files.
I'm not sure what you mean. There used to be three netbeans IDE project;
one for Hotspot, one for Langtools and one for the "JDK" (read:
corelibs).
On 19/05/2020 12:39, Magnus Ihse Bursie wrote:
The main reason for this refactoring is to clear up all the "junk"
that is spread out all over the make directories. Unfortunately, the
"make" directory has, since historic times, been seen as a
nice-to-have "misc" category where you can just
How derpy of me. I forgot to post the link to the updated webrev!
http://cr.openjdk.java.net/~ihse/JDK-8244093-move-ide-support/webrev.02/
/Magnus
On 2020-05-18 16:50, Magnus Ihse Bursie wrote:
Hi all,
Sorry for the long time to follow up on this patch.
From the reviewers' feedback, I have
Hi all,
Sorry for the long time to follow up on this patch.
From the reviewers' feedback, I have now restored all files to
make/langtools, except for those in the netbeans and intellij
directories. This also meant that in the make/ide/idea/langtools
directory there were now only an
On 4/30/2020 12:28 AM, Jan Lahoda wrote:
Hi Brad,
This is very similar to what I do. Some small comments inline.
On 29. 04. 20 21:02, Bradford Wetmore wrote:
Jan,
What is your current recommended technique to use NetBeans to
build/edit/test OpenJDK for normal OpenJDK library developers?
Hi Brad,
This is very similar to what I do. Some small comments inline.
On 29. 04. 20 21:02, Bradford Wetmore wrote:
Jan,
What is your current recommended technique to use NetBeans to
build/edit/test OpenJDK for normal OpenJDK library developers?
After many versions of Netbeans, my current
Jan,
What is your current recommended technique to use NetBeans to
build/edit/test OpenJDK for normal OpenJDK library developers?
After many versions of Netbeans, my current setup is to:
1. Do an external "exploded" build
2. Run Netbeans, open the src/java.base module project and any
On 29/04/2020 12:45, Magnus Ihse Bursie wrote:
Let's say we keep it in langtools (unless we can find a better home
for it). My question is: Are we talking only about build.properties
and build.xml? Or are there more files that these depend on, that I
had assumed belong to the IDE generation?
> On 29 Apr 2020, at 11:36, Magnus Ihse Bursie
> wrote:
>
> ...
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8244093
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8244093-move-ide-support/webrev.01
The make/idea changes look ok to me.
-Chris.
On 2020-04-29 13:06, Jan Lahoda wrote:
I am not sure if anyone is still using make/jdk/netbeans. Apache
NetBeans does not (should not) need these config files, it supports
OpenJDK modules out of the box (with some tweaks/dependencies on
make/langtools/** to speed up langtools build).
It's by
On 2020-04-29 13:36, Maurizio Cimadamore wrote:
On 29/04/2020 11:57, Magnus Ihse Bursie wrote:
So who/what is using the ant build? I thought it was just the IDEA
project that generated ant targets. Is it run explicitly using ant by
langtool developers? I know for sure it's not used when we
On 29/04/2020 11:57, Magnus Ihse Bursie wrote:
So who/what is using the ant build? I thought it was just the IDEA
project that generated ant targets. Is it run explicitly using ant by
langtool developers? I know for sure it's not used when we build the
product in our CI.
As Jan mentioned,
I am not sure if anyone is still using make/jdk/netbeans. Apache
NetBeans does not (should not) need these config files, it supports
OpenJDK modules out of the box (with some tweaks/dependencies on
make/langtools/** to speed up langtools build).
As Maurizio, there may be some need to move the
On 2020-04-29 12:47, Maurizio Cimadamore wrote:
Didn't review in detail, but some pieces seems suspicious - e.g.
moving "/make/langtools/build.properties" to
"///make/ide/idea/langtools/build.properties//
Note that langtools's build.properties is used by the langtools ANT
build which is
Didn't review in detail, but some pieces seems suspicious - e.g.
moving "/make/langtools/build.properties" to
"///make/ide/idea/langtools/build.properties//
Note that langtools's build.properties is used by the langtools ANT
build which is independent from make - and also mostly independent
The IDE support in OpenJDK unfortunately leaves a lot to be desired.
There have been a garden variety of attempt to support a specific IDE
for a specific part of the code base, cluttered all over the code base.
This patch is a first attempt go get one ring, eh..., structure, to rule
them all.
18 matches
Mail list logo
