Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-28 Thread Magnus Ihse Bursie
On 2020-08-26 17:01, Erik Joelsson wrote: I realized that for LTS releases, the logic adding a numeric only $OPT string will bail out as we (Oracle) are then adding LTS to the $OPT string. To fix this, I've added an explicit setting of the new configure parameter --with-macosx-bundle-build-vers

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-26 Thread Sergey Bylokhov
+1 On 26.08.2020 08:01, Erik Joelsson wrote: I realized that for LTS releases, the logic adding a numeric only $OPT string will bail out as we (Oracle) are then adding LTS to the $OPT string. To fix this, I've added an explicit setting of the new configure parameter --with-macosx-bundle-build

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-26 Thread Erik Joelsson
I realized that for LTS releases, the logic adding a numeric only $OPT string will bail out as we (Oracle) are then adding LTS to the $OPT string. To fix this, I've added an explicit setting of the new configure parameter --with-macosx-bundle-build-version from the jib configuration for CI buil

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-25 Thread Sergey Bylokhov
Looks fine. On 25.08.2020 07:27, Erik Joelsson wrote: On 2020-08-24 19:18, Sergey Bylokhov wrote: Hi, Erik. I would like to highlight one thing affected by this fix. The text in the default about dialog in the Swing application will be changed. For my local build:  - Current text: "Java Ver

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-25 Thread Erik Joelsson
On 2020-08-24 19:18, Sergey Bylokhov wrote: Hi, Erik. I would like to highlight one thing affected by this fix. The text in the default about dialog in the Swing application will be changed. For my local build:  - Current text: "Java Version 1.0 (16)"  - After the fix: "Java Version 16 (0)"

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-24 Thread Sergey Bylokhov
Hi, Erik. I would like to highlight one thing affected by this fix. The text in the default about dialog in the Swing application will be changed. For my local build: - Current text: "Java Version 1.0 (16)" - After the fix: "Java Version 16 (0)" I am not sure why the build version and as a r

RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-24 Thread Erik Joelsson
When fixing JDK-8246094, I concluded that our Info.plist files are in a bit of a mess. This patch tries to address this on a more fundamental level. 1. All Info.plist files and templates are moved to the same location in the source tree. 2. The CFBundleIdentifier is changed to no longer conta