Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread David Katleman
On 3/26/2014 3:39 PM, Mike Duigou wrote: I have updated the webrev to add the tclone. I also moved the initial clone from non-local source to only the closed repo case. The check isn't necessary for the case where all sub-repos will be relative to the root repo and not in a separate forest.

Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread Mike Duigou
I have updated the webrev to add the tclone. I also moved the initial clone from non-local source to only the closed repo case. The check isn't necessary for the case where all sub-repos will be relative to the root repo and not in a separate forest. http://cr.openjdk.java.net/~mduigou/JDK-8038

Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread Mike Duigou
On Mar 26 2014, at 14:52 , David Katleman wrote: > Hi Mike, > > A few minor comments, overall looks good. > > On 3/26/2014 2:11 PM, Mike Duigou wrote: >> Hello all; >> >> I introduced bug in JDK-8030681 which prevents non-clone commands from >> receiving parameters. >> >> I also slightly cl

Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread David Katleman
Hi Mike, A few minor comments, overall looks good. On 3/26/2014 2:11 PM, Mike Duigou wrote: Hello all; I introduced bug in JDK-8030681 which prevents non-clone commands from receiving parameters. I also slightly cleaned up checking for what is an acceptable root repo as I had encountered th

RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread Mike Duigou
Hello all; I introduced bug in JDK-8030681 which prevents non-clone commands from receiving parameters. I also slightly cleaned up checking for what is an acceptable root repo as I had encountered this in a problem with a local clone and reverted prior change which made the script a bash scrip